Fix remaining Biome lints

Author: SplittyDev

badgers-web/src/app/codeberg/release/[owner]/[repo]/route.ts

@@ -15,13 +15,12 @@ export async function GET(request: NextRequest, { params: { owner, repo } }: Par
 
     const shortestName = (() => {
         if (release === null) { return null }
-        return [release?.tag_name, release?.name]
-        .filter(Boolean)
-        .reduce((a, b) => a!.length < b!.length ? a : b)
+        return [release.tag_name, release.name]
+            .reduce((a, b) => a.length < b.length ? a : b)
     })()
 
     return await Badge.generate(request, 'release', shortestName ?? 'None', {
-        color: !!shortestName ? 'blue' : 'yellow'
+        color: shortestName ? 'blue' : 'yellow'
     })
 }
 

badgers-web/src/app/codeberg/stars/[owner]/[repo]/route.ts

@@ -15,7 +15,7 @@ export async function GET(request: NextRequest, { params: { owner, repo } }: Par
     const stargazers = repository?.stars_count
 
     return await Badge.generate(request, 'stars', stargazers?.toString() ?? 'None', {
-        color: !!stargazers ? 'blue' : 'yellow'
+        color: stargazers ? 'blue' : 'yellow'
     })
 }
 

badgers-web/src/app/github/contributors/[owner]/[repo]/route.ts

@@ -14,6 +14,6 @@ export async function GET(request: NextRequest, { params: { owner, repo } }: Par
     const resp = await GitHub.wrapRequest(
         octokit => octokit.repos.listContributors({ owner, repo })
     )
-    if (resp.data === undefined) return await Badge.error(request, 'github')
-    return await Badge.generate(request, 'contributors', resp.data!.length.toString())
+    if (!resp.data) return await Badge.error(request, 'github')
+    return await Badge.generate(request, 'contributors', resp.data.length.toString())
 }

badgers-web/src/app/github/license/[owner]/[repo]/route.ts

@@ -16,6 +16,6 @@ export async function GET(request: NextRequest, { params: { owner, repo } }: Par
     )
     const licenseName = resp.data?.license?.spdx_id ?? resp.data?.license?.name
     return await Badge.generate(request, 'license', licenseName ?? 'unknown', {
-        color: !!licenseName ? 'blue' : 'gray'
+        color: licenseName ? 'blue' : 'gray'
     })
 }

badgers-web/src/app/icons/IconShelf.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { useMemo, useState } from "react"
+import { Fragment, useMemo, useState } from "react"
 
 import type { IconSetList } from "./page"
 
@@ -32,13 +32,13 @@ export default function IconShelf({ icons }: Props) {
                         )}
                         {Object.entries(icons).map(([name, data]) => {
                             return (
-                                <>
+                                <Fragment key={name}>
                                     <div className="flex justify-center items-center bg-gray-700 rounded-md w-8 h-8">
                                         {/* eslint-disable-next-line @next/next/no-img-element */}
                                         <img width="20" height="20" alt={name} src={data} />
                                     </div>
                                     <div className="text-gray-800">{name}</div>
-                                </>
+                                </Fragment>
                             )
                         })}
                     </div>

badgers-web/src/app/layout.tsx

@@ -10,6 +10,15 @@ import type { Metadata, Viewport } from "next";
 
 const inter = Inter({ subsets: ["latin"] });
 
+const metadataBase = (() => {
+    const proto = process.env.NEXT_PUBLIC_WEB_PROTO
+    const host = process.env.NEXT_PUBLIC_WEB_HOST
+    if (!proto || !host) {
+        throw new Error("Missing environment variables: NEXT_PUBLIC_WEB_PROTO, NEXT_PUBLIC_WEB_HOST")
+    }
+    return new URL(`${proto}://${host}`)
+})()
+
 export const metadata: Metadata = {
   title: "SpaceBadgers",
   applicationName: "SpaceBadgers",
@@ -24,7 +33,7 @@ export const metadata: Metadata = {
   ],
   authors: [{ name: "Marco Quinten", url: "https://github.com/splittydev" }],
   creator: "Marco Quinten",
-  metadataBase: new URL(`${process.env.NEXT_PUBLIC_WEB_PROTO!}://${process.env.NEXT_PUBLIC_WEB_HOST!}`),
+  metadataBase,
 }
 
 export const viewport: Viewport = {

badgers-web/src/components/Path.tsx

@@ -1,3 +1,5 @@
+import { Fragment } from "react"
+
 type Props = {
     value: string,
 }
@@ -50,7 +52,7 @@ export default function Path({ value }: Props) {
                 value,
                 className: getPathColor(value, isQueryParam ? queryParamCount - 1 : isDynamic ? dynamicIndex++ : staticIndex++, isProtocol, isQueryParam),
                 isQuery: isQueryParam,
-                renderAmpersand: queryParamCount == 2
+                renderAmpersand: queryParamCount === 2
             }
         })
     }
@@ -60,15 +62,15 @@ export default function Path({ value }: Props) {
     return (
         <div className="flex flex-wrap whitespace-pre-wrap text-gray-400 font-mono">
             {parts.map(({ value, className, isQuery, renderAmpersand }, i) => (
-                <>
-                    {!isQuery && (!containsProtocol || (containsProtocol && i != 0)) && (
-                        <div key={`sep-${value}`}>/</div>
+                <Fragment key={value}>
+                    {!isQuery && (!containsProtocol || (containsProtocol && i !== 0)) && (
+                        <div>/</div>
                     )}
                     {renderAmpersand && <div className={className}>&amp;</div>}
-                    <div key={value} className={className}>
+                    <div className={className}>
                         {value}
                     </div>
-                </>
+                </Fragment>
             ))}
         </div>
     )

badgers-web/src/utils/Badge.ts

@@ -1,7 +1,5 @@
 import { type NextRequest, NextResponse } from "next/server"
 
-const pick = (obj: any, keys: string[]) => Object.fromEntries(keys.map(key => [key, obj[key]]))
-
 interface BadgeOverrides {
     labelColor?: string,
     color?: string,
@@ -13,7 +11,7 @@ interface BadgeOverrides {
  *
  * Uses the Spacebadgers worker to generate badges.
  */
-export default class Badge {
+const Badge = {
 
     /**
      * Generate a badge.
@@ -24,7 +22,7 @@ export default class Badge {
      * @param overrides Badge overrides.
      * @returns The badge response.
      */
-    static async generate(request: NextRequest, label: string, status: string, overrides: BadgeOverrides = {}): Promise<NextResponse> {
+    async generate(request: NextRequest, label: string, status: string, overrides: BadgeOverrides = {}): Promise<NextResponse> {
         // Get API configuration from env
         const api = {
             proto: process.env.NEXT_PUBLIC_API_PROTO,
@@ -43,8 +41,9 @@ export default class Badge {
             .replace(/^\?+/gm, '').split('&')
             .reduce((acc, pair) => {
                 const [key, value] = pair.split('=')
-                return {...acc, [key]: value}
-            }, {})
+                acc[key] = value
+                return acc
+            }, {} as Record<string, string>)
         const unifiedQueryOverrides = {...systemQueryOverrides, ...userQueryOverrides}
         const queryParams = Object
             .entries(unifiedQueryOverrides)
@@ -74,13 +73,13 @@ export default class Badge {
             statusText: resp.statusText,
             headers,
         })
-    }
+    },
 
-    static async error(request: NextRequest, subsystem: string): Promise<NextResponse> {
+    async error(request: NextRequest, subsystem: string): Promise<NextResponse> {
         return await Badge.generate(request, subsystem, 'error', { color: 'gray' })
-    }
+    },
 
-    static async passThrough(request: NextRequest): Promise<NextResponse> {
+    async passThrough(request: NextRequest): Promise<NextResponse> {
         const api = {
             proto: process.env.NEXT_PUBLIC_API_PROTO,
             host: process.env.NEXT_PUBLIC_API_HOST,
@@ -102,5 +101,7 @@ export default class Badge {
             statusText: resp.statusText,
             headers,
         })
-    }
+    },
 }
+
+export default Badge

badgers-web/src/utils/Codeberg.ts

@@ -25,7 +25,7 @@ class CodebergClient {
         this.token = token
     }
 
-    buildUrl(path: string, query: Record<string, any> = {}): string {
+    buildUrl(path: string, query: Record<string, string | number | boolean> = {}): string {
         const queryArgs = {
             ...query,
             token: this.token,
@@ -47,7 +47,7 @@ class CodebergClient {
         return await resp.json() as Repository
     }
 
-    async getIssuesCount({ owner, repo }: ProjectInfo, query: Record<string, any> = {}): Promise<number | null> {
+    async getIssuesCount({ owner, repo }: ProjectInfo, query: Record<string, string | number | boolean> = {}): Promise<number | null> {
         const repoId = `${owner}/${repo}`
         const url = this.buildUrl(`repos/${repoId}/issues`, query)
         const resp = await fetch(url)
@@ -67,8 +67,10 @@ class CodebergClient {
     }
 }
 
-export default class Codeberg {
-    static getClient(): CodebergClient {
+const Codeberg = {
+    getClient(): CodebergClient {
         return new CodebergClient(process.env.CODEBERG_TOKEN as string)
-    }
+    },
 }
+
+export default Codeberg

badgers-web/src/utils/Crates.ts

@@ -2,20 +2,22 @@ import { CratesIO } from 'crates.io'
 
 type WrappedCratesRequest<T> = (arg0: CratesIO) => Promise<T>
 
-export default class Crates {
-    static getCratesClient(): CratesIO {
+const Crates = {
+    getCratesClient(): CratesIO {
         return new CratesIO()
-    }
+    },
 
-    static async wrapRequest<T>(request: WrappedCratesRequest<T>): Promise<T | null> {
+    async wrapRequest<T>(request: WrappedCratesRequest<T>): Promise<T | null> {
         try {
             return await request(Crates.getCratesClient())
         } catch (error) {
             return null
         }
-    }
+    },
 }
 
+export default Crates
+
 // Disable Vercel data cache for all requests.
 // This is a temporary solution. Once we can serve all routes via fetch,
 // we can remove this and use the next revalidate feature.