[UXTHEME] Implement various Vista+ functions, mostly from WINE

Author: Splitwirez

dll/win32/uxtheme/CMakeLists.txt

@@ -1,7 +1,12 @@
 
 include_directories(${REACTOS_SOURCE_DIR}/sdk/include/reactos/wine)
 add_definitions(-D__WINESRC__ -D__ROS_LONG64__)
-spec2def(uxtheme.dll uxtheme.spec ADD_IMPORTLIB)
+
+if(DLL_EXPORT_VERSION GREATER_EQUAL 0x600)
+    spec2def(uxtheme.dll uxtheme_vista.spec ADD_IMPORTLIB)
+else()
+    spec2def(uxtheme.dll uxtheme.spec ADD_IMPORTLIB)
+endif()
 
 list(APPEND SOURCE
     buffer.c

dll/win32/uxtheme/buffer.c

@@ -19,6 +19,28 @@
  */
 
 #include "uxthemep.h"
+#include <wine/heap.h>
+
+struct paintbuffer
+{
+    HDC targetdc;
+    HDC memorydc;
+    HBITMAP bitmap;
+    RECT rect;
+    void *bits;
+};
+
+static void free_paintbuffer(struct paintbuffer *buffer)
+{
+    DeleteObject(buffer->bitmap);
+    DeleteDC(buffer->memorydc);
+    heap_free(buffer);
+}
+
+static struct paintbuffer *get_buffer_obj(HPAINTBUFFER handle)
+{
+    return handle;
+}
 
 /***********************************************************************
  *      BufferedPaintInit                                  (UXTHEME.@)
@@ -41,35 +63,104 @@ HRESULT WINAPI BufferedPaintUnInit(VOID)
 /***********************************************************************
  *      BeginBufferedPaint                                 (UXTHEME.@)
  */
-HPAINTBUFFER WINAPI BeginBufferedPaint(HDC hdcTarget,
-                                       const RECT * prcTarget,
-                                       BP_BUFFERFORMAT dwFormat,
-                                       BP_PAINTPARAMS *pPaintParams,
-                                       HDC *phdc)
+HPAINTBUFFER WINAPI BeginBufferedPaint(HDC targetdc, const RECT *rect,
+        BP_BUFFERFORMAT format, BP_PAINTPARAMS *params, HDC *retdc)
 {
-    static int i;
+#if (defined(_MSC_VER))
+    char bmibuf[FIELD_OFFSET(BITMAPINFO, bmiColors) + 256 * sizeof(RGBQUAD)];
+#else
+    char bmibuf[FIELD_OFFSET(BITMAPINFO, bmiColors[256])];
+#endif
+    BITMAPINFO *bmi = (BITMAPINFO *)bmibuf;
+    struct paintbuffer *buffer;
 
-    TRACE("Stub (%p %p %d %p %p)\n", hdcTarget, prcTarget, dwFormat,
-          pPaintParams, phdc);
+    TRACE("(%p %s %d %p %p)\n", targetdc, wine_dbgstr_rect(rect), format,
+          params, retdc);
 
-    if (!i++)
-        FIXME("Stub (%p %p %d %p %p)\n", hdcTarget, prcTarget, dwFormat,
-              pPaintParams, phdc);
-    return NULL;
+    if (retdc)
+        *retdc = NULL;
+
+    if (!targetdc || IsRectEmpty(rect))
+        return NULL;
+
+    if (params)
+        FIXME("painting parameters are ignored\n");
+
+    buffer = heap_alloc(sizeof(*buffer));
+    buffer->targetdc = targetdc;
+    buffer->rect = *rect;
+    buffer->memorydc = CreateCompatibleDC(targetdc);
+
+    switch (format)
+    {
+    case BPBF_COMPATIBLEBITMAP:
+        buffer->bitmap = CreateCompatibleBitmap(targetdc, rect->right - rect->left, rect->bottom - rect->top);
+        buffer->bits = NULL;
+        break;
+    case BPBF_DIB:
+    case BPBF_TOPDOWNDIB:
+    case BPBF_TOPDOWNMONODIB:
+        /* create DIB section */
+        memset(bmi, 0, sizeof(bmibuf));
+        bmi->bmiHeader.biSize = sizeof(bmi->bmiHeader);
+        bmi->bmiHeader.biHeight = format == BPBF_DIB ? rect->bottom - rect->top :
+                -(rect->bottom - rect->top);
+        bmi->bmiHeader.biWidth = rect->right - rect->left;
+        bmi->bmiHeader.biBitCount = format == BPBF_TOPDOWNMONODIB ? 1 : 32;
+        bmi->bmiHeader.biPlanes = 1;
+        bmi->bmiHeader.biCompression = BI_RGB;
+        buffer->bitmap = CreateDIBSection(buffer->memorydc, bmi, DIB_RGB_COLORS, &buffer->bits, NULL, 0);
+        break;
+    default:
+        WARN("Unknown buffer format %d\n", format);
+        buffer->bitmap = NULL;
+        free_paintbuffer(buffer);
+        return NULL;
+    }
+
+    if (!buffer->bitmap)
+    {
+        WARN("Failed to create buffer bitmap\n");
+        free_paintbuffer(buffer);
+        return NULL;
+    }
+
+    SetWindowOrgEx(buffer->memorydc, rect->left, rect->top, NULL);
+    IntersectClipRect(buffer->memorydc, rect->left, rect->top, rect->right, rect->bottom);
+    DeleteObject(SelectObject(buffer->memorydc, buffer->bitmap));
+
+    *retdc = buffer->memorydc;
+
+    return (HPAINTBUFFER)buffer;
 }
 
 
 /***********************************************************************
  *      EndBufferedPaint                                   (UXTHEME.@)
  */
-HRESULT WINAPI EndBufferedPaint(HPAINTBUFFER hPaintBuffer, BOOL fUpdateTarget)
+HRESULT WINAPI EndBufferedPaint(HPAINTBUFFER bufferhandle, BOOL update)
 {
-    FIXME("Stub (%p %d)\n", hPaintBuffer, fUpdateTarget);
+    struct paintbuffer *buffer = get_buffer_obj(bufferhandle);
+
+    TRACE("(%p %d)\n", bufferhandle, update);
+
+    if (!buffer)
+        return E_INVALIDARG;
+
+    if (update)
+    {
+        if (!BitBlt(buffer->targetdc, buffer->rect.left, buffer->rect.top,
+                buffer->rect.right - buffer->rect.left, buffer->rect.bottom - buffer->rect.top,
+                buffer->memorydc, buffer->rect.left, buffer->rect.top, SRCCOPY))
+        {
+            WARN("BitBlt() failed\n");
+        }
+    }
+
+    free_paintbuffer(buffer);
     return S_OK;
 }
 
-#ifndef __REACTOS__
-
 /***********************************************************************
  *      BufferedPaintClear                                 (UXTHEME.@)
  */
@@ -91,38 +182,65 @@ HRESULT WINAPI BufferedPaintSetAlpha(HPAINTBUFFER hBufferedPaint, const RECT *pr
 /***********************************************************************
  *      GetBufferedPaintBits                               (UXTHEME.@)
  */
-HRESULT WINAPI GetBufferedPaintBits(HPAINTBUFFER hBufferedPaint, RGBQUAD **ppbBuffer,
-                                    int *pcxRow)
+HRESULT WINAPI GetBufferedPaintBits(HPAINTBUFFER bufferhandle, RGBQUAD **bits, int *width)
 {
-    FIXME("Stub (%p %p %p)\n", hBufferedPaint, ppbBuffer, pcxRow);
-    return E_NOTIMPL;
+    struct paintbuffer *buffer = get_buffer_obj(bufferhandle);
+
+    TRACE("(%p %p %p)\n", buffer, bits, width);
+
+    if (!bits || !width)
+        return E_POINTER;
+
+    if (!buffer || !buffer->bits)
+        return E_FAIL;
+
+    *bits = buffer->bits;
+    *width = buffer->rect.right - buffer->rect.left;
+
+    return S_OK;
 }
 
 /***********************************************************************
  *      GetBufferedPaintDC                                 (UXTHEME.@)
  */
-HDC WINAPI GetBufferedPaintDC(HPAINTBUFFER hBufferedPaint)
+HDC WINAPI GetBufferedPaintDC(HPAINTBUFFER bufferhandle)
 {
-    FIXME("Stub (%p)\n", hBufferedPaint);
-    return NULL;
+    struct paintbuffer *buffer = get_buffer_obj(bufferhandle);
+
+    TRACE("(%p)\n", buffer);
+
+    return buffer ? buffer->memorydc : NULL;
 }
 
 /***********************************************************************
  *      GetBufferedPaintTargetDC                           (UXTHEME.@)
  */
-HDC WINAPI GetBufferedPaintTargetDC(HPAINTBUFFER hBufferedPaint)
+HDC WINAPI GetBufferedPaintTargetDC(HPAINTBUFFER bufferhandle)
 {
-    FIXME("Stub (%p)\n", hBufferedPaint);
-    return NULL;
+    struct paintbuffer *buffer = get_buffer_obj(bufferhandle);
+
+    TRACE("(%p)\n", buffer);
+
+    return buffer ? buffer->targetdc : NULL;
 }
 
 /***********************************************************************
  *      GetBufferedPaintTargetRect                         (UXTHEME.@)
  */
-HRESULT WINAPI GetBufferedPaintTargetRect(HPAINTBUFFER hBufferedPaint, RECT *prc)
+HRESULT WINAPI GetBufferedPaintTargetRect(HPAINTBUFFER bufferhandle, RECT *rect)
 {
-    FIXME("Stub (%p %p)\n", hBufferedPaint, prc);
-    return E_NOTIMPL;
+    struct paintbuffer *buffer = get_buffer_obj(bufferhandle);
+
+    TRACE("(%p %p)\n", buffer, rect);
+
+    if (!rect)
+        return E_POINTER;
+
+    if (!buffer)
+        return E_FAIL;
+
+    *rect = buffer->rect;
+    return S_OK;
 }
 
 /***********************************************************************
@@ -168,5 +286,3 @@ HRESULT WINAPI EndBufferedAnimation(HANIMATIONBUFFER hbpAnimation, BOOL fUpdateT
 
     return E_NOTIMPL;
 }
-
-#endif /* __REACTOS__ */

dll/win32/uxtheme/metric.c

@@ -220,16 +220,38 @@ HRESULT WINAPI GetThemeSysString(HTHEME hTheme, int iStringID,
     return E_PROP_ID_UNSUPPORTED;
 }
 
-#ifndef __REACTOS__
 /***********************************************************************
  *      GetThemeTransitionDuration                          (UXTHEME.@)
  */
 HRESULT WINAPI GetThemeTransitionDuration(HTHEME hTheme, int iPartId, int iStateIdFrom,
                                           int iStateIdTo, int iPropId, DWORD *pdwDuration)
 {
-    FIXME("(%p, %u, %u, %u, %u, %p) stub\n", hTheme, iPartId, iStateIdFrom, iStateIdTo,
-          iPropId, pdwDuration);
+    INTLIST intlist;
+    HRESULT hr;
+
+    TRACE("(%p, %d, %d, %d, %d, %p)\n", hTheme, iPartId, iStateIdFrom, iStateIdTo, iPropId,
+          pdwDuration);
+
+    if (!pdwDuration || iStateIdFrom < 1 || iStateIdTo < 1)
+        return E_INVALIDARG;
+
+    hr = GetThemeIntList(hTheme, iPartId, 0, iPropId, &intlist);
+    if (FAILED(hr))
+    {
+        if (hr == E_PROP_ID_UNSUPPORTED)
+            *pdwDuration = 0;
+
+        return hr;
+    }
+
+    if (intlist.iValueCount < 1 || iStateIdFrom > intlist.iValues[0]
+        || iStateIdTo > intlist.iValues[0]
+        || intlist.iValueCount != 1 + intlist.iValues[0] * intlist.iValues[0])
+    {
+        *pdwDuration = 0;
+        return E_INVALIDARG;
+    }
 
-    return E_NOTIMPL;
+    *pdwDuration = intlist.iValues[1 + intlist.iValues[0] * (iStateIdFrom - 1) + (iStateIdTo - 1)];
+    return S_OK;
 }
-#endif

dll/win32/uxtheme/system.c

@@ -648,6 +648,37 @@ BOOL WINAPI IsThemeActive(void)
     return bActive;
 }
 
+typedef HRESULT (WINAPI* DWMISCOMPOSITIONENABLED)(BOOL *enabled);
+
+/************************************************************
+*       IsCompositionActive   (UXTHEME.@)
+*/
+BOOL WINAPI IsCompositionActive(void)
+{
+    BOOL bIsCompositionActive;
+    DWMISCOMPOSITIONENABLED pDwmIsCompositionEnabled;
+    HMODULE hdwmapi = GetModuleHandleW(L"dwmapi.dll");
+
+    if (!hdwmapi)
+    {
+        hdwmapi = LoadLibraryW(L"dwmapi.dll");
+        if (!hdwmapi)
+        {
+            ERR("Failed to load dwmapi\n");
+            return FALSE;
+        }
+
+        pDwmIsCompositionEnabled = (DWMISCOMPOSITIONENABLED)GetProcAddress(hdwmapi, "DwmIsCompositionEnabled");
+    }
+    if (!pDwmIsCompositionEnabled)
+        return FALSE;
+    
+    if (pDwmIsCompositionEnabled(&bIsCompositionActive) == S_OK)
+        return bIsCompositionActive;
+
+    return FALSE;
+}
+
 /***********************************************************************
  *      EnableTheming                                       (UXTHEME.@)
  *
@@ -847,9 +878,23 @@ HTHEME WINAPI OpenThemeDataFromFile(HTHEMEFILE hThemeFile, HWND hwnd, LPCWSTR ps
 /***********************************************************************
  *      OpenThemeData                                       (UXTHEME.@)
  */
-HTHEME WINAPI OpenThemeData(HWND hwnd, LPCWSTR classlist)
+HTHEME WINAPI OpenThemeData(HWND hwnd, LPCWSTR pszClassList)
+{
+    return OpenThemeDataInternal(g_ActiveThemeFile, hwnd, pszClassList, 0);
+}
+
+/***********************************************************************
+ *      OpenThemeDataForDpi                                 (UXTHEME.@)
+ */
+HTHEME
+WINAPI
+OpenThemeDataForDpi(
+    _In_ HWND hwnd,
+    _In_ LPCWSTR pszClassList,
+    _In_ UINT dpi)
 {
-    return OpenThemeDataInternal(g_ActiveThemeFile, hwnd, classlist, 0);
+    FIXME("dpi (%x) is currently ignored", dpi);
+    return OpenThemeDataInternal(g_ActiveThemeFile, hwnd, pszClassList, 0);
 }
 
 /***********************************************************************
@@ -903,6 +948,23 @@ HRESULT WINAPI SetWindowTheme(HWND hwnd, LPCWSTR pszSubAppName,
     return hr;
 }
 
+#if (DLL_EXPORT_VERSION >= _WIN32_WINNT_VISTA)
+/***********************************************************************
+ *      SetWindowThemeAttribute                             (UXTHEME.@)
+ */
+HRESULT
+WINAPI
+SetWindowThemeAttribute(
+    _In_ HWND hwnd,
+    _In_ enum WINDOWTHEMEATTRIBUTETYPE eAttribute,
+    _In_ PVOID pvAttribute,
+    _In_ DWORD cbAttribute)
+{
+   FIXME("(%p,%d,%p,%ld): stub\n", hwnd, eAttribute, pvAttribute, cbAttribute);
+   return E_NOTIMPL;
+}
+#endif /* (DLL_EXPORT_VERSION >= _WIN32_WINNT_VISTA) */
+
 /***********************************************************************
  *      GetCurrentThemeName                                 (UXTHEME.@)
  */