Merge pull request #52 from vtex/feature/remove_threshold

Feature/remove threshold

Author: Caldas

src/SampleWebAPI/appsettings.Development.json

@@ -2,15 +2,15 @@
   "Logging": {
     "IncludeScopes": false,
     "LogLevel": {
-      "Default": "Debug",
-      "System": "Information",
-      "Microsoft": "Information",
+      "Default": "Trace",
+      "System": "Debug",
+      "Microsoft": "Debug",
       "Splunk": "Trace"
     }
   },
   "Splunk": {
     "HecConfiguration": {
-      "BatchIntervalInMiliseconds": 5000,
+      "BatchIntervalInMilliseconds": 5000,
       "BatchSizeCount": 10,
       "ChannelIdType": "None",
       "DefaultTimeoutInMiliseconds": 10000,
@@ -21,7 +21,6 @@
     "SocketConfiguration": {
       "HostName": "localhost",
       "Port": 4242
-    },
-    "Threshold": "Trace"
+    }
   }
 }

src/SampleWebAPI/appsettings.json

@@ -1,20 +1,16 @@
 {
   "Logging": {
     "IncludeScopes": false,
-    "Debug": {
-      "LogLevel": {
-        "Default": "Warning"
-      }
-    },
-    "Console": {
-      "LogLevel": {
-        "Default": "Warning",
-        "Splunk": "Trace"
-      }
-    },
+    "LogLevel": {
+      "Default": "Information",
+      "System": "Warning",
+      "Microsoft": "Warning",
+      "Splunk": "Trace"
+    }
+  },
     "Splunk": {
       "HecConfiguration": {
-        "BatchIntervalInMiliseconds": 5000,
+        "BatchIntervalInMilliseconds": 5000,
         "BatchSizeCount": 10,
         "ChannelIdType": "None",
         "DefaultTimeoutInMiliseconds":  10000,
@@ -25,8 +21,7 @@
       "SocketConfiguration": {
         "HostName": "localhost",
         "Port": 4242
-      },
-      "Threshold": "Trace"
+      }
     }
   }
 }

src/SplunkLogger/BatchManager.cs

@@ -18,7 +18,7 @@ public class BatchManager
     {
         readonly ConcurrentBag<object> events;
         readonly uint batchSizeCount;
-        readonly uint batchIntervalInMiliseconds;
+        readonly uint batchIntervalInMilliseconds;
         readonly Timer timer;
         readonly Action<List<object>> emitAction;
 
@@ -29,17 +29,17 @@ public class BatchManager
         /// Initializes a new instance of the <see cref="T:Splunk.BatchManager"/> class.
         /// </summary>
         /// <param name="batchSizeCount">Batch size count.</param>
-        /// <param name="batchIntervalInMiliseconds">Batch interval in miliseconds.</param>
+        /// <param name="batchIntervalInMilliseconds">Batch interval in milliseconds.</param>
         /// <param name="emitAction">Emit action to be invoked at Emit process.</param>
-        public BatchManager(uint batchSizeCount, uint batchIntervalInMiliseconds, Action<List<object>> emitAction)
+        public BatchManager(uint batchSizeCount, uint batchIntervalInMilliseconds, Action<List<object>> emitAction)
         {
             events = new ConcurrentBag<object>();
             this.batchSizeCount = batchSizeCount;
-            this.batchIntervalInMiliseconds = batchIntervalInMiliseconds;
+            this.batchIntervalInMilliseconds = batchIntervalInMilliseconds;
 
-            if (batchIntervalInMiliseconds > 0)
+            if (batchIntervalInMilliseconds > 0)
             {
-                timer = new Timer(batchIntervalInMiliseconds);
+                timer = new Timer(batchIntervalInMilliseconds);
                 timer.AutoReset = false;
                 timer.Enabled = true;
                 timer.Elapsed += TimerTick;

src/SplunkLogger/Configurations/SplunkLoggerConfiguration.cs

@@ -1,5 +1,4 @@
-using Microsoft.Extensions.Logging;
-
+
 namespace Splunk.Configurations
 {
     /// <summary>
@@ -16,10 +15,5 @@ public class SplunkLoggerConfiguration
         /// Gets or sets the socket configuration.
         /// </summary>
         public SocketConfiguration SocketConfiguration { get; set; }
-
-        /// <summary>
-        /// Gets or sets the threshold.
-        /// </summary>
-        public LogLevel Threshold { get; set; }
     }
 }

src/SplunkLogger/Loggers/BaseLogger.cs

@@ -11,18 +11,15 @@ public abstract class BaseLogger : ILogger
         protected readonly ILoggerFormatter loggerFormatter;
 
         readonly string categoryName;
-        readonly LogLevel threshold;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="T:Splunk.Loggers.BaseLogger"/> class.
         /// </summary>
         /// <param name="categoryName">Category name.</param>
-        /// <param name="threshold">Threshold.</param>
         /// <param name="loggerFormatter">Formatter instance.</param>
-        public BaseLogger(string categoryName, LogLevel threshold, ILoggerFormatter loggerFormatter)
+        public BaseLogger(string categoryName, ILoggerFormatter loggerFormatter)
         {
             this.categoryName = categoryName;
-            this.threshold = threshold;
             this.loggerFormatter = loggerFormatter;
         }
 
@@ -33,7 +30,7 @@ public BaseLogger(string categoryName, LogLevel threshold, ILoggerFormatter logg
         /// <param name="logLevel">.Net Core Log level.</param>
         public bool IsEnabled(LogLevel logLevel)
         {
-            return (int)logLevel >= (int)threshold;
+            return true;
         }
 
         /// <summary>

src/SplunkLogger/Loggers/HECBaseLogger.cs

@@ -16,12 +16,11 @@ public abstract class HECBaseLogger : BaseLogger
         /// Initializes a new instance of the <see cref="T:Splunk.Loggers.HECBaseLogger"/> class.
         /// </summary>
         /// <param name="categoryName">Category name.</param>
-        /// <param name="threshold">Threshold.</param>
         /// <param name="httpClient">Http client.</param>
         /// <param name="batchManager">Batch manager.</param>
         /// <param name="loggerFormatter">Formatter instance.</param>
-        public HECBaseLogger(string categoryName, LogLevel threshold, HttpClient httpClient, BatchManager batchManager, ILoggerFormatter loggerFormatter)
-            : base(categoryName, threshold, loggerFormatter)
+        public HECBaseLogger(string categoryName, HttpClient httpClient, BatchManager batchManager, ILoggerFormatter loggerFormatter)
+            : base(categoryName, loggerFormatter)
         {
             this.httpClient = httpClient;
             this.batchManager = batchManager;

src/SplunkLogger/Loggers/HECJsonLogger.cs

@@ -14,12 +14,11 @@ public class HECJsonLogger : HECBaseLogger, ILogger
         /// Initializes a new instance of the <see cref="T:Splunk.Loggers.HECJsonLogger"/> class.
         /// </summary>
         /// <param name="categoryName">Category name.</param>
-        /// <param name="threshold">Threshold.</param>
         /// <param name="httpClient">Http client.</param>
         /// <param name="batchManager">Batch manager.</param>
         /// <param name="loggerFormatter">Formatter instance.</param>
-        public HECJsonLogger(string categoryName, LogLevel threshold, HttpClient httpClient, BatchManager batchManager, ILoggerFormatter loggerFormatter)
-            : base(categoryName, threshold, httpClient, batchManager, loggerFormatter)
+        public HECJsonLogger(string categoryName, HttpClient httpClient, BatchManager batchManager, ILoggerFormatter loggerFormatter)
+            : base(categoryName, httpClient, batchManager, loggerFormatter)
         {
         }
 

src/SplunkLogger/Loggers/HECRawLogger.cs

@@ -13,12 +13,11 @@ public class HECRawLogger : HECBaseLogger, ILogger
         /// Initializes a new instance of the <see cref="T:Splunk.Loggers.HECRawLogger"/> class.
         /// </summary>
         /// <param name="categoryName">Category name.</param>
-        /// <param name="threshold">Threshold.</param>
         /// <param name="httpClient">Http client.</param>
         /// <param name="batchManager">Batch manager.</param>
         /// <param name="loggerFormatter">Formatter instance.</param>
-        public HECRawLogger(string categoryName, LogLevel threshold, HttpClient httpClient, BatchManager batchManager, ILoggerFormatter loggerFormatter)
-            : base(categoryName, threshold, httpClient, batchManager, loggerFormatter)
+        public HECRawLogger(string categoryName, HttpClient httpClient, BatchManager batchManager, ILoggerFormatter loggerFormatter)
+            : base(categoryName, httpClient, batchManager, loggerFormatter)
         {
         }
 

src/SplunkLogger/Loggers/TcpLogger.cs

@@ -16,11 +16,10 @@ public class TcpLogger : BaseLogger, ILogger
         /// Initializes a new instance of the <see cref="T:Splunk.Loggers.TcpLogger"/> class.
         /// </summary>
         /// <param name="categoryName">Category name.</param>
-        /// <param name="threshold">Threshold.</param>
         /// <param name="tcpClient">Tcp client.</param>
         /// <param name="loggerFormatter">Formatter instance.</param>
-        public TcpLogger(string categoryName, LogLevel threshold, TcpClient tcpClient, ILoggerFormatter loggerFormatter)
-            : base(categoryName, threshold, loggerFormatter)
+        public TcpLogger(string categoryName, TcpClient tcpClient, ILoggerFormatter loggerFormatter)
+            : base(categoryName, loggerFormatter)
         {
             this.tcpClient = tcpClient;
         }

src/SplunkLogger/Loggers/UdpLogger.cs

@@ -16,11 +16,10 @@ public class UdpLogger : BaseLogger, ILogger
         /// Initializes a new instance of the <see cref="T:Splunk.Loggers.UdpLogger"/> class.
         /// </summary>
         /// <param name="categoryName">Category name.</param>
-        /// <param name="threshold">Threshold.</param>
         /// <param name="udpClient">UDP client.</param>
         /// <param name="loggerFormatter">Formatter instance.</param>
-        public UdpLogger(string categoryName, LogLevel threshold, UdpClient udpClient, ILoggerFormatter loggerFormatter)
-            : base(categoryName, threshold, loggerFormatter)
+        public UdpLogger(string categoryName, UdpClient udpClient, ILoggerFormatter loggerFormatter)
+            : base(categoryName, loggerFormatter)
         {
             this.udpClient = udpClient;
         }