Created base HEC provider to simplify http instance setup for JSON and HEC providers

#37

Author: Caldas

src/SplunkLogger/Providers/SplunkHECBaseProvider.cs

@@ -0,0 +1,68 @@
+using System;
+using System.Net.Http;
+using System.Net.Http.Headers;
+using Microsoft.Extensions.Logging;
+using Splunk.Configurations;
+
+namespace Splunk.Providers
+{
+    /// <summary>
+    /// Splunk HECB ase provider.
+    /// </summary>
+    public abstract class SplunkHECBaseProvider : ILoggerProvider
+    {
+        protected HttpClient httpClient;
+
+        /// <summary>
+        /// Get a <see cref="T:Splunk.Loggers.HECJsonLogger"/> instance to the category name provided.
+        /// </summary>
+        /// <returns><see cref="T:Splunk.Loggers.HECJsonLogger"/> instance.</returns>
+        /// <param name="categoryName">Category name.</param>
+        public abstract ILogger CreateLogger(string categoryName);
+
+        /// <summary>
+        /// Releases all resource used by the <see cref="T:Splunk.Providers.SplunkHECJsonLoggerProvider"/> object.
+        /// </summary>
+        /// <remarks>Call <see cref="Dispose"/> when you are finished using the
+        /// <see cref="T:Splunk.Providers.SplunkHECJsonLoggerProvider"/>. The <see cref="Dispose"/> method leaves the
+        /// <see cref="T:Splunk.Providers.SplunkHECJsonLoggerProvider"/> in an unusable state. After calling
+        /// <see cref="Dispose"/>, you must release all references to the
+        /// <see cref="T:Splunk.Providers.SplunkHECJsonLoggerProvider"/> so the garbage collector can reclaim the memory
+        /// that the <see cref="T:Splunk.Providers.SplunkHECJsonLoggerProvider"/> was occupying.</remarks>
+        public abstract void Dispose();
+
+        /// <summary>
+        /// Create a <see cref="T:Splunk.Loggers.HECJsonLogger"/> instance to the category name provided.
+        /// </summary>
+        /// <returns>The logger instance.</returns>
+        /// <param name="categoryName">Category name.</param>
+        public abstract ILogger CreateLoggerInstance(string categoryName);
+
+        protected void SetupHttpClient(SplunkLoggerConfiguration configuration, string endPointCustomization)
+        {
+            httpClient = new HttpClient
+            {
+                BaseAddress = GetSplunkCollectorUrl(configuration, endPointCustomization),
+                Timeout = TimeSpan.FromMilliseconds(configuration.HecConfiguration.DefaultTimeoutInMiliseconds)
+            };
+            httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Splunk", configuration.HecConfiguration.Token);
+            if (configuration.HecConfiguration.ChannelIdType == HECConfiguration.ChannelIdOption.RequestHeader)
+                httpClient.DefaultRequestHeaders.Add("x-splunk-request-channel", Guid.NewGuid().ToString());
+        }
+
+        Uri GetSplunkCollectorUrl(SplunkLoggerConfiguration configuration, string endPointCustomization)
+        {
+            var splunkCollectorUrl = configuration.HecConfiguration.SplunkCollectorUrl;
+            if (!splunkCollectorUrl.EndsWith("/", StringComparison.InvariantCulture))
+                splunkCollectorUrl = splunkCollectorUrl + "/";
+
+            if(!string.IsNullOrWhiteSpace(endPointCustomization))
+                splunkCollectorUrl = splunkCollectorUrl + endPointCustomization;
+
+            if (configuration.HecConfiguration.ChannelIdType == HECConfiguration.ChannelIdOption.QueryString)
+                splunkCollectorUrl = splunkCollectorUrl + "?channel=" + Guid.NewGuid().ToString();
+
+            return new Uri(splunkCollectorUrl);
+        }
+    }
+}

src/SplunkLogger/Providers/SplunkHECJsonLoggerProvider.cs

@@ -16,10 +16,9 @@ namespace Splunk.Providers
     /// <summary>
     /// This class is used to provide a Splunk HEC Json logger for each categoryName.
     /// </summary>
-    public class SplunkHECJsonLoggerProvider : ILoggerProvider
+    public class SplunkHECJsonLoggerProvider : SplunkHECBaseProvider, ILoggerProvider
     {
         readonly BatchManager batchController;
-        readonly HttpClient httpClient;
         readonly LogLevel threshold;
         readonly ILoggerFormatter loggerFormatter;
         readonly ConcurrentDictionary<string, ILogger> loggers;
@@ -37,34 +36,17 @@ public SplunkHECJsonLoggerProvider(SplunkLoggerConfiguration configuration, ILog
 
             this.loggerFormatter = loggerFormatter;
 
-            httpClient = new HttpClient();
-
-            var splunkCollectorUrl = configuration.HecConfiguration.SplunkCollectorUrl;
-            if (!splunkCollectorUrl.EndsWith("/", StringComparison.InvariantCulture))
-                splunkCollectorUrl += "/";
-
-            var baseAddress = new Uri(splunkCollectorUrl + "event");
-            httpClient.BaseAddress = baseAddress;
-
-            httpClient.Timeout = TimeSpan.FromMilliseconds(configuration.HecConfiguration.DefaultTimeoutInMiliseconds);
-            httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Splunk", configuration.HecConfiguration.Token);
-            if (configuration.HecConfiguration.ChannelIdType == HECConfiguration.ChannelIdOption.RequestHeader)
-                httpClient.DefaultRequestHeaders.Add("x-splunk-request-channel", Guid.NewGuid().ToString());
+            SetupHttpClient(configuration, "event");
 
             batchController = new BatchManager(configuration.HecConfiguration.BatchSizeCount, configuration.HecConfiguration.BatchIntervalInMiliseconds, Emit);
         }
 
-        ILogger CreateLoggerInstance(string categoryName)
-        {
-            return new HECJsonLogger(categoryName, threshold, httpClient, batchController, loggerFormatter);
-        }
-
         /// <summary>
-        /// Create a <see cref="T:Splunk.Loggers.HECJsonLogger"/> instance to the category name provided.
+        /// Get a <see cref="T:Splunk.Loggers.HECJsonLogger"/> instance to the category name provided.
         /// </summary>
         /// <returns><see cref="T:Splunk.Loggers.HECJsonLogger"/> instance.</returns>
         /// <param name="categoryName">Category name.</param>
-        public ILogger CreateLogger(string categoryName)
+        public override ILogger CreateLogger(string categoryName)
         {
             return loggers.GetOrAdd(categoryName, CreateLoggerInstance(categoryName));
         }
@@ -78,11 +60,21 @@ public ILogger CreateLogger(string categoryName)
         /// <see cref="Dispose"/>, you must release all references to the
         /// <see cref="T:Splunk.Providers.SplunkHECJsonLoggerProvider"/> so the garbage collector can reclaim the memory
         /// that the <see cref="T:Splunk.Providers.SplunkHECJsonLoggerProvider"/> was occupying.</remarks>
-        public void Dispose()
+        public override void Dispose()
         {
             loggers.Clear();
         }
 
+        /// <summary>
+        /// Create a <see cref="T:Splunk.Loggers.HECJsonLogger"/> instance to the category name provided.
+        /// </summary>
+        /// <returns>The logger instance.</returns>
+        /// <param name="categoryName">Category name.</param>
+        public override ILogger CreateLoggerInstance(string categoryName)
+        {
+            return new HECJsonLogger(categoryName, threshold, httpClient, batchController, loggerFormatter);
+        }
+
         /// <summary>
         /// Method used to emit batched events.
         /// </summary>

src/SplunkLogger/Providers/SplunkHECRawLoggerProvider.cs

@@ -4,7 +4,6 @@
 using System.Diagnostics;
 using System.Linq;
 using System.Net.Http;
-using System.Net.Http.Headers;
 using Microsoft.Extensions.Logging;
 using Splunk.Configurations;
 using Splunk.Loggers;
@@ -14,10 +13,9 @@ namespace Splunk.Providers
     /// <summary>
     /// This class is used to provide a Splunk HEC Raw logger for each categoryName.
     /// </summary>
-    public class SplunkHECRawLoggerProvider : ILoggerProvider
+    public class SplunkHECRawLoggerProvider : SplunkHECBaseProvider, ILoggerProvider
     {
         readonly BatchManager batchManager;
-        readonly HttpClient httpClient;
         readonly LogLevel threshold;
         readonly ILoggerFormatter loggerFormatter;
         readonly ConcurrentDictionary<string, ILogger> loggers;
@@ -35,38 +33,17 @@ public SplunkHECRawLoggerProvider(SplunkLoggerConfiguration configuration, ILogg
 
             this.loggerFormatter = loggerFormatter;
 
-            httpClient = new HttpClient();
-
-            var splunkCollectorUrl = configuration.HecConfiguration.SplunkCollectorUrl;
-            if (!splunkCollectorUrl.EndsWith("/", StringComparison.InvariantCulture))
-                splunkCollectorUrl += "/";
-            
-            if(configuration.HecConfiguration.ChannelIdType == HECConfiguration.ChannelIdOption.QueryString)
-                splunkCollectorUrl = splunkCollectorUrl + "raw?channel=" + Guid.NewGuid().ToString();
-            
-            httpClient.BaseAddress = new Uri(splunkCollectorUrl);
-
-            httpClient.Timeout = TimeSpan.FromMilliseconds(configuration.HecConfiguration.DefaultTimeoutInMiliseconds);
-
-            if(!configuration.HecConfiguration.UseTokenAsQueryString)
-                httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Splunk", configuration.HecConfiguration.Token);
-            if (configuration.HecConfiguration.ChannelIdType == HECConfiguration.ChannelIdOption.RequestHeader)
-                httpClient.DefaultRequestHeaders.Add("x-splunk-request-channel", Guid.NewGuid().ToString());
+            SetupHttpClient(configuration, "raw");
 
             batchManager = new BatchManager(configuration.HecConfiguration.BatchSizeCount, configuration.HecConfiguration.BatchIntervalInMiliseconds, Emit);
         }
 
-        ILogger CreateLoggerInstance(string categoryName)
-        {
-            return new HECRawLogger(categoryName, threshold, httpClient, batchManager, loggerFormatter);
-        }
-
         /// <summary>
         /// Create a <see cref="T:Splunk.Loggers.HECRawLogger"/> instance to the category name provided.
         /// </summary>
         /// <returns><see cref="T:Splunk.Loggers.HECRawLogger"/> instance.</returns>
         /// <param name="categoryName">Category name.</param>
-        public ILogger CreateLogger(string categoryName)
+        public override ILogger CreateLogger(string categoryName)
         {
             return loggers.GetOrAdd(categoryName, CreateLoggerInstance(categoryName));
         }
@@ -80,11 +57,21 @@ public ILogger CreateLogger(string categoryName)
         /// <see cref="Dispose"/>, you must release all references to the
         /// <see cref="T:Splunk.Providers.SplunkHECRawLoggerProvider"/> so the garbage collector can reclaim the memory
         /// that the <see cref="T:Splunk.Providers.SplunkHECRawLoggerProvider"/> was occupying.</remarks>
-        public void Dispose()
+        public override void Dispose()
         {
             loggers.Clear();
         }
 
+        /// <summary>
+        /// Create a <see cref="T:Splunk.Loggers.HECRawLogger"/> instance to the category name provided.
+        /// </summary>
+        /// <returns><see cref="T:Splunk.Loggers.HECRawLogger"/> instance.</returns>
+        /// <param name="categoryName">Category name.</param>
+        public override ILogger CreateLoggerInstance(string categoryName)
+        {
+            return new HECRawLogger(categoryName, threshold, httpClient, batchManager, loggerFormatter);
+        }
+
         /// <summary>
         /// Method used to emit batched events.
         /// </summary>