Do not report every missing column definiton

Better unit tests

Author: Vitexus

src/AbraFlexi/RO.php

@@ -1037,7 +1037,9 @@ public function fixRecordTypes(array $record, $evidence = null) {
             if ($column && !strstr($column, '@')) {
                 $columnInfo = $this->getColumnInfo($column, $evidence);
                 if (is_null($columnInfo)) {
-                    $this->addStatusMessage(sprintf(_('Unknown response field %s. (Please update library or static definitions)'), $column . '@' . $evidence), 'debug');
+                    if ($this->debug === true) {
+                        $this->addStatusMessage(sprintf(_('Unknown response field %s. (Please update library or static definitions)'), $column . '@' . $evidence), 'debug');
+                    }
                 } else {
                     switch ($columnInfo['type']) {
                         case 'logic':
@@ -1665,7 +1667,7 @@ public function idExists($identifer = null) {
         }
         $ignorestate = $this->ignore404();
         $this->ignore404(true);
-        $cands = $this->getFlexiData(null,
+        $cands = $this->getFlexiData('',
                 [
                     'detail' => 'custom:' . $this->getKeyColumn(),
                     $this->getKeyColumn() => $identifer
@@ -2130,7 +2132,7 @@ public function getExternalIDs() {
      * @return int
      */
     public function getGlobalVersion() {
-        $this->getFlexiData(null, ['add-global-version' => 'true', 'limit' => 1]);
+        $this->getFlexiData('', ['add-global-version' => 'true', 'limit' => 1]);
 
         return $this->globalVersion;
     }

testing/src/AbraFlexi/FakturaVydanaTest.php

@@ -190,7 +190,7 @@ public function makeInvoice($invoiceData = []) {
         if (!isset($invoiceData['firma'])) {
             $adresar = new \AbraFlexi\Adresar();
 
-            $adresy = $adresar->getFlexiData(null,
+            $adresy = $adresar->getFlexiData('',
                     ['typVztahuK' => 'typVztahu.odberatel']);
             if (count($adresy)) {
                 $dodavatel = $adresy[array_rand($adresy)];

testing/src/AbraFlexi/NastaveniTest.php

@@ -40,7 +40,7 @@ public function testGetFlexiData() {
             $flexidata = $this->object->getFlexiData();
             $this->assertArrayHasKey(0, $flexidata);
             $this->assertArrayHasKey('id', $flexidata[0]);
-            $filtrered = $this->object->getFlexiData(null,
+            $filtrered = $this->object->getFlexiData('',
                     key($flexidata[0]) . " = " . current($flexidata[0]));
             $this->assertArrayHasKey(0, $filtrered);
             $this->assertArrayHasKey('id', $filtrered[0]);

testing/src/AbraFlexi/ROTest.php

@@ -535,13 +535,13 @@ public function testGetFlexiData() {
                 $this->assertArrayHasKey('company', $flexidata);
                 break;
             case 'evidence-list':
-                $flexidata = $this->object->getFlexiData(null,
+                $flexidata = $this->object->getFlexiData('',
                         ['detail' => 'id']);
                 $this->assertArrayHasKey('evidenceType', $flexidata[0]);
                 break;
 
             default:
-                $flexidata = $this->object->getFlexiData(null,
+                $flexidata = $this->object->getFlexiData('',
                         ['detail' => 'id']);
 
                 if (is_array($flexidata)) {
@@ -551,7 +551,7 @@ public function testGetFlexiData() {
                         $this->assertArrayHasKey(0, $flexidata);
 
                         $this->assertArrayHasKey('id', $flexidata[0]);
-                        $filtrered = $this->object->getFlexiData(null,
+                        $filtrered = $this->object->getFlexiData('',
                                 ["id = " . $flexidata[0]['id'], 'detail' => 'full']);
                         $this->assertArrayHasKey(0, $filtrered);
                         $this->assertArrayHasKey('id', $filtrered[0]);
@@ -672,7 +672,7 @@ public function testRecordExists() {
                 break;
 
             default:
-                $flexidata = $this->object->getFlexiData(null,
+                $flexidata = $this->object->getFlexiData('',
                         ['limit' => 1, 'detail' => 'id']);
                 if (is_array($flexidata) && !count($flexidata)) {
                     $this->assertFalse($this->object->recordExists(['id' => 1]),
@@ -744,8 +744,7 @@ public function testGetGlobalVersion() {
                 $this->object->getGlobalVersion();
                 break;
             default:
-                $this->assertInternalType("int",
-                        $this->object->getGlobalVersion(),
+                $this->assertTrue(is_int($this->object->getGlobalVersion()),
                         'error obtaining of GlobalVersion');
                 break;
         }