Fix 'silent' error when logging in. Finalises fix for #2142

Author: dualspiral

src/main/java/org/spongepowered/common/event/SpongeCommonEventFactory.java

@@ -292,11 +292,19 @@ public static void callDropItemDestruct(final List<Entity> entities, final Phase
     }
 
     public static boolean callSpawnEntity(final List<Entity> entities, final PhaseContext<?> context) {
+        return SpongeCommonEventFactory.callSpawnEntity(entities, context, true);
+    }
+
+    public static boolean callSpawnEntity(final List<Entity> entities, final PhaseContext<?> context, final boolean forPlayer) {
         Sponge.getCauseStackManager().getCurrentContext().require(EventContextKeys.SPAWN_TYPE);
         try {
             final SpawnEntityEvent event = SpongeEventFactory.createSpawnEntityEvent(Sponge.getCauseStackManager().getCurrentCause(), entities);
             SpongeImpl.postEvent(event);
             if (!event.isCancelled()) {
+                if (forPlayer) {
+                    // No processing should occur here, we're done as far as this event is concerned.
+                    return true;
+                }
                 for (Entity entity : event.getEntities()) {
                     if (entity instanceof Projectile) {
                         LaunchProjectileEvent launchProjectileEvent =

src/main/java/org/spongepowered/common/event/tracking/PhaseTracker.java

@@ -1049,7 +1049,7 @@ public boolean spawnEntity(final WorldServer world, final net.minecraft.entity.E
             world.updateAllPlayersSleepingFlag();
             try (final CauseStackManager.StackFrame frame = Sponge.getCauseStackManager().pushCauseFrame()) {
                 frame.addContext(EventContextKeys.SPAWN_TYPE, SpawnTypes.PLACEMENT);
-                SpongeCommonEventFactory.callSpawnEntity(Collections.singletonList((Player) entityplayer), context);
+                SpongeCommonEventFactory.callSpawnEntity(Collections.singletonList((Player) entityplayer), context, true);
                 SpongeImplHooks.firePlayerJoinSpawnEvent((EntityPlayerMP) entityplayer);
             }
         } else {