Merge remote-tracking branch 'origin/api-13' into api-14

Author: aromaa

src/main/java/org/spongepowered/api/data/CollectionDataProvider.java

@@ -0,0 +1,36 @@
+/*
+ * This file is part of SpongeAPI, licensed under the MIT License (MIT).
+ *
+ * Copyright (c) SpongePowered <https://www.spongepowered.org>
+ * Copyright (c) contributors
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+package org.spongepowered.api.data;
+
+import org.spongepowered.api.data.value.CollectionValue;
+
+import java.util.Collection;
+
+public interface CollectionDataProvider<E, V extends Collection<E>, C extends CollectionValue<E, V>> extends DataProvider<C, V> {
+
+    DataTransactionResult offerSingle(DataHolder.Mutable dataHolder, E element);
+
+    DataTransactionResult removeSingle(DataHolder.Mutable dataHolder, E element);
+}

src/main/java/org/spongepowered/api/entity/living/player/User.java

@@ -25,6 +25,7 @@
 package org.spongepowered.api.entity.living.player;
 
 import org.spongepowered.api.ResourceKey;
+import org.spongepowered.api.Server;
 import org.spongepowered.api.block.entity.EnderChest;
 import org.spongepowered.api.data.DataHolder;
 import org.spongepowered.api.data.Keys;
@@ -203,4 +204,13 @@ default Value.Mutable<VanishState> vanishState() {
         return this.requireValue(Keys.VANISH_STATE).asMutable();
     }
 
+    /**
+     * Gets if the {@link User} has played on the {@link Server} before. Added
+     * as a utility.
+     *
+     * @return True if played before, false otherwise
+     */
+    default boolean hasPlayedBefore() {
+        return !this.firstJoined().map(Value::get).equals(this.lastJoined().map(Value::get));
+    }
 }

src/main/java/org/spongepowered/api/entity/living/player/server/ServerPlayer.java

@@ -299,7 +299,7 @@ default Value.Mutable<Boolean> hasViewedCredits() {
      * @return True if played before, false otherwise
      */
     default boolean hasPlayedBefore() {
-        return !this.firstJoined().equals(this.lastPlayed());
+        return !this.firstJoined().map(Value::get).equals(this.lastJoined().map(Value::get));
     }
 
     /**