replace: createStack() -> asMutable() & createSnapshot() -> asImmutable()

Author: MrHell228

src/main/java/org/spongepowered/api/advancement/DisplayInfo.java

@@ -171,7 +171,7 @@ default Builder icon(ItemType itemType) {
          * @return This builder, for chaining
          */
         default Builder icon(ItemStack itemStack) {
-            return this.icon(itemStack.createSnapshot());
+            return this.icon(itemStack.asImmutable());
         }
 
         /**

src/main/java/org/spongepowered/api/event/cause/entity/damage/DamageModifier.java

@@ -163,7 +163,7 @@ public Builder group(final String group) {
         }
 
         public Builder item(final ItemStack itemStack) {
-            this.item(java.util.Objects.requireNonNull(itemStack, "ItemStack").createSnapshot());
+            this.item(java.util.Objects.requireNonNull(itemStack, "ItemStack").asImmutable());
             return this;
         }
 

src/main/java/org/spongepowered/api/event/item/inventory/AffectItemStackEvent.java

@@ -67,7 +67,7 @@ public interface AffectItemStackEvent extends Event, Cancellable {
      */
     default List<? extends  Transaction<ItemStackSnapshot>> filter(Predicate<ItemStack> predicate) {
         final List<Transaction<ItemStackSnapshot>> invalidatedTransactions = new ArrayList<>();
-        this.transactions().stream().filter(transaction -> !predicate.test(transaction.finalReplacement().createStack())).forEach(transaction -> {
+        this.transactions().stream().filter(transaction -> !predicate.test(transaction.finalReplacement().asMutable())).forEach(transaction -> {
             transaction.setValid(false);
             invalidatedTransactions.add(transaction);
         });

src/main/java/org/spongepowered/api/event/item/inventory/AffectSlotEvent.java

@@ -40,7 +40,7 @@ public interface AffectSlotEvent extends AffectItemStackEvent {
     @Override
     default List<SlotTransaction> filter(Predicate<ItemStack> predicate) {
         final List<SlotTransaction> invalidatedTransactions = new ArrayList<>();
-        this.transactions().stream().filter(transaction -> !predicate.test(transaction.finalReplacement().createStack())).forEach(transaction -> {
+        this.transactions().stream().filter(transaction -> !predicate.test(transaction.finalReplacement().asMutable())).forEach(transaction -> {
             transaction.setValid(false);
             invalidatedTransactions.add(transaction);
         });

src/main/java/org/spongepowered/api/item/inventory/transaction/SlotTransaction.java

@@ -57,7 +57,7 @@ public SlotTransaction(Slot slot, ItemStackSnapshot original, ItemStackSnapshot
      * @param stack The stack
      */
     public void setCustom(ItemStack stack) {
-        this.setCustom(Objects.requireNonNull(stack, "ItemStack was null").createSnapshot());
+        this.setCustom(Objects.requireNonNull(stack, "ItemStack was null").asImmutable());
     }
 
     /**