Skip to content

Commit 47299e1

Browse files
committed
Migrate different stuff
1 parent e2d8085 commit 47299e1

File tree

3 files changed

+40
-13
lines changed

3 files changed

+40
-13
lines changed

src/main/java/org/spongepowered/api/advancement/DisplayInfo.java

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.spongepowered.api.Sponge;
2929
import org.spongepowered.api.item.ItemType;
3030
import org.spongepowered.api.item.inventory.ItemStack;
31+
import org.spongepowered.api.item.inventory.ItemStackLike;
3132
import org.spongepowered.api.item.inventory.ItemStackSnapshot;
3233
import org.spongepowered.api.util.CopyableBuilder;
3334

@@ -164,24 +165,29 @@ default Builder icon(ItemType itemType) {
164165
}
165166

166167
/**
167-
* Sets the icon of the advancement with the
168-
* specified {@link ItemStack}.
169-
*
170-
* @param itemStack The item stack
171-
* @return This builder, for chaining
168+
* @deprecated Use {@link #icon(ItemStackLike)} instead.
172169
*/
170+
@Deprecated(forRemoval = true)
173171
default Builder icon(ItemStack itemStack) {
174-
return this.icon(itemStack.asImmutable());
172+
return this.icon((ItemStackLike) itemStack);
173+
}
174+
175+
/**
176+
* @deprecated Use {@link #icon(ItemStackLike)} instead.
177+
*/
178+
@Deprecated(forRemoval = true)
179+
default Builder icon(ItemStackSnapshot itemStackSnapshot) {
180+
return this.icon((ItemStackLike) itemStackSnapshot);
175181
}
176182

177183
/**
178184
* Sets the icon of the advancement with the
179-
* specified {@link ItemStackSnapshot}.
185+
* specified {@link ItemStackLike}.
180186
*
181-
* @param itemStackSnapshot The item stack snapshot
187+
* @param itemStack The item stack snapshot
182188
* @return This builder, for chaining
183189
*/
184-
Builder icon(ItemStackSnapshot itemStackSnapshot);
190+
Builder icon(ItemStackLike itemStack);
185191

186192
/**
187193
* Sets whether a toast should be shown. This is the notification

src/main/java/org/spongepowered/api/block/entity/Jukebox.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.spongepowered.api.data.Keys;
2828
import org.spongepowered.api.data.value.Value;
2929
import org.spongepowered.api.item.inventory.ItemStack;
30+
import org.spongepowered.api.item.inventory.ItemStackLike;
3031
import org.spongepowered.api.item.inventory.ItemStackSnapshot;
3132

3233
/**
@@ -59,10 +60,18 @@ default Value.Mutable<ItemStackSnapshot> item() {
5960
*/
6061
void eject();
6162

63+
/**
64+
* @deprecated Use {@link #insert(ItemStackLike)} instead.
65+
*/
66+
@Deprecated(forRemoval = true)
67+
default void insert(ItemStack disc) {
68+
this.insert((ItemStackLike) disc);
69+
}
70+
6271
/**
6372
* Ejects the current music disc item in this Jukebox and inserts the given one.
6473
*
6574
* @param disc The music disc item to insert
6675
*/
67-
void insert(ItemStack disc);
76+
void insert(ItemStackLike disc);
6877
}

src/main/java/org/spongepowered/api/event/cause/entity/damage/DamageModifier.java

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.spongepowered.api.item.ItemTypes;
3131
import org.spongepowered.api.item.enchantment.Enchantment;
3232
import org.spongepowered.api.item.inventory.ItemStack;
33+
import org.spongepowered.api.item.inventory.ItemStackLike;
3334
import org.spongepowered.api.item.inventory.ItemStackSnapshot;
3435
import org.spongepowered.api.util.CopyableBuilder;
3536

@@ -162,13 +163,24 @@ public Builder group(final String group) {
162163
return this;
163164
}
164165

166+
/**
167+
* @deprecated Use {@link #item(ItemStackLike)} instead.
168+
*/
169+
@Deprecated(forRemoval = true)
165170
public Builder item(final ItemStack itemStack) {
166-
this.item(java.util.Objects.requireNonNull(itemStack, "ItemStack").asImmutable());
167-
return this;
171+
return this.item((ItemStackLike) itemStack);
168172
}
169173

174+
/**
175+
* @deprecated Use {@link #item(ItemStackLike)} instead.
176+
*/
177+
@Deprecated(forRemoval = true)
170178
public Builder item(final ItemStackSnapshot snapshot) {
171-
this.snapshot = java.util.Objects.requireNonNull(snapshot, "ItemStackSnapshot");
179+
return this.item((ItemStackLike) snapshot);
180+
}
181+
182+
public Builder item(final ItemStackLike item) {
183+
this.snapshot = java.util.Objects.requireNonNull(item, "item").asImmutable();
172184
return this;
173185
}
174186

0 commit comments

Comments
 (0)