introduce scoped registry holder using PhaseTracker

Author: Faithcaio

src/main/java/org/spongepowered/api/adventure/ChatTypes.java

@@ -98,6 +98,6 @@ public static Registry<ChatType> registry() {
     }
 
     public static DefaultedRegistryReference<ChatType> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.CHAT_TYPE, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.CHAT_TYPE, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/command/registrar/tree/CommandTreeNodeTypes.java

@@ -138,6 +138,6 @@ public static Registry<CommandTreeNodeType<?>> registry() {
     }
 
     private static <T extends CommandTreeNode<T>> DefaultedRegistryReference<CommandTreeNodeType<T>> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.COMMAND_TREE_NODE_TYPE, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.COMMAND_TREE_NODE_TYPE, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/data/type/ArtTypes.java

@@ -148,6 +148,6 @@ public static Registry<ArtType> registry() {
     }
 
     private static DefaultedRegistryReference<ArtType> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.ART_TYPE, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.ART_TYPE, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/data/type/BannerPatternShapes.java

@@ -134,6 +134,6 @@ public static Registry<BannerPatternShape> registry() {
     }
 
     private static DefaultedRegistryReference<BannerPatternShape> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.BANNER_PATTERN_SHAPE, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.BANNER_PATTERN_SHAPE, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/effect/sound/music/MusicDiscs.java

@@ -86,6 +86,6 @@ public static Registry<MusicDisc> registry() {
     }
 
     private static DefaultedRegistryReference<MusicDisc> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.MUSIC_DISC, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.MUSIC_DISC, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/event/cause/entity/damage/DamageTypes.java

@@ -146,6 +146,6 @@ public static Registry<DamageType> registry() {
     }
 
     private static DefaultedRegistryReference<DamageType> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.DAMAGE_TYPE, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.DAMAGE_TYPE, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/item/enchantment/EnchantmentTypes.java

@@ -284,6 +284,6 @@ public static Registry<EnchantmentType> registry() {
     }
 
     private static DefaultedRegistryReference<EnchantmentType> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.ENCHANTMENT_TYPE, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.ENCHANTMENT_TYPE, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/item/recipe/smithing/TrimMaterials.java

@@ -67,6 +67,6 @@ public static Registry<TrimMaterial> registry() {
     }
 
     private static DefaultedRegistryReference<TrimMaterial> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.TRIM_MATERIAL, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.TRIM_MATERIAL, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/item/recipe/smithing/TrimPatterns.java

@@ -81,6 +81,6 @@ public static Registry<TrimPattern> registry() {
     }
 
     private static DefaultedRegistryReference<TrimPattern> key(final ResourceKey location) {
-        return RegistryKey.of(RegistryTypes.TRIM_PATTERN, location).asDefaultedReference(Sponge::server);
+        return RegistryKey.of(RegistryTypes.TRIM_PATTERN, location).asScopedReference();
     }
 }

src/main/java/org/spongepowered/api/registry/RegistryKey.java

@@ -73,6 +73,14 @@ static <T> RegistryKey<T> of(final RegistryType<T> registry, final ResourceKey l
      */
     <V extends T> DefaultedRegistryReference<V> asDefaultedReference(final Supplier<RegistryHolder> defaultHolder);
 
+    /**
+     * Generates a utility {@link DefaultedRegistryReference reference} used to assist in querying a value from this key.
+     * This uses the current Cause to determine the {@link RegistryHolder}
+     *
+     * @return The reference
+     */
+    <V extends T> DefaultedRegistryReference<V> asScopedReference();
+
     interface Factory {
 
         <T> RegistryKey<T> of(RegistryType<T> registry, ResourceKey location);