Add User#hasPlayedBefore

Author: aromaa

src/main/java/org/spongepowered/api/entity/living/player/User.java

@@ -25,6 +25,7 @@
 package org.spongepowered.api.entity.living.player;
 
 import org.spongepowered.api.ResourceKey;
+import org.spongepowered.api.Server;
 import org.spongepowered.api.block.entity.EnderChest;
 import org.spongepowered.api.data.DataHolder;
 import org.spongepowered.api.data.Keys;
@@ -203,4 +204,13 @@ default Value.Mutable<VanishState> vanishState() {
         return this.requireValue(Keys.VANISH_STATE).asMutable();
     }
 
+    /**
+     * Gets if the {@link User} has played on the {@link Server} before. Added
+     * as a utility.
+     *
+     * @return True if played before, false otherwise
+     */
+    default boolean hasPlayedBefore() {
+        return !this.firstJoined().map(Value::get).equals(this.lastJoined().map(Value::get));
+    }
 }

src/main/java/org/spongepowered/api/entity/living/player/server/ServerPlayer.java

@@ -299,7 +299,7 @@ default Value.Mutable<Boolean> hasViewedCredits() {
      * @return True if played before, false otherwise
      */
     default boolean hasPlayedBefore() {
-        return !this.firstJoined().equals(this.lastPlayed());
+        return !this.firstJoined().map(Value::get).equals(this.lastJoined().map(Value::get));
     }
 
     /**