Merge api8 fixes into api9

Signed-off-by: Gabriel Harris-Rouquette <[email protected]>

Author: gabizou

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,26 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Feature or Implementation Request for Sponge Implementations
+    url: https://github.com/SpongePowered/Sponge/issues/new?assignees=&labels=status%3A+needs+triage%2Ctype%3A+feature+request&template=feature_request.yml
+    about: "If you're using an API and it fails with an abstract method or no class def error, report it here."
+  - name: Bug report for Sponge for Minecraft 1.16.5 or later
+    url: https://github.com/SpongePowered/Sponge/issues/new?assignees=&labels=status%3A+needs+triage%2Ctype%3A+bug&template=bug_report.yml
+    about: "If you've discovered a bug with Sponge itself, report that here."
+  - name: Bug report for SpongeForge for Minecraft 1.12.2
+    url: https://github.com/SpongePowered/SpongeForge/issues/new?assignees=&labels=&template=legacy_issue.yml
+    about: "Issues for SpongeForge for Minecraft 1.12.2 should be reported on the SpongeForge repository."
+  - name: Bug report for SpongeVanilla for Minecraft 1.12.2
+    url: https://github.com/SpongePowered/SpongeVanilla/issues/new?assignees=&labels=&template=legacy_issue.yml
+    about: "Issues for SpongeVanilla for Minecraft 1.12.2 should be reported on the SpongeVanilla repository."
+  - name: Known Mod Incompatibilities
+    url: https://docs.spongepowered.org/stable/en/server/spongineer/incompatible.html
+    about: "If you're potentially having issues with mod conflicts, read this page. You may simply need to change a mod or sponge setting."
+  - name: Sponge Docs
+    url: https://docs.spongepowered.org/
+    about: "If you need help setting up a server, our Docs pages may help you."
+  - name: Sponge Forums
+    url: https://forums.spongepowered.org/
+    about: "If you need support running your server and want to ask a question, post on our official forums"
+  - name: Sponge Discord Guild
+    url: https://discord.gg/sponge
+    about: "For quick help, join our Discord channel!"

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -0,0 +1,68 @@
+name: Request Addition or Change to API
+description: If you want a new API or are requesting a change to an API, ask here.
+labels: [ "status: needs triage" ]
+body:
+  - type: markdown
+    attributes:
+      value: "## Before You Begin"
+  - type: markdown
+    attributes:
+      value: >
+        This is for requesting a new API to an existing version of the SpongeAPI, or for requesting a change that will 
+        appear in newer versions of the API. This is **not** for reporting errors when trying to use an API in one of
+        our implementations - if you are getting `AbtractMethodError`s or `NoClassDefError`s, [please report that to the
+        Sponge repository instead](https://github.com/SpongePowered/Sponge/issues/new/choose).
+        
+        
+        Please make sure you have searched existing issues to see if someone else has made the same request as you first.
+        We will close duplicates.
+        
+        
+        Remember, Github Issues is not for support. If you require help, visit the 
+        [Sponge Docs](https://docs.spongepowered.org), our [Forums](https://forums.spongepowered.org) or 
+        [Discord Server](https://discord.gg/sponge).
+  - type: input
+    id: version
+    attributes:
+      label: Major SpongeAPI version
+      description: What major version of the API do you want this to target?
+      placeholder: ex. 8, 9
+    validations:
+      required: true
+  - type: dropdown
+    id: breakingchange
+    attributes:
+      label: Is this likely to be a breaking change?
+      description: >
+        A breaking change can be, but is not limited to:
+        
+        
+        * A method is removed from an class/interface
+        
+        * A method's signature is changed (including the number of parameters, the types of those parameters, and 
+          the return type of a method) instead of adding an overload (note that changing a return type from `void` to
+          something else, such as `boolean` is still a breaking change).
+        
+        * A class/interface is removed or renamed, or is converted between a class and an interface
+        
+        * The inheritance tree is modified (other than simply being added to)
+        
+        
+        If you are unsure, select "I don't know". **Breaking changes can only target unreleased major versions.**
+      options:
+        - "Yes"
+        - "No"
+        - "I don't know"
+    validations:
+      required: true
+  - type: textarea
+    id: what-do-you-want
+    attributes:
+      label: What are you requesting?
+      description: >
+        Explain what what you're requesting and why you're requesting it. Please add as much detail as you can.
+        Feel free to give suggestions as to the form of the API you want - it doesn't need to be exact at this stage
+        as we may help you refine your idea.
+    validations:
+      required: true
+

src/main/java/org/spongepowered/api/event/world/chunk/ChunkEvent.java

@@ -28,6 +28,7 @@
 import org.spongepowered.api.event.Cancellable;
 import org.spongepowered.api.event.Event;
 import org.spongepowered.api.util.annotation.eventgen.NoFactoryMethod;
+import org.spongepowered.api.world.World;
 import org.spongepowered.api.world.chunk.Chunk;
 import org.spongepowered.api.world.chunk.WorldChunk;
 import org.spongepowered.api.world.server.ServerWorld;
@@ -125,7 +126,11 @@ interface Generated extends WorldScoped {
     }
 
     /**
-     * Called when a {@link WorldChunk chunk} is done loading.
+     * Called when a {@link WorldChunk chunk} is loaded. This can be called
+     * outside the {@link World#engine() main} {@link Thread}. It is NOT safe
+     * to perform modifications to the {@link World} or via
+     * {@link org.spongepowered.api.world.server.ServerLocation} as this could
+     * result in a deadlock.
      */
     interface Load extends WorldScoped {
 

src/main/java/org/spongepowered/api/world/server/ServerWorld.java

@@ -82,6 +82,11 @@ default UUID uniqueId() {
         return this.properties().uniqueId();
     }
 
+    @Override
+    default WorldChunk chunkAtBlock(final Vector3i blockPosition) {
+        return this.chunkAtBlock(blockPosition.x(), blockPosition.y(), blockPosition.z());
+    }
+
     @Override
     default WorldChunk chunkAtBlock(final int bx, final int by, final int bz) {
         final Vector3i chunkPos = this.engine().chunkLayout().forceToChunk(bx, by, bz);