Clarify documentation on Players joining events

Previously it was expected a SpawnEntityEvent would be thrown for a Player
connecting to the server, but the nature of cancellations doesn't
work with Players being added to the world.

In relation to SpongePowered/Sponge#2412.

Author: gabizou

src/main/java/org/spongepowered/api/event/entity/SpawnEntityEvent.java

@@ -38,10 +38,6 @@
  *
  * <p>Note: To determine the {@link Cause}, refer to package
  * org.spongepowered.api.event.cause.entity.spawn.</p>
- *
- * <p>For players, this event is fired before they have fully
- * joined the world. {@link ServerSideConnectionEvent} is the
- * recommended event to interact with connecting players.</p>
  */
 @GenerateFactoryMethod
 @ImplementedBy(value = AbstractSpawnEntityEvent.class, priority = 2)

src/main/java/org/spongepowered/api/event/network/ServerSideConnectionEvent.java

@@ -47,18 +47,17 @@
 /**
  * Represents an event fired during the login process.
  *
- * <p>Together with {@link SpawnEntityEvent}, these events represent the
- * progression of a {@link ServerPlayer player} from first authenticating, to being fully
- * loaded in the world.</p>
+ * <p>These events represent the progression of a {@link ServerPlayer player}
+ * from first authenticating, to being fully loaded in the world.</p>
  *
  * <p>The events are fired in the following order:</p>
  *
- * <p>#Auth -&gt; #Handshake -&gt; #Login -&gt; {@link SpawnEntityEvent} -&gt; #Join</p>
+ * <p>#Auth -&gt; #Handshake -&gt; #Login -&gt; #Join</p>
  *
- * <p>{@link SpawnEntityEvent} is still fired for players, for consistency.
- * However, the player is not at a well-defined state at that point. It's
- * recommended to use the event's subinterfaces to interact with the player
- * at well-defined moments during the connection process.</p>
+ * <p>Traditionally one could consider a {@link SpawnEntityEvent} to be thrown,
+ * but due to the nature of cancellations, a {@link ServerPlayer player} joining
+ * a world after {@link Login login} would be inadvisable to cancel due to the
+ * inconsistent state of both the player and the player's client.</p>
  */
 public interface ServerSideConnectionEvent extends Event {
 
@@ -182,11 +181,13 @@ interface Login extends ServerSideConnectionEvent, MessageEvent, Event, Cancella
     }
 
     /**
-     * Called when a {@link ServerPlayer player} joins the game within a {@link ServerWorld world} for the first
-     * time after initial connection.
-     *
-     * <p>The {@link SpawnEntityEvent} for the {@link ServerPlayer player} is fired after the
-     * #Login event. This event is fired after both.</p>
+     * Called when a {@link ServerPlayer player} joins the game within a
+     * {@link ServerWorld world} for the first time after initial connection.
+     * Fired after {@link Login} once the {@link ServerPlayer player} has been
+     * properly added to the {@link ServerWorld}. If data is wanted to be
+     * modified that could affect a player's representation (such as vanishing),
+     * it's recommended to modify such data in the logging in
+     * {@link Login#user() User} instead.
      */
     interface Join extends ServerSideConnectionEvent, AudienceMessageEvent, MessageCancellable {
 

src/main/java/org/spongepowered/api/world/chunk/ChunkState.java

@@ -22,32 +22,6 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
-/*
- /*
- * This file is part of Sponge, licensed under the MIT License (MIT).
- *
- * Copyright (c) SpongePowered.org <http://www.spongepowered.org>
- * Copyright (c) contributors
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
- * THE SOFTWARE.
- */
-
 package org.spongepowered.api.world.chunk;
 
 import org.spongepowered.api.registry.DefaultedRegistryValue;