build: Use JetBrains annotations for nullability

While these are less featured than checker-qual, the annotations are a
smaller download and release less frequently, so users are more likely
to have the correct version cached locally through use in Sponge.

Author: zml2008

build.gradle.kts

@@ -58,14 +58,9 @@ subprojects {
         }
     }
 
-    repositories {
-        maven("https://repo.spongepowered.org/repository/maven-public/") {
-            name = "sponge"
-        }
-    }
 
     dependencies {
-        "compileOnlyApi"("org.checkerframework:checker-qual:3.24.0")
+        "compileOnlyApi"("org.jetbrains:annotations:23.0.0")
     }
 
     val indraGit = extensions.getByType(net.kyori.indra.git.IndraGitExtension::class)

convention/src/main/groovy/org/spongepowered/gradle/convention/SpongeConventionPlugin.java

@@ -31,8 +31,6 @@
 import net.kyori.indra.git.IndraGitExtension;
 import net.kyori.indra.licenser.spotless.IndraSpotlessLicenserExtension;
 import net.kyori.indra.licenser.spotless.IndraSpotlessLicenserPlugin;
-import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
-import org.checkerframework.checker.nullness.qual.Nullable;
 import org.gradle.api.GradleException;
 import org.gradle.api.Plugin;
 import org.gradle.api.Project;
@@ -55,6 +53,8 @@
 import org.gradle.plugins.signing.SigningExtension;
 import org.gradle.plugins.signing.SigningPlugin;
 import org.gradle.plugins.signing.signatory.pgp.PgpSignatoryProvider;
+import org.jetbrains.annotations.Nullable;
+import org.jetbrains.annotations.UnknownNullability;
 import org.spongepowered.gradle.convention.task.SignJarTask;
 
 import java.io.BufferedReader;
@@ -78,7 +78,7 @@ public abstract class SpongeConventionPlugin implements Plugin<Project> {
 
     private static final String DISABLE_CADIX_LICENSER = "sponge.disableLicenser";
 
-    private @MonotonicNonNull Project project;
+    private @UnknownNullability Project project;
 
     @Override
     public void apply(final Project target) {

plugin-development/build.gradle.kts

@@ -1,5 +1,7 @@
 dependencies {
-    implementation("org.spongepowered:plugin-meta:0.8.0")
+    implementation("org.spongepowered:plugin-meta:0.8.0") {
+        exclude(group = "org.checkerframework", module = "checker-qual")
+    }
     // implementation("org.spongepowered:vanillagradle:0.2-SNAPSHOT")
     // implementation("gradle.plugin.org.jetbrains.gradle.plugin.idea-ext:gradle-idea-ext:0.10")
 }

plugin-development/src/main/java/org/spongepowered/gradle/plugin/SpongePluginGradle.java

@@ -24,8 +24,6 @@
  */
 package org.spongepowered.gradle.plugin;
 
-import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
-import org.checkerframework.checker.nullness.qual.NonNull;
 import org.gradle.api.Action;
 import org.gradle.api.GradleException;
 import org.gradle.api.NamedDomainObjectProvider;
@@ -52,6 +50,8 @@
 import org.gradle.api.tasks.TaskProvider;
 import org.gradle.api.tasks.bundling.AbstractArchiveTask;
 import org.gradle.process.CommandLineArgumentProvider;
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.UnknownNullability;
 import org.spongepowered.gradle.common.Constants;
 import org.spongepowered.gradle.common.SpongePlatform;
 import org.spongepowered.gradle.plugin.config.PluginConfiguration;
@@ -64,10 +64,10 @@
 
 public final class SpongePluginGradle implements Plugin<Object> {
 
-    private @MonotonicNonNull Project project;
+    private @UnknownNullability Project project;
 
     @Override
-    public void apply(final @NonNull Object target) {
+    public void apply(final @NotNull Object target) {
         if (target instanceof Project) {
             this.applyToProject((Project) target);
         } else if (target instanceof Settings) {

plugin-development/src/main/java/org/spongepowered/gradle/plugin/SpongeVersioningMetadataRule.java

@@ -24,13 +24,13 @@
  */
 package org.spongepowered.gradle.plugin;
 
-import org.checkerframework.checker.nullness.qual.Nullable;
 import org.gradle.api.artifacts.CacheableRule;
 import org.gradle.api.artifacts.ComponentMetadataContext;
 import org.gradle.api.artifacts.ComponentMetadataDetails;
 import org.gradle.api.artifacts.ComponentMetadataRule;
 import org.gradle.api.attributes.Attribute;
 import org.gradle.api.attributes.AttributeContainer;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.Arrays;
 import java.util.Collections;

repository/src/main/java/org/spongepowered/gradle/repository/RepositoryPlugin.java

@@ -24,19 +24,19 @@
  */
 package org.spongepowered.gradle.repository;
 
-import org.checkerframework.checker.nullness.qual.NonNull;
 import org.gradle.api.GradleException;
 import org.gradle.api.Plugin;
 import org.gradle.api.Project;
 import org.gradle.api.artifacts.dsl.RepositoryHandler;
 import org.gradle.api.initialization.Settings;
 import org.gradle.api.invocation.Gradle;
 import org.gradle.api.plugins.ExtensionAware;
+import org.jetbrains.annotations.NotNull;
 
 public class RepositoryPlugin implements Plugin<Object> {
 
     @Override
-    public void apply(final @NonNull Object target) {
+    public void apply(final @NotNull Object target) {
         if (target instanceof Project) {
             this.applyToProject((Project) target);
         } else if (target instanceof Settings) {

repository/src/main/java/org/spongepowered/gradle/repository/SpongeRepositoryExtension.java

@@ -26,9 +26,9 @@
 
 import static java.util.Objects.requireNonNull;
 
-import org.checkerframework.checker.nullness.qual.NonNull;
 import org.gradle.api.Action;
 import org.gradle.api.artifacts.repositories.MavenArtifactRepository;
+import org.jetbrains.annotations.NotNull;
 
 /**
  * Extension for configuring Sponge's repositories.
@@ -50,7 +50,7 @@ public interface SpongeRepositoryExtension {
      * @return the created repository
      * @since 2.1.0
      */
-    default MavenArtifactRepository all(final @NonNull Action<MavenArtifactRepository> extraConfig) {
+    default MavenArtifactRepository all(final @NotNull Action<MavenArtifactRepository> extraConfig) {
         final MavenArtifactRepository ret = all();
         requireNonNull(extraConfig, "extraConfig").execute(ret);
         return ret;
@@ -71,7 +71,7 @@ default MavenArtifactRepository all(final @NonNull Action<MavenArtifactRepositor
      * @return the created repository
      * @since 2.1.0
      */
-    default MavenArtifactRepository releases(final @NonNull Action<MavenArtifactRepository> extraConfig) {
+    default MavenArtifactRepository releases(final @NotNull Action<MavenArtifactRepository> extraConfig) {
         final MavenArtifactRepository ret = releases();
         requireNonNull(extraConfig, "extraConfig").execute(ret);
         return ret;
@@ -92,7 +92,7 @@ default MavenArtifactRepository releases(final @NonNull Action<MavenArtifactRepo
      * @return the created repository
      * @since 2.1.0
      */
-    default MavenArtifactRepository snapshots(final @NonNull Action<MavenArtifactRepository> extraConfig) {
+    default MavenArtifactRepository snapshots(final @NotNull Action<MavenArtifactRepository> extraConfig) {
         final MavenArtifactRepository ret = snapshots();
         requireNonNull(extraConfig, "extraConfig").execute(ret);
         return ret;

settings.gradle.kts

@@ -16,6 +16,13 @@ pluginManagement {
     }
 }
 
+dependencyResolutionManagement {
+    repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
+    repositories {
+        pluginManagement.repositories.forEach { add(it) }
+    }
+}
+
 rootProject.name = "SpongeGradle"
 
 sequenceOf("convention", "plugin-development", "repository", "testlib").forEach {