ModAPI.Common: simplify loading of {InstalledMods,LauncherSettings}.config

Author: Rosalie241

ModAPI.Common/InstalledMods.cs

@@ -247,21 +247,17 @@ public bool Load(string path)
 
             if (File.Exists(path))
             {
-
-                using (var reader = new StreamReader(new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.Read)))
+                string xmlIn = File.ReadAllText(path);
+                if (!String.IsNullOrEmpty(xmlIn))
                 {
-                    string xmlIn = reader.ReadToEnd();
-                    if (!String.IsNullOrEmpty(xmlIn))
-                    {
-                        var document = new XmlDocument();
-                        document.LoadXml(xmlIn);
+                    var document = new XmlDocument();
+                    document.LoadXml(xmlIn);
 
-                        foreach (XmlNode node in document.ChildNodes)
+                    foreach (XmlNode node in document.ChildNodes)
+                    {
+                        if (node.Name == InstalledMods.ElementName)
                         {
-                            if (node.Name == InstalledMods.ElementName)
-                            {
-                                Load(document, node);
-                            }
+                            Load(document, node);
                         }
                     }
                 }

ModAPI.Common/LauncherSettings.cs

@@ -74,22 +74,19 @@ public static bool Load(string path)
         {
             if (File.Exists(FileName))
             {
-                using (var reader = new StreamReader(new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.Read)))
+                string xmlIn = File.ReadAllText(path);
+                if (!String.IsNullOrEmpty(xmlIn))
                 {
-                    string xmlIn = reader.ReadToEnd();
-                    if (!String.IsNullOrEmpty(xmlIn))
-                    {
-                        var document = new XmlDocument();
-                        document.LoadXml(xmlIn);
+                    var document = new XmlDocument();
+                    document.LoadXml(xmlIn);
 
-                        foreach (XmlNode node in document.ChildNodes)
+                    foreach (XmlNode node in document.ChildNodes)
+                    {
+                        if (node.Name == "Settings")
                         {
-                            if (node.Name == "Settings")
+                            foreach (XmlNode settingNode in node.ChildNodes)
                             {
-                                foreach (XmlNode settingNode in node.ChildNodes)
-                                {
-                                    _dictionary[settingNode.Name] = settingNode.InnerText;
-                                }
+                                _dictionary[settingNode.Name] = settingNode.InnerText;
                             }
                         }
                     }