ModAPI.Common: add safety to PathDialogs functions

Author: Rosalie241

ModAPI.Common/PathDialogs.cs

@@ -1,6 +1,7 @@
 using System.Threading;
 using System.IO;
 using System.Windows.Forms;
+using System;
 
 namespace ModAPI.Common
 {
@@ -11,43 +12,47 @@ public static string ProcessGalacticAdventures()
         {
             string path = null;
 
-            if (!LauncherSettings.ForceGamePath)
+            try
             {
-                path = SporePath.GetFromRegistry(SporePath.Game.GalacticAdventures);
-            }
-
-            // for debugging purposes
-            // path = null;
-
-            if (path != null)
-            {
-                // move the path to SporebinEP1
-                path = SporePath.MoveToSporebinEP1(path);
-            }
+                if (!LauncherSettings.ForceGamePath)
+                {
+                    path = SporePath.GetFromRegistry(SporePath.Game.GalacticAdventures);
+                }
 
-            // If we didn't find the path in the registry or was not valid, ask the user
-            if (path == null || !Directory.Exists(path))
-            {
+                if (path != null)
+                {
+                    // move the path to SporebinEP1
+                    path = SporePath.MoveToSporebinEP1(path);
+                }
 
-                if (path == null)
+                // If we didn't find the path in the registry or was not valid, ask the user
+                if (path == null || !Directory.Exists(path))
                 {
-                    path = LauncherSettings.GamePath;
-                    if (path == null || path.Length == 0)
-                    {
-                        var result = MessageBox.Show(CommonStrings.GalacticAdventuresNotFoundSpecifyManual, CommonStrings.GalacticAdventuresNotFound,
-                            MessageBoxButtons.OKCancel, MessageBoxIcon.Exclamation);
 
-                        if (result == DialogResult.OK)
+                    if (path == null)
+                    {
+                        path = LauncherSettings.GamePath;
+                        if (path == null || path.Length == 0)
                         {
-                            path = ShowGalacticAdventuresChooserDialog();
+                            var result = MessageBox.Show(CommonStrings.GalacticAdventuresNotFoundSpecifyManual, CommonStrings.GalacticAdventuresNotFound,
+                                MessageBoxButtons.OKCancel, MessageBoxIcon.Exclamation);
+
+                            if (result == DialogResult.OK)
+                            {
+                                path = ShowGalacticAdventuresChooserDialog();
+                            }
                         }
                     }
+                    else
+                    {
+                        // move the path to SporebinEP1
+                        path = SporePath.MoveToSporebinEP1(path);
+                    }
                 }
-                else
-                {
-                    // move the path to SporebinEP1
-                    path = SporePath.MoveToSporebinEP1(path);
-                }
+            }
+            catch (Exception)
+            {
+                return null;
             }
 
             return path;
@@ -58,43 +63,47 @@ public static string ProcessSpore()
         {
             string path = null;
 
-            if (!LauncherSettings.ForceGamePath)
+            try
             {
-                path = SporePath.GetFromRegistry(SporePath.Game.Spore);
-            }
-
-            // for debugging purposes
-            // path = null;
-
-            if (path != null)
-            {
-                // move the path to Sporebin
-                path = SporePath.MoveToSporebin(path);
-            }
+                if (!LauncherSettings.ForceGamePath)
+                {
+                    path = SporePath.GetFromRegistry(SporePath.Game.Spore);
+                }
 
-            // If we didn't find the path in the registry or was not valid, ask the user
-            if (path == null || !Directory.Exists(path))
-            {
+                if (path != null)
+                {
+                    // move the path to Sporebin
+                    path = SporePath.MoveToSporebin(path);
+                }
 
-                if (path == null)
+                // If we didn't find the path in the registry or was not valid, ask the user
+                if (path == null || !Directory.Exists(path))
                 {
-                    path = LauncherSettings.GamePath;
-                    if (path == null || path.Length == 0)
-                    {
-                        var result = MessageBox.Show(CommonStrings.SporeNotFoundSpecifyManual, CommonStrings.SporeNotFound,
-                            MessageBoxButtons.OKCancel, MessageBoxIcon.Exclamation);
 
-                        if (result == DialogResult.OK)
+                    if (path == null)
+                    {
+                        path = LauncherSettings.GamePath;
+                        if (path == null || path.Length == 0)
                         {
-                            path = ShowSporeChooserDialog();
+                            var result = MessageBox.Show(CommonStrings.SporeNotFoundSpecifyManual, CommonStrings.SporeNotFound,
+                                MessageBoxButtons.OKCancel, MessageBoxIcon.Exclamation);
+
+                            if (result == DialogResult.OK)
+                            {
+                                path = ShowSporeChooserDialog();
+                            }
                         }
                     }
+                    else
+                    {
+                        // move the path to Sporebin
+                        path = SporePath.MoveToSporebin(path);
+                    }
                 }
-                else
-                {
-                    // move the path to Sporebin
-                    path = SporePath.MoveToSporebin(path);
-                }
+            }
+            catch (Exception)
+            {
+                return null;
             }
 
             return path;
@@ -105,9 +114,6 @@ public static string ProcessSteam()
         {
             string path = SporePath.GetFromRegistry(SporePath.SteamRegistryKeys, new string[] { SporePath.SteamRegistryValue });
 
-            // for debugging purposes
-            // path = null;
-
             if (path != null)
             {
                 // move the path to Steam