fix: check for empty iter-/generators (#188)

Signed-off-by: Christopher Arndt <[email protected]>

Author: SpotlightKid

src/_rtmidi.pyx

@@ -1098,9 +1098,6 @@ cdef class MidiOut(MidiBase):
         """
         cdef vector[unsigned char] msg_v
 
-        if not message:
-            raise ValueError("'message' must not be empty.")
-
         try:
             msg_v.reserve(len(message))
         except TypeError:
@@ -1109,7 +1106,9 @@ cdef class MidiOut(MidiBase):
         for c in message:
             msg_v.push_back(c)
 
-        if msg_v.size() > 3 and msg_v.at(0) != 0xF0:
+        if msg_v.size() == 0:
+            raise ValueError("'message' must not be empty.")
+        elif msg_v.size() > 3 and msg_v.at(0) != 0xF0:
             raise ValueError("'message' longer than 3 bytes but does not "
                              "start with 0xF0.")
 

tests/test_rtmidi.py

@@ -86,6 +86,10 @@ def test_send_supports_iterator(self):
     def test_send_raises_if_message_too_long(self):
         self.assertRaises(ValueError, self.midi_out.send_message, [1, 2, 3, 4])
 
+    def test_send_raises_if_message_empty(self):
+        self.assertRaises(ValueError, self.midi_out.send_message, [])
+        self.assertRaises(ValueError, self.midi_out.send_message, iter([]))
+
     def test_send_accepts_sysex(self):
         self.set_up_loopback()
         self.midi_in.ignore_types(sysex=False)