Skip to content

Commit 15afd92

Browse files
committed
修复客户端获取decision时,将已删除的decision也查询到并返回的bug
1 parent 529a9ed commit 15afd92

File tree

5 files changed

+7
-14
lines changed

5 files changed

+7
-14
lines changed

spring-cloud-gray-server/src/main/java/cn/springcloud/gray/server/module/gray/GrayPolicyModule.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ public interface GrayPolicyModule {
2525

2626
List<GrayPolicy> listEnabledGrayPoliciesByNamespace(String namespace);
2727

28-
Page<GrayDecision> listGrayDecisionsByPolicyId(Long policyId, Pageable pageable);
29-
3028
GrayPolicy saveGrayPolicy(GrayPolicy grayPolicy);
3129

3230
void deleteGrayPolicy(Long policyId, String userId);
@@ -43,7 +41,7 @@ public interface GrayPolicyModule {
4341

4442
GrayDecision getGrayDecision(Long id);
4543

46-
List<GrayDecision> listGrayDecisionsByPolicyId(Long policyId);
44+
List<GrayDecision> listEnabledGrayDecisionsByPolicyId(Long policyId);
4745

4846
GrayPolicyDecision newGrayPolicy(GrayPolicyDecision policyDecision);
4947

spring-cloud-gray-server/src/main/java/cn/springcloud/gray/server/module/gray/SimpleGrayModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ public PolicyDefinition ofGrayPolicy(GrayPolicy grayPolicy) {
219219

220220
@Override
221221
public List<DecisionDefinition> ofGrayDecisionByPolicyId(Long policyId) {
222-
List<GrayDecision> grayDecisions = grayPolicyModule.listGrayDecisionsByPolicyId(policyId);
222+
List<GrayDecision> grayDecisions = grayPolicyModule.listEnabledGrayDecisionsByPolicyId(policyId);
223223
List<DecisionDefinition> decisionDefinitions = new ArrayList<>(grayDecisions.size());
224224
grayDecisions.forEach(grayDecision -> {
225225
try {

spring-cloud-gray-server/src/main/java/cn/springcloud/gray/server/module/gray/jpa/JPAGrayPolicyModule.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,6 @@ public List<GrayPolicy> listEnabledGrayPoliciesByNamespace(String namespace) {
5959
return grayPolicyService.listEnabledGrayPoliciesByNamespace(namespace);
6060
}
6161

62-
@Override
63-
public Page<GrayDecision> listGrayDecisionsByPolicyId(Long policyId, Pageable pageable) {
64-
return grayDecisionService.listGrayDecisionsByPolicyId(policyId, pageable);
65-
}
66-
6762
@Transactional
6863
@Override
6964
public GrayPolicy saveGrayPolicy(GrayPolicy grayPolicy) {
@@ -145,8 +140,8 @@ public GrayDecision getGrayDecision(Long id) {
145140
}
146141

147142
@Override
148-
public List<GrayDecision> listGrayDecisionsByPolicyId(Long policyId) {
149-
return grayDecisionService.findByPolicyId(policyId);
143+
public List<GrayDecision> listEnabledGrayDecisionsByPolicyId(Long policyId) {
144+
return grayDecisionService.findAllEnabledByPolicyId(policyId);
150145
}
151146

152147
@Transactional

spring-cloud-gray-server/src/main/java/cn/springcloud/gray/server/resources/rest/GrayDecisionResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public ApiRes<List<GrayDecision>> list(@RequestParam("policyId") Long policyId)
4949
}
5050
return ApiRes.<List<GrayDecision>>builder()
5151
.code(CODE_SUCCESS)
52-
.data(grayPolicyModule.listGrayDecisionsByPolicyId(policyId))
52+
.data(grayPolicyModule.listEnabledGrayDecisionsByPolicyId(policyId))
5353
.build();
5454
}
5555

spring-cloud-gray-server/src/main/java/cn/springcloud/gray/server/service/GrayDecisionService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ protected ModelMapper<GrayDecision, GrayDecisionDO> getModelMapper() {
4040
return grayDecisionMapper;
4141
}
4242

43-
public List<GrayDecision> findByPolicyId(Long policyId) {
44-
return grayDecisionMapper.dos2models(repository.findByPolicyId(policyId));
43+
public List<GrayDecision> findAllEnabledByPolicyId(Long policyId) {
44+
return grayDecisionMapper.dos2models(repository.findByPolicyIdAndDelFlag(policyId, false));
4545

4646
}
4747

0 commit comments

Comments
 (0)