Skip to content

Commit 1616a84

Browse files
authored
fire VanityReserved event & fix checks for transfers
1. Events were not being fired 2. Transfer function was incorrectly checking for receiver not having a vanity URL. Also added check for sender to have a non-empty vanity url.
1 parent 440cda6 commit 1616a84

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Vanity.sol

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ contract VanityURL is Ownable,Pausable {
192192
require(tokenAddress.doTransfer(msg.sender,transferTokenTo,reservePricing));
193193
vanity_address_mapping[_vanity_url] = msg.sender;
194194
address_vanity_mapping[msg.sender] = _vanity_url;
195+
VanityReserved(msg.sender, _vanity_url);
195196
}
196197

197198
/*
@@ -247,16 +248,19 @@ contract VanityURL is Ownable,Pausable {
247248
require(reservedKeywords[_vanity_url] != 1);
248249
vanity_address_mapping[_vanity_url] = msg.sender;
249250
address_vanity_mapping[msg.sender] = _vanity_url;
251+
VanityReserved(msg.sender, _vanity_url);
250252
}
251253

252254
/*
253255
function to transfer ownership for Vanity URL
254256
*/
255257
function transferOwnershipForVanityURL(address _to) whenNotPaused public {
256-
require(bytes(address_vanity_mapping[_to]).length != 0);
258+
require(bytes(address_vanity_mapping[_to]).length == 0);
259+
require(bytes(address_vanity_mapping[msg.sender]).length != 0);
257260
address_vanity_mapping[_to] = address_vanity_mapping[msg.sender];
258261
vanity_address_mapping[address_vanity_mapping[msg.sender]] = _to;
259262
delete(address_vanity_mapping[msg.sender]);
263+
VanityReserved(_to, address_vanity_mapping[msg.sender]);
260264
}
261265

262266
/*

0 commit comments

Comments
 (0)