Enable clippy lint impl_trait_in_params as "warn"

Author: SpriteOvO

Cargo.toml

@@ -15,6 +15,7 @@ keywords = ["spdlog", "log", "logging"]
 categories = ["development-tools::debugging"]
 
 [workspace.lints.clippy]
+impl_trait_in_params = "warn"
 must_use_candidate = "warn"
 unused_result_ok = "warn"
 unused_trait_names = "warn"

spdlog-internal/src/lib.rs

@@ -5,6 +5,10 @@
 //!
 //! [`spdlog-rs`]: https://crates.io/crates/spdlog-rs
 
+// The crate is not intended to be used directly by users, all public items are considered internal
+// API, so we don't care about this warning.
+#![allow(clippy::impl_trait_in_params)]
+
 pub mod pattern_parser;
 
 #[macro_export]

spdlog/src/periodic_worker.rs

@@ -11,7 +11,7 @@ impl PeriodicWorker {
     // Panic if the `interval.is_zero()` is `true`.
     #[allow(clippy::mutex_atomic)]
     #[must_use]
-    pub fn new(callback: impl Fn() -> bool + Send + 'static, interval: Duration) -> Self {
+    pub fn new<F: Fn() -> bool + Send + 'static>(callback: F, interval: Duration) -> Self {
         if interval.is_zero() {
             panic!("PeriodicWorker: the interval cannot be zero")
         }

spdlog/src/test_utils/common.rs

@@ -130,11 +130,12 @@ impl StringSink {
         }
     }
 
-    pub fn with(
-        cb: impl FnOnce(
+    pub fn with<F>(cb: F) -> Self
+    where
+        F: FnOnce(
             WriteSinkBuilder<Vec<u8>, PhantomData<Vec<u8>>>,
         ) -> WriteSinkBuilder<Vec<u8>, PhantomData<Vec<u8>>>,
-    ) -> Self {
+    {
         Self {
             underlying: cb(WriteSink::builder().target(vec![])).build().unwrap(),
         }
@@ -196,7 +197,10 @@ impl Default for NoModFormatter {
 //////////////////////////////////////////////////
 
 #[must_use]
-pub fn build_test_logger(cb: impl FnOnce(&mut LoggerBuilder) -> &mut LoggerBuilder) -> Logger {
+pub fn build_test_logger<F>(cb: F) -> Logger
+where
+    F: FnOnce(&mut LoggerBuilder) -> &mut LoggerBuilder,
+{
     let mut builder = Logger::builder();
     cb(builder.error_handler(|err| panic!("{}", err)));
     builder.build().unwrap()
@@ -214,18 +218,24 @@ macro_rules! assert_trait {
 pub use assert_trait;
 
 #[must_use]
-pub fn echo_logger_from_pattern(
-    pattern: impl Pattern + Clone + 'static,
+pub fn echo_logger_from_pattern<P>(
+    pattern: P,
     name: Option<&'static str>,
-) -> (Logger, Arc<StringSink>) {
+) -> (Logger, Arc<StringSink>)
+where
+    P: Pattern + Clone + 'static,
+{
     echo_logger_from_formatter(PatternFormatter::new(pattern), name)
 }
 
 #[must_use]
-pub fn echo_logger_from_formatter(
-    formatter: impl Formatter + 'static,
+pub fn echo_logger_from_formatter<P>(
+    formatter: P,
     name: Option<&'static str>,
-) -> (Logger, Arc<StringSink>) {
+) -> (Logger, Arc<StringSink>)
+where
+    P: Formatter + 'static,
+{
     let sink = Arc::new(StringSink::with(|b| b.formatter(formatter)));
 
     let mut builder = Logger::builder();

spdlog/src/utils/mod.rs

@@ -10,7 +10,7 @@ pub(crate) use ref_str::*;
 
 use crate::{Error, Result};
 
-pub fn open_file(path: impl AsRef<Path>, truncate: bool) -> Result<File> {
+pub fn open_file<P: AsRef<Path>>(path: P, truncate: bool) -> Result<File> {
     if let Some(parent) = path.as_ref().parent() {
         if !parent.exists() {
             fs::create_dir_all(parent).map_err(Error::CreateDirectory)?;
@@ -31,8 +31,8 @@ pub fn open_file(path: impl AsRef<Path>, truncate: bool) -> Result<File> {
         .map_err(Error::OpenFile)
 }
 
-pub fn open_file_bufw(
-    path: impl AsRef<Path>,
+pub fn open_file_bufw<P: AsRef<Path>>(
+    path: P,
     truncate: bool,
     capacity: Option<usize>,
 ) -> Result<BufWriter<File>> {