Formatter inherit DynClone to avoid explicit clone_box method

Author: SpriteOvO

spdlog/examples/04_format.rs

@@ -57,10 +57,6 @@ fn impl_manually() {
                 .style_range(style_range_begin..style_range_end)
                 .build())
         }
-
-        fn clone_box(&self) -> Box<dyn Formatter> {
-            Box::new(self.clone())
-        }
     }
 
     // Building a custom formatter.

spdlog/src/formatter/full_formatter.rs

@@ -108,10 +108,6 @@ impl Formatter for FullFormatter {
     fn format(&self, record: &Record, dest: &mut StringBuf) -> crate::Result<FmtExtraInfo> {
         self.format_impl(record, dest).map_err(Error::FormatRecord)
     }
-
-    fn clone_box(&self) -> Box<dyn Formatter> {
-        Box::new(self.clone())
-    }
 }
 
 impl Default for FullFormatter {

spdlog/src/formatter/journald_formatter.rs

@@ -59,10 +59,6 @@ impl Formatter for JournaldFormatter {
     fn format(&self, record: &Record, dest: &mut StringBuf) -> crate::Result<FmtExtraInfo> {
         self.format_impl(record, dest).map_err(Error::FormatRecord)
     }
-
-    fn clone_box(&self) -> Box<dyn Formatter> {
-        Box::new(self.clone())
-    }
 }
 
 impl Default for JournaldFormatter {

spdlog/src/formatter/mod.rs

@@ -59,6 +59,7 @@ mod pattern_formatter;
 
 use std::ops::Range;
 
+use dyn_clone::*;
 pub use full_formatter::*;
 #[cfg(any(
     all(target_os = "linux", feature = "native", feature = "libsystemd"),
@@ -77,14 +78,11 @@ use crate::{Record, Result, StringBuf};
 /// See the implementation of [`FullFormatter`] and [./examples] directory.
 ///
 /// [./examples]: https://github.com/SpriteOvO/spdlog-rs/tree/main/spdlog/examples
-pub trait Formatter: Send + Sync {
+pub trait Formatter: Send + Sync + DynClone {
     /// Formats a log record.
     fn format(&self, record: &Record, dest: &mut StringBuf) -> Result<FmtExtraInfo>;
-
-    /// Clones self into a boxed trait object.
-    #[must_use]
-    fn clone_box(&self) -> Box<dyn Formatter>;
 }
+clone_trait_object!(Formatter);
 
 /// Extra information for formatted text.
 #[derive(Clone, Eq, PartialEq, Hash, Debug, Default)]

spdlog/src/formatter/pattern_formatter/mod.rs

@@ -374,10 +374,6 @@ where
         self.pattern.format(record, dest, &mut ctx)?;
         Ok(ctx.fmt_info_builder.build())
     }
-
-    fn clone_box(&self) -> Box<dyn Formatter> {
-        Box::new(self.clone())
-    }
 }
 
 /// Provides context for patterns.

spdlog/src/sink/async_sink/async_pool_sink.rs

@@ -129,7 +129,7 @@ impl Sink for AsyncPoolSink {
     /// internal sinks.
     fn set_formatter(&self, formatter: Box<dyn Formatter>) {
         for sink in &self.backend.sinks {
-            sink.set_formatter(formatter.clone_box())
+            sink.set_formatter(formatter.clone())
         }
     }
 

spdlog/src/test_utils/common.rs

@@ -199,10 +199,6 @@ impl Formatter for NoModFormatter {
 
         Ok(FmtExtraInfo::new())
     }
-
-    fn clone_box(&self) -> Box<dyn Formatter> {
-        Box::new(self.clone())
-    }
 }
 
 impl Default for NoModFormatter {