Skip to content

Commit 6030284

Browse files
authored
openai: Use "gen_ai.request.seed" instead of deprecated "gen_ai.openai.request.seed" attribute. (elastic#76)
1 parent 9e9314d commit 6030284

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

instrumentation/elastic-opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/helpers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from opentelemetry._events import Event, EventLogger
2222
from opentelemetry.semconv._incubating.attributes.gen_ai_attributes import (
2323
GEN_AI_OPENAI_REQUEST_RESPONSE_FORMAT,
24-
GEN_AI_OPENAI_REQUEST_SEED,
2524
GEN_AI_OPENAI_REQUEST_SERVICE_TIER,
2625
GEN_AI_OPENAI_RESPONSE_SERVICE_TIER,
2726
GEN_AI_OPERATION_NAME,
@@ -30,6 +29,7 @@
3029
GEN_AI_REQUEST_MAX_TOKENS,
3130
GEN_AI_REQUEST_MODEL,
3231
GEN_AI_REQUEST_PRESENCE_PENALTY,
32+
GEN_AI_REQUEST_SEED,
3333
GEN_AI_REQUEST_STOP_SEQUENCES,
3434
GEN_AI_REQUEST_TEMPERATURE,
3535
GEN_AI_REQUEST_TOP_P,
@@ -159,7 +159,7 @@ def _is_set(value):
159159
stop_sequences = [stop_sequences]
160160
span_attributes[GEN_AI_REQUEST_STOP_SEQUENCES] = stop_sequences
161161
if _is_set(seed := kwargs.get("seed")):
162-
span_attributes[GEN_AI_OPENAI_REQUEST_SEED] = seed
162+
span_attributes[GEN_AI_REQUEST_SEED] = seed
163163
if _is_set(service_tier := kwargs.get("service_tier")):
164164
span_attributes[GEN_AI_OPENAI_REQUEST_SERVICE_TIER] = service_tier
165165
if _is_set(response_format := kwargs.get("response_format")):

instrumentation/elastic-opentelemetry-instrumentation-openai/tests/test_beta_chat_completions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
from opentelemetry.instrumentation.openai import OpenAIInstrumentor
3030
from opentelemetry.semconv._incubating.attributes.gen_ai_attributes import (
3131
GEN_AI_OPENAI_REQUEST_RESPONSE_FORMAT,
32-
GEN_AI_OPENAI_REQUEST_SEED,
3332
GEN_AI_OPENAI_REQUEST_SERVICE_TIER,
3433
GEN_AI_OPENAI_RESPONSE_SERVICE_TIER,
3534
GEN_AI_OPERATION_NAME,
@@ -38,6 +37,7 @@
3837
GEN_AI_REQUEST_MAX_TOKENS,
3938
GEN_AI_REQUEST_MODEL,
4039
GEN_AI_REQUEST_PRESENCE_PENALTY,
40+
GEN_AI_REQUEST_SEED,
4141
GEN_AI_REQUEST_STOP_SEQUENCES,
4242
GEN_AI_REQUEST_TEMPERATURE,
4343
GEN_AI_REQUEST_TOP_P,
@@ -246,7 +246,7 @@ def test_chat_all_the_client_options(default_openai_env, trace_exporter, metrics
246246

247247
address, port = address_and_port(client)
248248
expected_attrs = {
249-
GEN_AI_OPENAI_REQUEST_SEED: 100,
249+
GEN_AI_REQUEST_SEED: 100,
250250
GEN_AI_OPENAI_REQUEST_SERVICE_TIER: "default",
251251
GEN_AI_OPENAI_REQUEST_RESPONSE_FORMAT: "text",
252252
GEN_AI_OPENAI_RESPONSE_SERVICE_TIER: "default",

instrumentation/elastic-opentelemetry-instrumentation-openai/tests/test_chat_completions.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
from opentelemetry.instrumentation.openai import OpenAIInstrumentor
2929
from opentelemetry.semconv._incubating.attributes.gen_ai_attributes import (
3030
GEN_AI_OPENAI_REQUEST_RESPONSE_FORMAT,
31-
GEN_AI_OPENAI_REQUEST_SEED,
3231
GEN_AI_OPENAI_REQUEST_SERVICE_TIER,
3332
GEN_AI_OPENAI_RESPONSE_SERVICE_TIER,
3433
GEN_AI_OPERATION_NAME,
@@ -37,6 +36,7 @@
3736
GEN_AI_REQUEST_MAX_TOKENS,
3837
GEN_AI_REQUEST_MODEL,
3938
GEN_AI_REQUEST_PRESENCE_PENALTY,
39+
GEN_AI_REQUEST_SEED,
4040
GEN_AI_REQUEST_STOP_SEQUENCES,
4141
GEN_AI_REQUEST_TEMPERATURE,
4242
GEN_AI_REQUEST_TOP_P,
@@ -330,7 +330,7 @@ def test_chat_all_the_client_options(default_openai_env, trace_exporter, metrics
330330

331331
address, port = address_and_port(client)
332332
expected_attrs = {
333-
GEN_AI_OPENAI_REQUEST_SEED: 100,
333+
GEN_AI_REQUEST_SEED: 100,
334334
GEN_AI_OPENAI_REQUEST_SERVICE_TIER: "default",
335335
GEN_AI_OPENAI_REQUEST_RESPONSE_FORMAT: "text",
336336
GEN_AI_OPENAI_RESPONSE_SERVICE_TIER: "default",
@@ -1203,7 +1203,7 @@ def test_chat_stream_all_the_client_options(default_openai_env, trace_exporter,
12031203

12041204
address, port = address_and_port(client)
12051205
expected_attrs = {
1206-
GEN_AI_OPENAI_REQUEST_SEED: 100,
1206+
GEN_AI_REQUEST_SEED: 100,
12071207
GEN_AI_OPENAI_REQUEST_RESPONSE_FORMAT: "text",
12081208
GEN_AI_OPENAI_REQUEST_SERVICE_TIER: "default",
12091209
GEN_AI_OPENAI_RESPONSE_SERVICE_TIER: "default",

0 commit comments

Comments
 (0)