Skip to content

Issue: AllPayAuction logic allows unauthorized withdrawal of all funds. #18

@aniket866

Description

@aniket866
  • Bug: The withdraw function in AllPayAuction.sol does not restrict who can call it. Anyone can call withdraw(auctionId) and the contract will send the availableFunds (minus fees) to the auctioneer.

- Fix: Add the onlyManager modifier or a custom require(msg.sender == auction.auctioneer) check.

  • Why: Without access control, a malicious actor could trigger withdrawals prematurely or cause accounting issues for the auctioneer.

@kaneki003 Please allow me to propose this fix, thankyou

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions