Skip to content

Lack of Access Control on Withdrawals #21

@aniket866

Description

@aniket866

In AllPayAuction.sol and EnglishAuction.sol, the withdraw functions are external but do not verify that the msg.sender is the auctioneer.

Issue: Anyone can trigger the withdrawal of funds to the auctioneer's address.

Risk: While the funds go to the correct person (the auctioneer), this allows external parties to force financial realizations for the auctioneer, which might have tax or accounting implications, or interfere with a manager's planned strategy.

Fix: Add require(msg.sender == auction.auctioneer) to the withdraw functions.

@kaneki003 Please check this out , /assign

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions