Oubtrain Bid Adapter : netRevenue simplification (prebid#12888)

* netrevenue simplification

* calculate NATIVE_ASSET_IDS instrad of hardcoding

* char to int

* fix test

Author: markkuhar

modules/outbrainBidAdapter.js

@@ -14,7 +14,6 @@ import {Renderer} from '../src/Renderer.js';
 const BIDDER_CODE = 'outbrain';
 const GVLID = 164;
 const CURRENCY = 'USD';
-const NATIVE_ASSET_IDS = { 0: 'title', 2: 'icon', 3: 'image', 5: 'sponsoredBy', 4: 'body', 1: 'cta' };
 const NATIVE_PARAMS = {
   title: { id: 0, name: 'title' },
   icon: { id: 2, type: 1, name: 'img' },
@@ -23,6 +22,10 @@ const NATIVE_PARAMS = {
   body: { id: 4, name: 'data', type: 2 },
   cta: { id: 1, type: 12, name: 'data' }
 };
+const NATIVE_ASSET_IDS = Object.entries(NATIVE_PARAMS).reduce((acc, [key, value]) => {
+  acc[value.id] = key;
+  return acc;
+}, {});
 const OUTSTREAM_RENDERER_URL = 'https://acdn.adnxs.com/video/outstream/ANOutstreamVideo.js';
 const OB_USER_TOKEN_KEY = 'OB-USER-TOKEN';
 
@@ -75,7 +78,6 @@ export const spec = {
     const timeout = bidderRequest.timeout;
 
     const imps = validBidRequests.map((bid, id) => {
-      bid.netRevenue = 'net';
       const imp = {
         id: id + 1 + ''
       }
@@ -193,7 +195,7 @@ export const spec = {
           cpm: bidResponse.price,
           creativeId: bidResponse.crid,
           ttl: 360,
-          netRevenue: bid.netRevenue === 'net',
+          netRevenue: true,
           currency: cur,
           mediaType: type,
           nurl: bidResponse.nurl,

test/spec/modules/outbrainBidAdapter_spec.js

@@ -703,7 +703,7 @@ describe('Outbrain Adapter', function () {
             cpm: 1.1,
             creativeId: '28023739',
             ttl: 360,
-            netRevenue: false,
+            netRevenue: true,
             currency: 'USD',
             mediaType: 'native',
             nurl: 'http://example.com/win/${AUCTION_PRICE}',
@@ -780,7 +780,7 @@ describe('Outbrain Adapter', function () {
             cpm: 1.1,
             creativeId: '29998660',
             ttl: 360,
-            netRevenue: false,
+            netRevenue: true,
             currency: 'USD',
             mediaType: 'banner',
             nurl: 'http://example.com/win/${AUCTION_PRICE}',
@@ -843,7 +843,7 @@ describe('Outbrain Adapter', function () {
             cpm: 1.1,
             creativeId: '29998660',
             ttl: 360,
-            netRevenue: false,
+            netRevenue: true,
             currency: 'USD',
             mediaType: 'video',
             nurl: 'http://example.com/win/${AUCTION_PRICE}',