u8-ify the stream messages

Author: mgravell

src/StackExchange.Redis/RedisDatabase.cs

@@ -4098,28 +4098,28 @@ public override int GetHashSlot(ServerSelectionStrategy serverSelectionStrategy)
             protected override void WriteImpl(PhysicalConnection physical)
             {
                 physical.WriteHeader(Command, argCount);
-                physical.WriteBulkString(StreamConstants.Group);
+                physical.WriteBulkString("GROUP"u8);
                 physical.WriteBulkString(groupName);
                 physical.WriteBulkString(consumerName);
 
                 if (countPerStream.HasValue)
                 {
-                    physical.WriteBulkString(StreamConstants.Count);
+                    physical.WriteBulkString("COUNT"u8);
                     physical.WriteBulkString(countPerStream.Value);
                 }
 
                 if (noAck)
                 {
-                    physical.WriteBulkString(StreamConstants.NoAck);
+                    physical.WriteBulkString("NOACK"u8);
                 }
 
                 if (claimMinIdleTime.HasValue)
                 {
-                    physical.WriteBulkString(StreamConstants.Claim);
+                    physical.WriteBulkString("CLAIM"u8);
                     physical.WriteBulkString(claimMinIdleTime.Value.TotalMilliseconds);
                 }
 
-                physical.WriteBulkString(StreamConstants.Streams);
+                physical.WriteBulkString("STREAMS"u8);
                 for (int i = 0; i < streamPositions.Length; i++)
                 {
                     physical.Write(streamPositions[i].Key);
@@ -4181,11 +4181,11 @@ protected override void WriteImpl(PhysicalConnection physical)
 
                 if (countPerStream.HasValue)
                 {
-                    physical.WriteBulkString(StreamConstants.Count);
+                    physical.WriteBulkString("COUNT"u8);
                     physical.WriteBulkString(countPerStream.Value);
                 }
 
-                physical.WriteBulkString(StreamConstants.Streams);
+                physical.WriteBulkString("STREAMS"u8);
                 for (int i = 0; i < streamPositions.Length; i++)
                 {
                     physical.Write(streamPositions[i].Key);
@@ -4895,28 +4895,28 @@ public SingleStreamReadGroupCommandMessage(int db, CommandFlags flags, RedisKey
             protected override void WriteImpl(PhysicalConnection physical)
             {
                 physical.WriteHeader(Command, argCount);
-                physical.WriteBulkString(StreamConstants.Group);
+                physical.WriteBulkString("GROUP"u8);
                 physical.WriteBulkString(groupName);
                 physical.WriteBulkString(consumerName);
 
                 if (count.HasValue)
                 {
-                    physical.WriteBulkString(StreamConstants.Count);
+                    physical.WriteBulkString("COUNT"u8);
                     physical.WriteBulkString(count.Value);
                 }
 
                 if (noAck)
                 {
-                    physical.WriteBulkString(StreamConstants.NoAck);
+                    physical.WriteBulkString("NOACK"u8);
                 }
 
                 if (claimMinIdleTime.HasValue)
                 {
-                    physical.WriteBulkString(StreamConstants.Claim);
+                    physical.WriteBulkString("CLAIM"u8);
                     physical.WriteBulkString(claimMinIdleTime.Value.TotalMilliseconds);
                 }
 
-                physical.WriteBulkString(StreamConstants.Streams);
+                physical.WriteBulkString("STREAMS"u8);
                 physical.Write(Key);
                 physical.WriteBulkString(afterId);
             }
@@ -4954,11 +4954,11 @@ protected override void WriteImpl(PhysicalConnection physical)
 
                 if (count.HasValue)
                 {
-                    physical.WriteBulkString(StreamConstants.Count);
+                    physical.WriteBulkString("COUNT"u8);
                     physical.WriteBulkString(count.Value);
                 }
 
-                physical.WriteBulkString(StreamConstants.Streams);
+                physical.WriteBulkString("STREAMS"u8);
                 physical.Write(Key);
                 physical.WriteBulkString(afterId);
             }

src/StackExchange.Redis/StreamConstants.cs

@@ -52,8 +52,6 @@ internal static class StreamConstants
 
         internal static readonly RedisValue Destroy = "DESTROY";
 
-        internal static readonly RedisValue Group = "GROUP";
-
         internal static readonly RedisValue Groups = "GROUPS";
 
         internal static readonly RedisValue JustId = "JUSTID";
@@ -65,13 +63,8 @@ internal static class StreamConstants
 
         internal static readonly RedisValue MkStream = "MKSTREAM";
 
-        internal static readonly RedisValue NoAck = "NOACK";
-        internal static readonly RedisValue Claim = "CLAIM";
-
         internal static readonly RedisValue Stream = "STREAM";
 
-        internal static readonly RedisValue Streams = "STREAMS";
-
         private static readonly RedisValue KeepRef = "KEEPREF", DelRef = "DELREF", Acked = "ACKED";
 
         internal static readonly RedisValue Ids = "IDS";