[Tests] Upgrade to xunit v3

Upgrading xunit to v3 to see if this helps our stability issues any.

Author: NickCraver

Directory.Build.props

@@ -15,7 +15,7 @@
     <PackageProjectUrl>https://stackexchange.github.io/StackExchange.Redis/</PackageProjectUrl>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
 
-    <LangVersion>11</LangVersion>
+    <LangVersion>12</LangVersion>
     <RepositoryType>git</RepositoryType>
     <RepositoryUrl>https://github.com/StackExchange/StackExchange.Redis/</RepositoryUrl>
 

Directory.Packages.props

@@ -25,7 +25,7 @@
     <!-- For binding redirect testing, main package gets this transitively -->
     <PackageVersion Include="System.IO.Pipelines" Version="9.0.0" />
     <PackageVersion Include="System.Runtime.Caching" Version="9.0.0" />
-    <PackageVersion Include="xunit" Version="2.9.3" />
+    <PackageVersion Include="xunit.v3" Version="2.0.3" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.1" />
   </ItemGroup>
 </Project>

tests/StackExchange.Redis.Tests/AbortOnConnectFailTests.cs

@@ -2,14 +2,11 @@
 using System.Threading.Tasks;
 using StackExchange.Redis.Tests.Helpers;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
 
-public class AbortOnConnectFailTests : TestBase
+public class AbortOnConnectFailTests(ITestOutputHelper output) : TestBase(output)
 {
-    public AbortOnConnectFailTests(ITestOutputHelper output) : base(output) { }
-
     [Fact]
     public void NeverEverConnectedNoBacklogThrowsConnectionNotAvailableSync()
     {

tests/StackExchange.Redis.Tests/AdhocTests.cs

@@ -1,13 +1,10 @@
 using Xunit;
-using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
 
 [Collection(SharedConnectionFixture.Key)]
-public class AdhocTests : TestBase
+public class AdhocTests(ITestOutputHelper output, SharedConnectionFixture fixture) : TestBase(output, fixture)
 {
-    public AdhocTests(ITestOutputHelper output, SharedConnectionFixture fixture) : base(output, fixture) { }
-
     [Fact]
     public void TestAdhocCommandsAPI()
     {

tests/StackExchange.Redis.Tests/AggressiveTests.cs

@@ -1,18 +1,16 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
 
 [Collection(NonParallelCollection.Name)]
-public class AggressiveTests : TestBase
+public class AggressiveTests(ITestOutputHelper output) : TestBase(output)
 {
-    public AggressiveTests(ITestOutputHelper output) : base(output) { }
-
-    [FactLongRunning]
+    [Fact]
     public async Task ParallelTransactionsWithConditions()
     {
+        Skip.UnlessLongRunning();
         const int Muxers = 4, Workers = 20, PerThread = 250;
 
         var muxers = new IConnectionMultiplexer[Muxers];
@@ -73,9 +71,10 @@ public async Task ParallelTransactionsWithConditions()
 
     private const int IterationCount = 5000, InnerCount = 20;
 
-    [FactLongRunning]
+    [Fact]
     public void RunCompetingBatchesOnSameMuxer()
     {
+        Skip.UnlessLongRunning();
         using var conn = Create();
         var db = conn.GetDatabase();
 
@@ -132,9 +131,10 @@ private static void BatchRunPings(IDatabase db)
         }
     }
 
-    [FactLongRunning]
+    [Fact]
     public async Task RunCompetingBatchesOnSameMuxerAsync()
     {
+        Skip.UnlessLongRunning();
         using var conn = Create();
         var db = conn.GetDatabase();
 
@@ -189,9 +189,10 @@ private static async Task BatchRunPingsAsync(IDatabase db)
         }
     }
 
-    [FactLongRunning]
+    [Fact]
     public void RunCompetingTransactionsOnSameMuxer()
     {
+        Skip.UnlessLongRunning();
         using var conn = Create(logTransactionData: false);
         var db = conn.GetDatabase();
 
@@ -252,9 +253,10 @@ private void TranRunPings(IDatabase db)
         }
     }
 
-    [FactLongRunning]
+    [Fact]
     public async Task RunCompetingTransactionsOnSameMuxerAsync()
     {
+        Skip.UnlessLongRunning();
         using var conn = Create(logTransactionData: false);
         var db = conn.GetDatabase();
 

tests/StackExchange.Redis.Tests/AsyncTests.cs

@@ -3,15 +3,12 @@
 using System.Linq;
 using System.Threading.Tasks;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
 
 [Collection(NonParallelCollection.Name)]
-public class AsyncTests : TestBase
+public class AsyncTests(ITestOutputHelper output) : TestBase(output)
 {
-    public AsyncTests(ITestOutputHelper output) : base(output) { }
-
     protected override string GetConfiguration() => TestConfig.Current.PrimaryServerAndPort;
 
     [Fact]

tests/StackExchange.Redis.Tests/AzureMaintenanceEventTests.cs

@@ -3,14 +3,11 @@
 using System.Net;
 using StackExchange.Redis.Maintenance;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
 
-public class AzureMaintenanceEventTests : TestBase
+public class AzureMaintenanceEventTests(ITestOutputHelper output) : TestBase(output)
 {
-    public AzureMaintenanceEventTests(ITestOutputHelper output) : base(output) { }
-
     [Theory]
     [InlineData("NotificationType|NodeMaintenanceStarting|StartTimeInUTC|2021-03-02T23:26:57|IsReplica|False|IPAddress||SSLPort|15001|NonSSLPort|13001", AzureNotificationType.NodeMaintenanceStarting, "2021-03-02T23:26:57", false, null, 15001, 13001)]
     [InlineData("NotificationType|NodeMaintenanceFailover|StartTimeInUTC||IsReplica|False|IPAddress||SSLPort|15001|NonSSLPort|13001", AzureNotificationType.NodeMaintenanceFailoverComplete, null, false, null, 15001, 13001)]

tests/StackExchange.Redis.Tests/BacklogTests.cs

@@ -1,14 +1,11 @@
 using System;
 using System.Threading.Tasks;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
 
-public class BacklogTests : TestBase
+public class BacklogTests(ITestOutputHelper output) : TestBase(output)
 {
-    public BacklogTests(ITestOutputHelper output) : base(output) { }
-
     protected override string GetConfiguration() => TestConfig.Current.PrimaryServerAndPort + "," + TestConfig.Current.ReplicaServerAndPort;
 
     [Fact]

tests/StackExchange.Redis.Tests/BasicOpTests.cs

@@ -3,23 +3,18 @@
 using System.Threading.Tasks;
 using StackExchange.Redis.KeyspaceIsolation;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
 
 [Collection(SharedConnectionFixture.Key)]
-public class HighIntegrityBasicOpsTests : BasicOpsTests
+public class HighIntegrityBasicOpsTests(ITestOutputHelper output, SharedConnectionFixture fixture) : BasicOpsTests(output, fixture)
 {
-    public HighIntegrityBasicOpsTests(ITestOutputHelper output, SharedConnectionFixture fixture) : base(output, fixture) { }
-
     internal override bool HighIntegrity => true;
 }
 
 [Collection(SharedConnectionFixture.Key)]
-public class BasicOpsTests : TestBase
+public class BasicOpsTests(ITestOutputHelper output, SharedConnectionFixture fixture) : TestBase(output, fixture)
 {
-    public BasicOpsTests(ITestOutputHelper output, SharedConnectionFixture fixture) : base(output, fixture) { }
-
     [Fact]
     public async Task PingOnce()
     {

tests/StackExchange.Redis.Tests/BatchTests.cs

@@ -2,15 +2,12 @@
 using System.Collections.Generic;
 using System.Threading.Tasks;
 using Xunit;
-using Xunit.Abstractions;
 
 namespace StackExchange.Redis.Tests;
 
 [Collection(SharedConnectionFixture.Key)]
-public class BatchTests : TestBase
+public class BatchTests(ITestOutputHelper output, SharedConnectionFixture fixture) : TestBase(output, fixture)
 {
-    public BatchTests(ITestOutputHelper output, SharedConnectionFixture fixture) : base(output, fixture) { }
-
     [Fact]
     public void TestBatchNotSent()
     {