Skip to content

Commit 510b5e2

Browse files
authored
Sentinel: Add HELLO support (#2601)
This allows connections through Sentinel via RESP3 by adding `HELLO` to the command map. Fixes #2591.
1 parent 79e8346 commit 510b5e2

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

docs/ReleaseNotes.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ Current package versions:
88

99
## Unreleased
1010

11-
- Fix [#2593](https://github.com/StackExchange/StackExchange.Redis/pull/2593): `EXPIRETIME` and `PEXPIRETIME` miscategorized as `PrimaryOnly` commands causing them to fail when issued against a read-only replica.
11+
- Fix [#2593](https://github.com/StackExchange/StackExchange.Redis/pull/2593): `EXPIRETIME` and `PEXPIRETIME` miscategorized as `PrimaryOnly` commands causing them to fail when issued against a read-only replica ([#2593 by slorello89](https://github.com/StackExchange/StackExchange.Redis/pull/2593))
12+
- Fix [#2591](https://github.com/StackExchange/StackExchange.Redis/pull/2591): Add `HELLO` to Sentinel connections so they can support RESP3 ([#2601 by NickCraver](https://github.com/StackExchange/StackExchange.Redis/pull/2601))
1213

1314
## 2.7.4
1415

src/StackExchange.Redis/CommandMap.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public sealed class CommandMap
9393
/// </summary>
9494
/// <remarks><seealso href="https://redis.io/topics/sentinel"/></remarks>
9595
public static CommandMap Sentinel { get; } = Create(new HashSet<string> {
96-
"auth", "ping", "info", "role", "sentinel", "subscribe", "shutdown", "psubscribe", "unsubscribe", "punsubscribe" }, true);
96+
"auth", "hello", "ping", "info", "role", "sentinel", "subscribe", "shutdown", "psubscribe", "unsubscribe", "punsubscribe" }, true);
9797

9898
/// <summary>
9999
/// Create a new <see cref="CommandMap"/>, customizing some commands.

tests/StackExchange.Redis.Tests/SentinelTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ public async Task PrimaryConnectAsyncTest()
8686
}
8787

8888
[Fact]
89+
[RunPerProtocol]
8990
public void SentinelConnectTest()
9091
{
9192
var options = ServiceOptions.Clone();

0 commit comments

Comments
 (0)