Skip to content

Commit 94ec702

Browse files
committed
prefer WriteBulkString("WHATEVER"u8) over WriteBulkString(RedisLiterals.WHATEVER)
1 parent 9d0ba47 commit 94ec702

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

src/StackExchange.Redis/Message.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -845,13 +845,13 @@ protected override void WriteImpl(PhysicalConnection physical)
845845
physical.WriteBulkString(_protocolVersion);
846846
if (!string.IsNullOrWhiteSpace(_password))
847847
{
848-
physical.WriteBulkString(RedisLiterals.AUTH);
848+
physical.WriteBulkString("AUTH"u8);
849849
physical.WriteBulkString(string.IsNullOrWhiteSpace(_username) ? RedisLiterals.@default : _username);
850850
physical.WriteBulkString(_password);
851851
}
852852
if (!string.IsNullOrWhiteSpace(_clientName))
853853
{
854-
physical.WriteBulkString(RedisLiterals.SETNAME);
854+
physical.WriteBulkString("SETNAME"u8);
855855
physical.WriteBulkString(_clientName);
856856
}
857857
}
@@ -1733,10 +1733,10 @@ protected override void WriteImpl(PhysicalConnection physical)
17331733
switch (when)
17341734
{
17351735
case When.Exists:
1736-
physical.WriteBulkString(RedisLiterals.XX);
1736+
physical.WriteBulkString("XX"u8);
17371737
break;
17381738
case When.NotExists:
1739-
physical.WriteBulkString(RedisLiterals.NX);
1739+
physical.WriteBulkString("NX"u8);
17401740
break;
17411741
}
17421742
}

src/StackExchange.Redis/RedisDatabase.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1333,8 +1333,8 @@ protected override void WriteImpl(PhysicalConnection physical)
13331333
physical.Write(Key);
13341334
physical.WriteBulkString(toDatabase);
13351335
physical.WriteBulkString(timeoutMilliseconds);
1336-
if (isCopy) physical.WriteBulkString(RedisLiterals.COPY);
1337-
if (isReplace) physical.WriteBulkString(RedisLiterals.REPLACE);
1336+
if (isCopy) physical.WriteBulkString("COPY"u8);
1337+
if (isReplace) physical.WriteBulkString("REPLACE"u8);
13381338
}
13391339

13401340
public override int ArgCount
@@ -5353,7 +5353,7 @@ public ScriptLoadMessage(CommandFlags flags, string script)
53535353
protected override void WriteImpl(PhysicalConnection physical)
53545354
{
53555355
physical.WriteHeader(Command, 2);
5356-
physical.WriteBulkString(RedisLiterals.LOAD);
5356+
physical.WriteBulkString("LOAD"u8);
53575357
physical.WriteBulkString((RedisValue)Script);
53585358
}
53595359
public override int ArgCount => 2;

src/StackExchange.Redis/RedisLiterals.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ public static readonly RedisValue
6060
ANDOR = "ANDOR",
6161
ANY = "ANY",
6262
ASC = "ASC",
63-
AUTH = "AUTH",
6463
BEFORE = "BEFORE",
6564
BIT = "BIT",
6665
BY = "BY",
@@ -69,7 +68,6 @@ public static readonly RedisValue
6968
BYTE = "BYTE",
7069
CH = "CH",
7170
CHANNELS = "CHANNELS",
72-
COPY = "COPY",
7371
COUNT = "COUNT",
7472
DB = "DB",
7573
@default = "default",
@@ -105,7 +103,6 @@ public static readonly RedisValue
105103
lib_ver = "lib-ver",
106104
LIMIT = "LIMIT",
107105
LIST = "LIST",
108-
LOAD = "LOAD",
109106
LT = "LT",
110107
MATCH = "MATCH",
111108
MALLOC_STATS = "MALLOC-STATS",

0 commit comments

Comments
 (0)