Skip to content

Commit d60d987

Browse files
authored
add type-forward on IsExternalInit (#2621)
* add type-forward on IsExternalInit to resolve #2619
1 parent 1943d95 commit d60d987

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<!-- Packages only used in the solution, upgrade at will -->
1212
<PackageVersion Include="BenchmarkDotNet" Version="0.13.1" />
1313
<PackageVersion Include="GitHubActionsTestLogger" Version="2.0.0-alpha" />
14-
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4-beta1.22362.3" />
14+
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.4" />
1515
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.0" />
1616
<PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" />
1717
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />

docs/ReleaseNotes.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ Current package versions:
77
| [![StackExchange.Redis](https://img.shields.io/nuget/v/StackExchange.Redis.svg)](https://www.nuget.org/packages/StackExchange.Redis/) | [![StackExchange.Redis](https://img.shields.io/nuget/vpre/StackExchange.Redis.svg)](https://www.nuget.org/packages/StackExchange.Redis/) | [![StackExchange.Redis MyGet](https://img.shields.io/myget/stackoverflow/vpre/StackExchange.Redis.svg)](https://www.myget.org/feed/stackoverflow/package/nuget/StackExchange.Redis) |
88

99
## Unreleased
10-
No unreleased changes yet!
10+
11+
- Fix [#2619](https://github.com/StackExchange/StackExchange.Redis/issues/2619): Type-forward `IsExternalInit` to support down-level TFMs ([#2621 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2621))
1112

1213
## 2.7.10
1314

src/StackExchange.Redis/Hacks.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
#if !NET5_0_OR_GREATER
2-
1+
#if NET5_0_OR_GREATER
2+
// context: https://github.com/StackExchange/StackExchange.Redis/issues/2619
3+
[assembly: System.Runtime.CompilerServices.TypeForwardedTo(typeof(System.Runtime.CompilerServices.IsExternalInit))]
4+
#else
35
// To support { get; init; } properties
46
using System.ComponentModel;
57

@@ -8,5 +10,4 @@ namespace System.Runtime.CompilerServices
810
[EditorBrowsable(EditorBrowsableState.Never)]
911
internal static class IsExternalInit { }
1012
}
11-
1213
#endif
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
StackExchange.Redis.ConfigurationOptions.SslClientAuthenticationOptions.get -> System.Func<string!, System.Net.Security.SslClientAuthenticationOptions!>?
2+
StackExchange.Redis.ConfigurationOptions.SslClientAuthenticationOptions.set -> void
3+
System.Runtime.CompilerServices.IsExternalInit (forwarded, contained in System.Runtime)

src/StackExchange.Redis/StackExchange.Redis.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<AdditionalFiles Include="PublicAPI/PublicAPI.Shipped.txt" />
3636
<AdditionalFiles Include="PublicAPI/PublicAPI.Unshipped.txt" />
3737
<!-- APIs for netcoreapp3.1+ -->
38-
<AdditionalFiles Include="PublicAPI/netcoreapp3.1/PublicAPI.Shipped.txt" Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'" />
38+
<AdditionalFiles Include="PublicAPI/$(TargetFramework)/PublicAPI.Shipped.txt" Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'" />
3939
</ItemGroup>
4040

4141
<ItemGroup>

0 commit comments

Comments
 (0)