Skip to content

Commit 05b650b

Browse files
authored
Merge pull request #548 from StackExchange/feature/one-pixel-positioning
Add 1 pixel position coordinate classes
2 parents e0d3df7 + 6fda89c commit 05b650b

File tree

3 files changed

+38
-32
lines changed

3 files changed

+38
-32
lines changed

docs/_data/spacing.json

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,37 +102,37 @@
102102
"position": [
103103
{
104104
"prefix": "t",
105-
"values": "0, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
105+
"values": "0, 1, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
106106
},
107107
{
108108
"prefix": "r",
109-
"values": "0, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
109+
"values": "0, 1, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
110110
},
111111
{
112112
"prefix": "l",
113-
"values": "0, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
113+
"values": "0, 1, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
114114
},
115115
{
116116
"prefix": "b",
117-
"values": "0, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
117+
"values": "0, 1, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
118118
}
119119
],
120120
"negative-position": [
121121
{
122122
"prefix": "tn",
123-
"values": "2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
123+
"values": "1, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
124124
},
125125
{
126126
"prefix": "rn",
127-
"values": "2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
127+
"values": "1, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
128128
},
129129
{
130130
"prefix": "ln",
131-
"values": "2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
131+
"values": "1, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
132132
},
133133
{
134134
"prefix": "bn",
135-
"values": "2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
135+
"values": "1, 2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 50, 100"
136136
}
137137
],
138138
"margin-definitions": [
@@ -366,6 +366,10 @@
366366
"term": 0,
367367
"define": "0;"
368368
},
369+
{
370+
"term": 1,
371+
"define": "1px;"
372+
},
369373
{
370374
"term": 2,
371375
"define": "2px;"

docs/product/base/position.html

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,10 @@
6868
</thead>
6969
<tbody>
7070
{% for space in spacing.position-definitions %}
71-
<tr>
72-
<th scope="row">{{ space.term }}</th>
73-
<td>{{ space.define }}</td>
74-
</tr>
71+
<tr>
72+
<th scope="row">{{ space.term }}</th>
73+
<td>{{ space.define }}</td>
74+
</tr>
7575
{% endfor %}
7676
</tbody>
7777
</table>
@@ -115,6 +115,7 @@
115115
<tr>
116116
<th scope="col">Prefix</th>
117117
<th scope="col" class="ta-center ff-mono">0</th>
118+
<th scope="col" class="ta-center ff-mono">1px</th>
118119
<th scope="col" class="ta-center ff-mono">2px</th>
119120
<th scope="col" class="ta-center ff-mono">4px</th>
120121
<th scope="col" class="ta-center ff-mono">6px</th>
@@ -132,14 +133,14 @@
132133
</tr>
133134
</thead>
134135
<tbody>
135-
{% for class in spacing.position %}
136-
{% assign prefix-value = class.values | split: ", " %}
137-
<tr>
138-
<th scope="row" class="-cell1">{{ class.prefix }}</th>
139-
{% for values in prefix-value %}
140-
<td class="ta-center"><code class="fs1">.{{ class.prefix }}{{ values }}</code></td>
141-
{% endfor %}
142-
</tr>
136+
{% for class in spacing.position %}
137+
{% assign prefix-value = class.values | split: ", " %}
138+
<tr>
139+
<th scope="row" class="-cell1">{{ class.prefix }}</th>
140+
{% for values in prefix-value %}
141+
<td class="ta-center"><code class="fs1">.{{ class.prefix }}{{ values }}</code></td>
142+
{% endfor %}
143+
</tr>
143144
{% endfor %}
144145
</tbody>
145146
</table>
@@ -151,6 +152,7 @@
151152
<thead>
152153
<tr>
153154
<th scope="col">Prefix</th>
155+
<th scope="col" class="ta-center ff-mono">-1px</th>
154156
<th scope="col" class="ta-center ff-mono">-2px</th>
155157
<th scope="col" class="ta-center ff-mono">-4px</th>
156158
<th scope="col" class="ta-center ff-mono">-6px</th>
@@ -168,14 +170,14 @@
168170
</tr>
169171
</thead>
170172
<tbody>
171-
{% for class in spacing.negative-position %}
172-
{% assign prefix-value = class.values | split: ", " %}
173-
<tr>
174-
<th scope="row" class="-cell1">{{ class.prefix }}</th>
175-
{% for values in prefix-value %}
176-
<td class="ta-center"><code class="fs1">.{{ class.prefix }}{{ values }}</code></td>
177-
{% endfor %}
178-
</tr>
173+
{% for class in spacing.negative-position %}
174+
{% assign prefix-value = class.values | split: ", " %}
175+
<tr>
176+
<th scope="row" class="-cell1">{{ class.prefix }}</th>
177+
{% for values in prefix-value %}
178+
<td class="ta-center"><code class="fs1">.{{ class.prefix }}{{ values }}</code></td>
179+
{% endfor %}
180+
</tr>
179181
{% endfor %}
180182
</tbody>
181183
</table>

lib/css/atomic/_stacks-spacing.less

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,23 +140,23 @@
140140
// $$ Top
141141
#stacks-internals #build-classes(
142142
'.t', { .template(@value) { top: @value !important; } },
143-
0 @su2 -@su2 @su4 -@su4 @su6 -@su6 @su8 -@su8 @su12 -@su12 @su16 -@su16 @su24 -@su24 @su32 -@su32 @su48 -@su48 @su64 -@su64 @su96 -@su96 @su128 -@su128 50% -50% 100% -100%
143+
0 1px -1px @su2 -@su2 @su4 -@su4 @su6 -@su6 @su8 -@su8 @su12 -@su12 @su16 -@su16 @su24 -@su24 @su32 -@su32 @su48 -@su48 @su64 -@su64 @su96 -@su96 @su128 -@su128 50% -50% 100% -100%
144144
);
145145

146146
// $$ Right
147147
#stacks-internals #build-classes(
148148
'.r', { .template(@value) { right: @value !important; } },
149-
0 @su2 -@su2 @su4 -@su4 @su6 -@su6 @su8 -@su8 @su12 -@su12 @su16 -@su16 @su24 -@su24 @su32 -@su32 @su48 -@su48 @su64 -@su64 @su96 -@su96 @su128 -@su128 50% -50% 100% -100%
149+
0 1px -1px @su2 -@su2 @su4 -@su4 @su6 -@su6 @su8 -@su8 @su12 -@su12 @su16 -@su16 @su24 -@su24 @su32 -@su32 @su48 -@su48 @su64 -@su64 @su96 -@su96 @su128 -@su128 50% -50% 100% -100%
150150
);
151151

152152
// $$ Bottom
153153
#stacks-internals #build-classes(
154154
'.b', { .template(@value) { bottom: @value !important; } },
155-
0 @su2 -@su2 @su4 -@su4 @su6 -@su6 @su8 -@su8 @su12 -@su12 @su16 -@su16 @su24 -@su24 @su32 -@su32 @su48 -@su48 @su64 -@su64 @su96 -@su96 @su128 -@su128 50% -50% 100% -100%
155+
0 1px -1px @su2 -@su2 @su4 -@su4 @su6 -@su6 @su8 -@su8 @su12 -@su12 @su16 -@su16 @su24 -@su24 @su32 -@su32 @su48 -@su48 @su64 -@su64 @su96 -@su96 @su128 -@su128 50% -50% 100% -100%
156156
);
157157

158158
// $$ Left
159159
#stacks-internals #build-classes(
160160
'.l', { .template(@value) { left: @value !important; } },
161-
0 @su2 -@su2 @su4 -@su4 @su6 -@su6 @su8 -@su8 @su12 -@su12 @su16 -@su16 @su24 -@su24 @su32 -@su32 @su48 -@su48 @su64 -@su64 @su96 -@su96 @su128 -@su128 50% -50% 100% -100%
161+
0 1px -1px @su2 -@su2 @su4 -@su4 @su6 -@su6 @su8 -@su8 @su12 -@su12 @su16 -@su16 @su24 -@su24 @su32 -@su32 @su48 -@su48 @su64 -@su64 @su96 -@su96 @su128 -@su128 50% -50% 100% -100%
162162
);

0 commit comments

Comments
 (0)