chore(popover): replace close icon (#2057)

* chore(popover): replace close icon

* Use cross, not cross16

* Changeset

Author: dancormier

.changeset/silly-spiders-swim.md

@@ -0,0 +1,6 @@
+---
+"@stackoverflow/stacks": patch
+"@stackoverflow/stacks-svelte": patch
+---
+
+Change popover close icon to Cross

packages/stacks-classic/lib/components/popover/popover.less

@@ -31,7 +31,7 @@
         float: right; // Use floats for title wrapping
         top: calc(var(--su8) * -1); // Compensate for s-popover's padding
         right: calc(var(--su8) * -1); // Compensate for s-popover's padding
-        padding: var(--su8) !important;
+        padding: var(--su6) !important;
     }
 
     & &--content {

packages/stacks-docs/product/components/popovers.html

@@ -283,7 +283,7 @@
     <div id="popover-example" class="s-popover is-visible" role="menu">
         <button class="s-popover--close s-btn s-btn__muted" aria-label="Close"
             data-action="s-popover#toggle">
-            @Svg.ClearSm
+            @Svg.Cross
         </button>
         <div class="s-popover--content">
             …
@@ -293,7 +293,7 @@
 {% endhighlight %}
         <div class="stacks-preview--example bg-black-100">
             <div class="s-popover ps-relative is-visible">
-                <button class="s-popover--close s-btn s-btn__muted" aria-label="Close">{% icon "ClearSm" %}</button>
+                <button class="s-popover--close s-btn s-btn__muted" aria-label="Close">{% icon "Cross" %}</button>
                 <div class="s-popover--content">
                     <p class="mb0">Dismissible persistent popover presented with a close button</p>
                 </div>

packages/stacks-svelte/src/components/Popover/PopoverCloseButton.svelte

@@ -1,6 +1,6 @@
 <script lang="ts">
     import Icon from "../Icon/Icon.svelte";
-    import { IconClear } from "@stackoverflow/stacks-icons-legacy/icons";
+    import { IconCross } from "@stackoverflow/stacks-icons/icons";
     import { usePopoverContext } from "./Popover.svelte";
 
     interface Props {
@@ -34,5 +34,5 @@
     type="button"
     onclick={handleClick}
 >
-    <Icon src={IconClear} />
+    <Icon src={IconCross} />
 </button>