-
Notifications
You must be signed in to change notification settings - Fork 100
feat(badges): first batch of design updates for the badge component as part of SHINE #2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
|
Thanks for the discussion @CGuindon & @dancormier! I tweaked the Bling component as we discussed based on the designs:
I also added more size examples to Stacks Docs now: https://deploy-preview-2051--stacks.netlify.app/product/components/badges/#badge-sizes Note: I find testing the different variants easier from the Svelte component side. |
|
(not fully related) I noticed if you inspect the example of |
CGuindon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all works! Any issues I'm seeing are not related to this PR/work (issues with colors). so I'm going to approve this and move on to the next!
|
@mukunku @dancormier Should we expose the Svelte component to consumers as part of this update? If we are showing it in storybook we probably should exposing it in the |
dancormier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on @mukunku and thanks for the bling fixes ❤️ Since many variants are yet to be designed (I saw a banner in the Figma saying "Variants below will be done separately — need additional mock ups first"), I took this opportunity to remove them from the Less for now and do a refactor (see 4132cad).
I agree w/ @giamir that we should expose the Svelte component as well to consumers. It'll need a some updates (most notably, I think "award" can be merged into "variant") but I think the changes won't be too crazy. Let me know if you'd like help with that or if you want any opinions on the API.
|
Hey @dancormier , can you kindly take a look at the PR again when you get the chance? As discussed I made the following changes:
I also exposed the Badge Svelte component in index.ts as mentioned by Giamir. |




Summary
This is for SPARK-59 and updates the Badge component styles based on the new designs.
This PR should only be merged after #2013 is merged as it was branched off of that branch.
Changes
The PR does the following:
xssize and replaces it withlgWhat is NOT in scope for this PR:
Breaking Changes
xssize was removeds-award-blingclass was renamed tos-bling(used in some badge templates)How to Test
Checkout the new styles in Stacks Docs and Stacks Svelte:
How to Review
I recommend excluding all

.icofiles in the GitHub file diff for a nice reviewing experience: