bug(split horizon): Domains with split horizons not working (#3895)

Fixes #3894

# Issue

* Split horizon DNS broke in 4.28.0
* Insufficient automated testing to detect this in the future 

# Resolution

* domain.PostProcess() was called twice. The first time the tag was
properly parsed, removing the tag from DomainConfig.Name and putting it
in DomainConfig.Tag. The second time DomainConfig.Name no longer had the
tag and .Tag was set to "".
* The JSON output of DomainConfig doesn't output .UniqueName. If it had,
this bug would have been noticed prior to release. Test updated to
include that field.

Author: tlimoncelli

commands/ppreviewPush_test.go

@@ -22,6 +22,7 @@ func Test_whichZonesToProcess(t *testing.T) {
 		dcTaggedEmpty,
 	}
 
+	// This is needed since we aren't calling js.ExecuteJavaScript().
 	for _, dc := range allDC {
 		dc.PostProcess()
 	}

commands/printIR.go

@@ -129,11 +129,6 @@ func ExecuteDSL(args ExecuteDSLArgs) (*models.DNSConfig, error) {
 		return nil, fmt.Errorf("executing %s: %w", args.JSFile, err)
 	}
 
-	err = dnsConfig.PostProcess()
-	if err != nil {
-		return nil, err
-	}
-
 	return dnsConfig, nil
 }
 

models/domain.go

@@ -24,7 +24,7 @@ type DomainConfig struct {
 	NameUnicode string `json:"-"`    // name in Unicode format
 
 	Tag        string `json:"tag,omitempty"` // Split horizon tag.
-	UniqueName string `json:"-"`             // .Name + "!" + .Tag
+	UniqueName string `json:"uniquename"`    // .Name + "!" + .Tag (no !tag added if tag is "")
 
 	RegistrarName    string         `json:"registrar"`
 	DNSProviderNames map[string]int `json:"dnsProviders"`

pkg/js/parse_tests/001-basic.json

@@ -23,7 +23,8 @@
           "type": "A"
         }
       ],
-      "registrar": "Third-Party"
+      "registrar": "Third-Party",
+      "uniquename": "foo.com"
     }
   ],
   "registrars": [

pkg/js/parse_tests/002-ttl.json

@@ -23,7 +23,8 @@
           "type": "A"
         }
       ],
-      "registrar": "Third-Party"
+      "registrar": "Third-Party",
+      "uniquename": "foo.com"
     }
   ],
   "registrars": [

pkg/js/parse_tests/003-meta.json

@@ -19,7 +19,8 @@
           "type": "A"
         }
       ],
-      "registrar": "Cloudflare"
+      "registrar": "Cloudflare",
+      "uniquename": "foo.com"
     }
   ],
   "registrars": [

pkg/js/parse_tests/004-ips.json

@@ -37,7 +37,8 @@
           "type": "A"
         }
       ],
-      "registrar": "Third-Party"
+      "registrar": "Third-Party",
+      "uniquename": "foo.com"
     }
   ],
   "registrars": [

pkg/js/parse_tests/005-ignored-records.json

@@ -9,6 +9,7 @@
       "name": "foo.com",
       "records": [],
       "registrar": "none",
+      "uniquename": "foo.com",
       "unmanaged": [
         {
           "label_pattern": "testignore",
@@ -60,6 +61,7 @@
       "name": "diff2.com",
       "records": [],
       "registrar": "none",
+      "uniquename": "diff2.com",
       "unmanaged": [
         {
           "label_pattern": "mylabel",

pkg/js/parse_tests/006-transforms.json

@@ -46,7 +46,8 @@
           "type": "A"
         }
       ],
-      "registrar": "Third-Party"
+      "registrar": "Third-Party",
+      "uniquename": "foo.com"
     }
   ],
   "registrars": [

pkg/js/parse_tests/007-importTransformTTL.json

@@ -23,7 +23,8 @@
           "type": "A"
         }
       ],
-      "registrar": "reg"
+      "registrar": "reg",
+      "uniquename": "foo1.com"
     },
     {
       "dnsProviders": {},
@@ -47,7 +48,8 @@
           "type": "A"
         }
       ],
-      "registrar": "reg"
+      "registrar": "reg",
+      "uniquename": "inny"
     },
     {
       "dnsProviders": {},
@@ -71,7 +73,8 @@
           "type": "A"
         }
       ],
-      "registrar": "reg"
+      "registrar": "reg",
+      "uniquename": "com.inny"
     }
   ],
   "registrars": []