chore: remove typos CLI tooling #265
Conversation
Remove typos configuration and pre-push hook integration: - Delete typos.toml configuration file - Remove typos check from lefthook.yaml pre-push jobs The typos tool is no longer needed for this project's workflow.
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR removes the typos CLI tooling from the project by deleting the typos configuration file and removing the typos check from the pre-push hook. However, the removal is incomplete as references to typos remain in other parts of the codebase.
Key changes:
- Removed
typos.tomlconfiguration file containing locale settings, ignore patterns, and file exclusions - Removed typos job from the
lefthook.yamlpre-push hook
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| typos.toml | Deleted the entire typos configuration file with its locale, ignore patterns, and file exclusions |
| lefthook.yaml | Removed the typos job from the pre-push hook, leaving only the knip job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pre-push: | ||
| jobs: | ||
| - name: typos | ||
| run: typos --config typos.toml | ||
| - name: knip | ||
| run: pnpm run lint:knip |
There was a problem hiding this comment.
The typos job has been removed from the pre-push hook, but the typos tool is still referenced in other parts of the project. The GitHub Actions CI workflow (.github/workflows/ci.yaml) still contains a typos job (lines 33-43) that runs "nix develop --command typos ." which will fail without the typos.toml configuration file. Additionally, flake.nix still includes typos and typos-lsp packages in the development environment (lines 30-31). For a complete removal of the typos tooling, these references should also be removed.
The typos CLI tooling is being removed from the project. This removes the corresponding CI job that was checking for typos.
Remove typos configuration and pre-push hook integration from the project.
Changes:
The typos tool is no longer needed for this project's workflow.
Summary by cubic
Removed the typos CLI to streamline both CI and pre-push workflows and reduce checks. Deleted typos.toml, removed the typos job from lefthook.yaml, and dropped the typos job from .github/workflows/ci.yaml.
Written for commit 0b0cd6a. Summary will update automatically on new commits.