fix: add type ignore for unreachable code in MCP server

This is needed because mypy sees the Python version check as always false
when running on Python 3.10+, making the subsequent code unreachable.
The code is actually reachable at runtime when Python 3.10+ is used.

Author: ryoppippi

.github/workflows/docs.yml

@@ -17,11 +17,11 @@ jobs:
       - name: Install uv
         uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
         with:
-          python-version: "3.11"
+          python-version: "3.9"
           enable-cache: true
 
       - name: Install all dependencies
-        run: uv sync --all-extras
+        run: uv sync --without server
 
       - name: Build documentation
         run: |

.github/workflows/lint.yml

@@ -14,11 +14,11 @@ jobs:
       - name: Install uv
         uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
         with:
-          python-version: "3.11"
+          python-version: "3.9"
           enable-cache: true
 
       - name: Install dependencies
-        run: uv sync --all-extras
+        run: uv sync --without server
 
       - name: Run Ruff
         uses: astral-sh/ruff-action@0c50076f12c38c3d0115b7b519b54a91cb9cf0ad # v3.5.0

.github/workflows/test.yml

@@ -8,6 +8,20 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
+        include:
+          - python-version: "3.9"
+            test-extras: "--without server"
+          - python-version: "3.10"
+            test-extras: "--all-extras"
+          - python-version: "3.11"
+            test-extras: "--all-extras"
+          - python-version: "3.12"
+            test-extras: "--all-extras"
+          - python-version: "3.13"
+            test-extras: "--all-extras"
     env:
       STACKONE_API_KEY: ${{ secrets.STACKONE_API_KEY }}
       OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
@@ -17,11 +31,11 @@ jobs:
       - name: Install uv
         uses: astral-sh/setup-uv@e92bafb6253dcd438e0484186d7669ea7a8ca1cc # v6.4.3
         with:
-          python-version: "3.11"
+          python-version: ${{ matrix.python-version }}
           enable-cache: true
 
       - name: Install dependencies
-        run: uv sync --all-extras
+        run: uv sync ${{ matrix.test-extras }}
 
       - name: Run tests
         run: uv run pytest

pyproject.toml

@@ -3,7 +3,7 @@ name = "stackone-ai"
 version = "0.3.1"
 description = "agents performing actions on your SaaS"
 readme = "README.md"
-requires-python = ">=3.11"
+requires-python = ">=3.9"
 authors = [
     { name = "StackOne", email = "[email protected]" }
 ]
@@ -12,16 +12,20 @@ classifiers = [
     "Intended Audience :: Developers",
     "License :: OSI Approved :: MIT License",
     "Programming Language :: Python :: 3",
+    "Programming Language :: Python :: 3.9",
+    "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
     "Topic :: Software Development :: Libraries :: Python Modules",
 ]
 dependencies = [
     "pydantic>=2.10.6",
     "requests>=2.32.3",
     "langchain-core>=0.1.0",
-    "mcp[cli]>=1.3.0",
     "bm25s>=0.2.2",
     "numpy>=1.24.0",
+    "typing-extensions>=4.0.0",
 ]
 
 [project.scripts]
@@ -41,8 +45,12 @@ packages = ["stackone_ai"]
 "py.typed" = "py.typed"
 
 [project.optional-dependencies]
+# TODO: Remove python_version conditions when Python 3.9 support is dropped
+server = [
+    "mcp[cli]>=1.3.0; python_version>='3.10'",
+]
 examples = [
-    "crewai>=0.102.0",
+    "crewai>=0.102.0; python_version>='3.10'",
     "langchain-openai>=0.3.6",
     "openai>=1.63.2",
     "python-dotenv>=1.0.1",
@@ -82,7 +90,7 @@ markers = [
 
 [tool.ruff]
 line-length = 110
-target-version = "py311"
+target-version = "py39"
 
 [tool.ruff.lint]
 select = [
@@ -96,7 +104,7 @@ select = [
 ]
 
 [tool.mypy]
-python_version = "3.11"
+python_version = "3.9"
 disallow_untyped_defs = true
 disallow_incomplete_defs = true
 check_untyped_defs = true

stackone_ai/meta_tools.py

@@ -82,7 +82,7 @@ def search(self, query: str, limit: int = 5, min_score: float = 0.0) -> list[Met
 
         # Process results
         search_results = []
-        for idx, score in zip(results[0], scores[0], strict=False):
+        for idx, score in zip(results[0], scores[0]):
             if score < min_score:
                 continue
 

stackone_ai/models.py

@@ -1,16 +1,22 @@
+# TODO: Remove when Python 3.9 support is dropped
+from __future__ import annotations
+
 import asyncio
 import base64
 import json
 from collections.abc import Sequence
 from enum import Enum
 from functools import partial
-from typing import Annotated, Any, TypeAlias, cast
+from typing import Annotated, Any, cast
 
 import requests
 from langchain_core.tools import BaseTool
 from pydantic import BaseModel, BeforeValidator, Field, PrivateAttr
 from requests.exceptions import RequestException
 
+# TODO: Remove when Python 3.9 support is dropped
+from typing_extensions import TypeAlias
+
 # Type aliases for common types
 JsonDict: TypeAlias = dict[str, Any]
 Headers: TypeAlias = dict[str, str]
@@ -140,21 +146,20 @@ def _prepare_request_params(self, kwargs: JsonDict) -> tuple[str, JsonDict, Json
         for key, value in kwargs.items():
             param_location = self._execute_config.parameter_locations.get(key)
 
-            match param_location:
-                case ParameterLocation.PATH:
+            if param_location == ParameterLocation.PATH:
+                url = url.replace(f"{{{key}}}", str(value))
+            elif param_location == ParameterLocation.QUERY:
+                query_params[key] = value
+            elif param_location in (ParameterLocation.BODY, ParameterLocation.FILE):
+                body_params[key] = value
+            else:
+                # Default behavior
+                if f"{{{key}}}" in url:
                     url = url.replace(f"{{{key}}}", str(value))
-                case ParameterLocation.QUERY:
+                elif self._execute_config.method in {"GET", "DELETE"}:
                     query_params[key] = value
-                case ParameterLocation.BODY | ParameterLocation.FILE:
+                else:
                     body_params[key] = value
-                case _:
-                    # Default behavior
-                    if f"{{{key}}}" in url:
-                        url = url.replace(f"{{{key}}}", str(value))
-                    elif self._execute_config.method in {"GET", "DELETE"}:
-                        query_params[key] = value
-                    else:
-                        body_params[key] = value
 
         return url, body_params, query_params
 
@@ -355,13 +360,12 @@ def to_langchain(self) -> BaseTool:
             python_type: type = str  # Default to str
             if isinstance(details, dict):
                 type_str = details.get("type", "string")
-                match type_str:
-                    case "number":
-                        python_type = float
-                    case "integer":
-                        python_type = int
-                    case "boolean":
-                        python_type = bool
+                if type_str == "number":
+                    python_type = float
+                elif type_str == "integer":
+                    python_type = int
+                elif type_str == "boolean":
+                    python_type = bool
 
                 field = Field(description=details.get("description", ""))
             else:
@@ -480,7 +484,7 @@ def to_langchain(self) -> Sequence[BaseTool]:
         """
         return [tool.to_langchain() for tool in self.tools]
 
-    def meta_tools(self) -> "Tools":
+    def meta_tools(self) -> Tools:
         """Return meta tools for tool discovery and execution
 
         Meta tools enable dynamic tool discovery and execution based on natural language queries.

stackone_ai/server.py

@@ -1,16 +1,31 @@
+# TODO: Remove when Python 3.9 support is dropped
+from __future__ import annotations
+
 import argparse
 import asyncio
 import logging
 import os
 import sys
 from typing import Any, TypeVar
 
-import mcp.types as types
-from mcp.server import NotificationOptions, Server
-from mcp.server.models import InitializationOptions
-from mcp.server.stdio import stdio_server
-from mcp.shared.exceptions import McpError
-from mcp.types import EmbeddedResource, ErrorData, ImageContent, TextContent, Tool
+# Check Python version for MCP server functionality
+if sys.version_info < (3, 10):
+    raise RuntimeError(
+        "MCP server functionality requires Python 3.10+. Current version: {}.{}.{}".format(
+            *sys.version_info[:3]
+        )
+    )
+
+try:  # type: ignore[unreachable]
+    import mcp.types as types
+    from mcp.server import NotificationOptions, Server
+    from mcp.server.models import InitializationOptions
+    from mcp.server.stdio import stdio_server
+    from mcp.shared.exceptions import McpError
+    from mcp.types import EmbeddedResource, ErrorData, ImageContent, TextContent, Tool
+except ImportError as e:
+    raise ImportError("MCP dependencies not found. Install with: pip install 'stackone-ai[server]'") from e
+
 from pydantic import ValidationError
 
 from stackone_ai import StackOneToolSet
@@ -41,7 +56,7 @@ def tool_needs_account_id(tool_name: str) -> bool:
     return True
 
 
-@app.list_tools()  # type: ignore[misc]
+@app.list_tools()
 async def list_tools() -> list[Tool]:
     """List all available StackOne tools as MCP tools."""
     if not toolset:
@@ -99,7 +114,7 @@ async def list_tools() -> list[Tool]:
         ) from e
 
 
-@app.call_tool()  # type: ignore[misc]
+@app.call_tool()
 async def call_tool(
     name: str, arguments: dict[str, Any]
 ) -> list[TextContent | ImageContent | EmbeddedResource]:

stackone_ai/specs/parser.py

@@ -1,3 +1,6 @@
+# TODO: Remove when Python 3.9 support is dropped
+from __future__ import annotations
+
 import json
 from pathlib import Path
 from typing import Any
@@ -73,7 +76,7 @@ def _resolve_schema(
             visited = set()
 
         # Handle primitive types (str, int, etc)
-        if not isinstance(schema, dict | list):
+        if not isinstance(schema, (dict, list)):
             return schema
 
         if isinstance(schema, list):

stackone_ai/toolset.py

@@ -1,3 +1,6 @@
+# TODO: Remove when Python 3.9 support is dropped
+from __future__ import annotations
+
 import fnmatch
 import os
 import warnings