refactor(toolset): remove unused _matches_filter method

Remove the _matches_filter method from StackOneToolSet as it was
never called in the source code (only used in tests). This reduces
code complexity and improves test coverage percentage.

The existing _filter_by_provider and _filter_by_action methods
provide equivalent functionality and are actually used in fetch_tools.

Author: ryoppippi

stackone_ai/toolset.py

@@ -253,34 +253,6 @@ def __init__(
         self.base_url = base_url or DEFAULT_BASE_URL
         self._account_ids: list[str] = []
 
-    def _matches_filter(self, tool_name: str, filter_pattern: str | list[str]) -> bool:
-        """Check if a tool name matches the filter pattern
-
-        Args:
-            tool_name: Name of the tool to check
-            filter_pattern: String or list of glob patterns to match against.
-                          Patterns starting with ! are treated as negative matches.
-
-        Returns:
-            True if the tool name matches any positive pattern and no negative patterns,
-            False otherwise
-        """
-        patterns = [filter_pattern] if isinstance(filter_pattern, str) else filter_pattern
-
-        # Split into positive and negative patterns
-        positive_patterns = [p for p in patterns if not p.startswith("!")]
-        negative_patterns = [p[1:] for p in patterns if p.startswith("!")]
-
-        # If no positive patterns, treat as match all
-        matches_positive = (
-            any(fnmatch.fnmatch(tool_name, p) for p in positive_patterns) if positive_patterns else True
-        )
-
-        # If any negative pattern matches, exclude the tool
-        matches_negative = any(fnmatch.fnmatch(tool_name, p) for p in negative_patterns)
-
-        return matches_positive and not matches_negative
-
     def set_accounts(self, account_ids: list[str]) -> StackOneToolSet:
         """Set account IDs for filtering tools
 

tests/test_toolset.py

@@ -45,31 +45,3 @@ def test_filter_by_action():
     # Test non-matching patterns
     assert not toolset._filter_by_action("workday_list_contacts", ["*_list_employees"])
     assert not toolset._filter_by_action("bamboohr_create_job", ["hibob_*"])
-
-
-def test_matches_filter_positive_patterns():
-    """Test _matches_filter with positive patterns"""
-    toolset = StackOneToolSet(api_key="test_key")
-
-    # Single pattern
-    assert toolset._matches_filter("hibob_list_employees", "hibob_*")
-    assert toolset._matches_filter("bamboohr_create_job", "bamboohr_*")
-    assert not toolset._matches_filter("workday_contacts", "hibob_*")
-
-    # Multiple patterns (OR logic)
-    assert toolset._matches_filter("hibob_list_employees", ["hibob_*", "bamboohr_*"])
-    assert toolset._matches_filter("bamboohr_create_job", ["hibob_*", "bamboohr_*"])
-    assert not toolset._matches_filter("workday_contacts", ["hibob_*", "bamboohr_*"])
-
-
-def test_matches_filter_negative_patterns():
-    """Test _matches_filter with negative patterns (exclusion)"""
-    toolset = StackOneToolSet(api_key="test_key")
-
-    # Negative pattern
-    assert not toolset._matches_filter("hibob_delete_employee", ["hibob_*", "!hibob_delete_*"])
-    assert toolset._matches_filter("hibob_list_employees", ["hibob_*", "!hibob_delete_*"])
-
-    # Only negative patterns (should match everything not excluded)
-    assert not toolset._matches_filter("hibob_delete_employee", "!hibob_delete_*")
-    assert toolset._matches_filter("hibob_list_employees", "!hibob_delete_*")