Fix linting errors: line length, imports, and trailing whitespace

Author: NicolasBelissent

stackone_ai/implicit_feedback/analyzer.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
+from collections.abc import Sequence
 from dataclasses import dataclass
-from typing import Sequence
 
 from .data import ToolCallQualitySignals, ToolCallRecord
 
@@ -24,7 +24,10 @@ def __init__(self, config: BehaviorAnalyzerConfig | None = None) -> None:
     def analyze(self, history: Sequence[ToolCallRecord], current: ToolCallRecord) -> ToolCallQualitySignals:
         """Compute quality signals for a tool call."""
 
-        session_history = [call for call in history if call.session_id == current.session_id and call.call_id != current.call_id]
+        session_history = [
+            call for call in history
+            if call.session_id == current.session_id and call.call_id != current.call_id
+        ]
 
         quick_refinement, refinement_window = self._detect_quick_refinement(session_history, current)
         task_switch = self._detect_task_switch(session_history, current)

stackone_ai/implicit_feedback/data.py

@@ -1,8 +1,9 @@
 from __future__ import annotations
 
+from collections.abc import Mapping, MutableMapping
 from dataclasses import dataclass, field
 from datetime import datetime
-from typing import Any, Mapping, MutableMapping
+from typing import Any
 
 JsonDict = dict[str, Any]
 
@@ -35,7 +36,7 @@ class ToolCallRecord:
     quality: ToolCallQualitySignals | None = None
     metadata: Mapping[str, Any] = field(default_factory=dict)
 
-    def with_quality(self, quality: ToolCallQualitySignals) -> "ToolCallRecord":
+    def with_quality(self, quality: ToolCallQualitySignals) -> ToolCallRecord:
         """Return a new instance with computed quality signals."""
 
         data: MutableMapping[str, Any] = {

stackone_ai/implicit_feedback/langsmith_client.py

@@ -1,7 +1,8 @@
 from __future__ import annotations
 
 import logging
-from typing import Any, Mapping, Sequence
+from collections.abc import Mapping, Sequence
+from typing import Any
 
 try:  # pragma: no cover - exercised via integration tests
     from langsmith import Client

stackone_ai/implicit_feedback/manager.py

@@ -2,11 +2,11 @@
 
 import logging
 import os
-from collections.abc import Mapping, MutableMapping
+from collections.abc import Mapping, MutableMapping, Sequence
 from dataclasses import asdict
 from datetime import datetime
 from threading import Lock, Thread
-from typing import Any, Callable, ClassVar, Optional, Sequence
+from typing import Any, Callable, ClassVar, Optional
 from uuid import uuid4
 
 from .analyzer import BehaviorAnalyzer
@@ -146,7 +146,11 @@ def record_tool_call(
             status=status,
             params=sanitized_params,
             result=sanitized_result,
-            error=sanitized_error if isinstance(sanitized_error, str) else str(sanitized_error) if sanitized_error else None,
+            error=(
+                sanitized_error if isinstance(sanitized_error, str)
+                else str(sanitized_error) if sanitized_error
+                else None
+            ),
             metadata=safe_metadata if isinstance(safe_metadata, Mapping) else {},
         )
 

stackone_ai/implicit_feedback/session.py

@@ -2,7 +2,7 @@
 
 import logging
 from collections import defaultdict, deque
-from typing import Deque, Dict, Iterable
+from collections.abc import Iterable
 
 from .analyzer import BehaviorAnalyzer
 from .data import ImplicitFeedbackEvent, ToolCallRecord
@@ -22,7 +22,7 @@ def __init__(
         self._analyzer = analyzer
         self._max_history = max_history
         self._suitability_alert_threshold = suitability_alert_threshold
-        self._history: Dict[str, Deque[ToolCallRecord]] = defaultdict(deque)
+        self._history: dict[str, deque[ToolCallRecord]] = defaultdict(deque)
 
     def record_tool_call(self, record: ToolCallRecord) -> tuple[ToolCallRecord, list[ImplicitFeedbackEvent]]:
         """Record a tool execution and return derived events."""

tests/test_feedback.py

@@ -259,14 +259,13 @@ def test_live_feedback_submission() -> None:
 
 def test_implicit_feedback_integration() -> None:
     """Test implicit feedback system integration."""
+    from datetime import datetime, timedelta, timezone
+
     from stackone_ai.implicit_feedback import (
         BehaviorAnalyzer,
-        BehaviorAnalyzerConfig,
         ImplicitFeedbackManager,
         SessionTracker,
     )
-    from stackone_ai.implicit_feedback.data import ToolCallRecord
-    from datetime import datetime, timedelta, timezone
 
     class StubLangsmithClient:
         def __init__(self) -> None: