fix: resolve mypy errors

- Remove implicit feedback imports and unreachable code
- Fix execute method signature to match base class
- All mypy checks now pass

Author: NicolasBelissent

stackone_ai/feedback/tool.py

@@ -46,12 +46,15 @@ def validate_tool_names(cls, v: list[str]) -> list[str]:
 class FeedbackTool(StackOneTool):
     """Extended tool for collecting feedback with enhanced validation."""
 
-    def execute(self, arguments: str | JsonDict | None = None) -> JsonDict:
+    def execute(
+        self, arguments: str | JsonDict | None = None, *, options: JsonDict | None = None
+    ) -> JsonDict:
         """
         Execute the feedback tool with enhanced validation.
 
         Args:
             arguments: Tool arguments as string or dict
+            options: Execution options
 
         Returns:
             Response from the API
@@ -77,7 +80,7 @@ def execute(self, arguments: str | JsonDict | None = None) -> JsonDict:
             }
 
             # Use the parent execute method with validated arguments
-            return super().execute(validated_arguments)
+            return super().execute(validated_arguments, options=options)
 
         except json.JSONDecodeError as exc:
             raise StackOneError(f"Invalid JSON in arguments: {exc}") from exc

stackone_ai/models.py

@@ -221,12 +221,7 @@ def execute(
                 error_message = "Tool arguments must be a JSON object"
                 raise ValueError(error_message)
 
-            if options is not None and not isinstance(options, dict):
-                status = "error"
-                error_message = "options must be a dictionary if provided"
-                raise ValueError(error_message)
-
-            kwargs, feedback_options = self._split_feedback_options(parsed_arguments, options)
+            kwargs = parsed_arguments
             call_params = dict(kwargs)
 
             headers = self._prepare_headers()
@@ -290,25 +285,7 @@ def execute(
                     if key in {"feedback_session_id", "feedback_user_id"} and value is not None
                 }
 
-            try:
-                from .implicit_feedback import get_implicit_feedback_manager
-
-                manager = get_implicit_feedback_manager()
-                manager.record_tool_call(
-                    tool_name=self.name,
-                    start_time=start_time,
-                    end_time=end_time,
-                    status=status,
-                    params=call_params,
-                    result=result_payload,
-                    error=error_message,
-                    session_id=feedback_options.get("feedback_session_id"),
-                    user_id=feedback_options.get("feedback_user_id"),
-                    metadata=metadata,
-                    fire_and_forget=True,
-                )
-            except Exception as logging_exc:  # pragma: no cover - defensive logging
-                logger.warning("Failed to dispatch implicit feedback: %s", logging_exc, exc_info=True)
+            # Implicit feedback removed - just API calls
 
     def call(self, *args: Any, options: JsonDict | None = None, **kwargs: Any) -> JsonDict:
         """Call the tool with the given arguments