test(network): improve response assertions in network tests #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace partial assertions with complete response object comparisons and add HTTP status code verification for all mocked network requests. Changes: - Assert full response objects instead of checking individual keys - Add status code assertions (200/401) for all respx routes - Explicitly write out account_id values in multi-account tests - Store route references for error handling tests to verify status This makes test failures more explicit and easier to debug by showing exact response mismatches rather than partial field comparisons.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the test suite for network-related functionality by making test assertions more explicit and comprehensive. The changes replace partial field assertions with complete response object comparisons and add HTTP status code verification for all mocked network requests.
- Replaced partial assertions with complete response object comparisons for clearer test failures
- Added HTTP status code assertions (200/401) to verify correct HTTP behavior
- Explicitly defined expected response structures in multi-account tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/test_meta_tools.py |
Updated test_execute_tool_call to use complete response assertion and verify 200 status code |
tests/test_feedback.py |
Enhanced 6 test methods with complete response assertions and status code verification for both success (200) and error (401) scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why
Makes test failures more explicit and easier to debug by showing exact response mismatches rather than partial field comparisons. Status code assertions ensure we're testing the correct HTTP behaviour.
Files Changed
tests/test_feedback.py- 7 tests updatedtests/test_meta_tools.py- 1 test updatedSummary by cubic
Strengthens network tests by asserting whole response bodies and verifying HTTP status codes. Makes failures clearer and ensures we’re testing the right HTTP behavior.
Written for commit 3ba97f0. Summary will update automatically on new commits.