Skip to content

Commit 96f2053

Browse files
committed
Merge remote-tracking branch 'origin/master' into feat/nb37
# Conflicts: # CHANGES.md # pack.yaml
2 parents b0820b3 + 6f5c6a4 commit 96f2053

File tree

5 files changed

+63
-11
lines changed

5 files changed

+63
-11
lines changed

.github/CODEOWNERS

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# These owners will be the default owners for everything in
2+
# the repo. Unless a later match takes precedence, users and
3+
# teams which are put in owners will be requested for review
4+
# when someone opens a pull request.
5+
6+
# This is base configuration. These owners could review all
7+
# files in this repository.
8+
* @lampwins @abhi1693 @StackStorm-Exchange/tsc
9+
10+
# CI configuration files should be reviewed by specific owners
11+
# who are more responsible for ensuring the quality of this pack
12+
# or orchestrate StackStorm-Exchanges.
13+
.circleci/** @StackStorm-Exchange/tsc
14+
.github/** @StackStorm-Exchange/tsc

CHANGES.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,24 @@
11
# Change Log
22

3-
## 3.3.0
3+
## 3.4.0
44

55
- Updated spec as per v3.7.1
66

7-
## 3.2.0
7+
## 3.3.0
88

99
- Updated spec as per v3.6.9
1010

11+
## 3.2.0
12+
13+
- Update spec as per v3.5.9
14+
1115
## 3.1.0
1216

13-
- Updated spec as per v3.5.9
17+
- Updated spec as per v3.4.7
18+
19+
## 3.0.7
20+
21+
- Add @abhi1693 as code owner.
1422

1523
## 3.0.6
1624

@@ -94,4 +102,3 @@
94102

95103
## 0.1.0
96104
- First release
97-

README.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,3 +62,32 @@ http://<ip-address>:<port>/netbox/webhooks/
6262
```
6363
6464
**Note:** the sensor does not support HTTPS but this could be accomplished by fronting the sensor with Nginx/Apache/etc, which would terminate the SSL connection and then proxy the request to the sensor over HTTP.
65+
66+
# How to update the pack
67+
68+
The pack is auto generated from the NetBox OpenAPI (Swagger) spec file. To update the pack, follow these steps:
69+
70+
1. Create a virtual environment and install the required dependencies:
71+
```shell
72+
virtualenv -p python3 venv
73+
source venv/bin/activate
74+
pip install -r requirements.txt
75+
```
76+
77+
2. Change to `bin` directory and run the `generate.py` script:
78+
```shell
79+
cd bin
80+
python generate.py --url https://demo.netbox.dev
81+
```
82+
83+
3. Update the `CHANGES.md` file with the new version of NetBox that was used to generate the pack.
84+
4. Update the `pack.yaml` file with the new version of NetBox that was used to generate the pack.
85+
5. Commit the changes and create a pull request.
86+
6. Once the pull request is merged, a new version of the pack will be released to the StackStorm Exchange.
87+
88+
## Maintainers
89+
90+
Active pack maintainers with review & write repository access and expertise with Netbox:
91+
92+
- John Anderson <[email protected]> @lampwins
93+
- Abhimanyu Saharan <[email protected]> @abhi1693

bin/generate.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ def main():
225225
"""
226226
parser = argparse.ArgumentParser()
227227
parser.add_argument(
228-
'--host',
228+
'--url',
229229
type=str,
230230
default='https://demo.netbox.dev',
231231
help='NetBox hostname'
@@ -238,11 +238,11 @@ def main():
238238
)
239239

240240
args = parser.parse_args()
241-
host = str(args.host).rstrip('/')
241+
url = str(args.url).rstrip('/')
242242

243243
try:
244-
print(f'Connecting to {host}...')
245-
response = requests.get(f'{host}/api/schema?format=json', verify=args.skip_ssl)
244+
print(f'Connecting to {url}...')
245+
response = requests.get(f'{url}/api/schema?format=json', verify=args.skip_ssl)
246246
response.raise_for_status()
247247
spec = response.json()
248248
except requests.RequestException as e:

pack.yaml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@ keywords:
66
- networking
77
- ipam
88
- dcim
9-
version: 3.3.0
10-
author: John Anderson, Jefferson White
11-
9+
version: 3.4.0
1210
python_versions:
1311
- "3"
12+
author: John Anderson, Jefferson White
13+
14+
contributors:
15+
- Abhimanyu Saharan <[email protected]>

0 commit comments

Comments
 (0)