Skip to content

Commit 6efedb5

Browse files
committed
Adjust tests for new return type
vault.delete_policy() and vault.set_policy() both returned None, but those methods are deprecated. Their replacements return the requests.Response object instead (204 responses in both cases).
1 parent 735ed94 commit 6efedb5

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

tests/test_action_delete_policy.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from requests import Response
2+
13
from delete_policy import VaultPolicyDeleteAction
24
from tests.vault_action_tests_base import VaultActionTestCase
35

@@ -12,7 +14,7 @@ def test_method(self):
1214
# test
1315
action = self.get_action_instance(config=self.dummy_pack_config)
1416
action_result = action.run(name="stanley")
15-
self.assertIsNone(action_result)
17+
self.assertIsInstance(action_result, Response)
1618

1719
result = self.client.get_policy("stanley")
1820
self.assertIsNone(result)

tests/test_action_set_policy.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from requests import Response
2+
13
from set_policy import VaultPolicySetAction
24
from tests.vault_action_tests_base import VaultActionTestCase
35

@@ -18,7 +20,7 @@ def test_method(self):
1820
name="stanley",
1921
rules=rules_text,
2022
)
21-
self.assertIsNone(action_result)
23+
self.assertIsInstance(action_result, Response)
2224

2325
result = self.client.get_policy("stanley")
2426
self.assertEqual(result, rules_text)

0 commit comments

Comments
 (0)