Merge pull request #273 from ruriky/fix_pack_install

Use column "ref" when checking already installed packs.

Author: nmaludy

CHANGELOG.md

@@ -23,6 +23,10 @@
   (Enhancement)
   Contributed by @nmaludy
 
+- Already installed packs are now recognized by their configured "ref" variable instead of "name"
+  (Enhancement)
+  Contributed by @ruriky
+
 ## 1.4.0 (Feb 13, 2019)
 
 - Added new tasks to communicate with the StackStorm CLI. The naming standard and parameters

lib/puppet/provider/st2_pack/default.rb

@@ -30,7 +30,7 @@ def exists?
 
   def list_installed_packs
     token = st2_authenticate
-    output = exec_st2('pack', 'list', '-a', 'name', '-j', '-t', token)
+    output = exec_st2('pack', 'list', '-a', 'ref', '-j', '-t', token)
     parse_output_json(output)
   end
 
@@ -39,7 +39,7 @@ def parse_output_json(raw)
     result = []
     if raw && !raw.empty?
       pack_list = JSON.parse(raw)
-      result = pack_list.map { |pack| pack['name'] }
+      result = pack_list.map { |pack| pack['ref'] }
       debug("Installed packs: #{result}")
     end
     result

spec/unit/puppet/provider/st2_pack/default_spec.rb

@@ -87,10 +87,10 @@
                                                   '-p', 'st2_password')
                                             .and_return('token')
       expect(provider).to receive(:exec_st2).with('pack', 'list',
-                                                  '-a', 'name',
+                                                  '-a', 'ref',
                                                   '-j',
                                                   '-t', 'token')
-                                            .and_return('[{"name": "pack1"}, {"name": "pack2"}]')
+                                            .and_return('[{"ref": "pack1"}, {"ref": "pack2"}]')
       expect(provider.list_installed_packs).to eq ['pack1', 'pack2']
     end
   end
@@ -105,7 +105,7 @@
     end
 
     it 'extracts pack names from a JSON string' do
-      expect(provider.parse_output_json('[{"name": "core"}, {"name": "examples"}]')).to eq ['core', 'examples']
+      expect(provider.parse_output_json('[{"ref": "core"}, {"ref": "examples"}]')).to eq ['core', 'examples']
     end
   end