fix test assertion

cognifloyd · cognifloyd · commit 3ce6f9a8bea5 · 2024-09-20T21:05:37.000-05:00
diff --git a/st2common/tests/unit/test_db.py b/st2common/tests/unit/test_db.py
@@ -331,7 +331,7 @@ def test_get_tls_kwargs(self):
             },
         )
 
-        # 7. tls_allow_invalid_certificates provided
+        # 7. tls_allow_invalid_certificates provided (does not implicitly enable tls)
         for allow_invalid in (True, False):
             tls_kwargs = _get_tls_kwargs(tls_allow_invalid_certificates=allow_invalid)
             self.assertEqual(
@@ -351,9 +351,8 @@ def test_get_tls_kwargs(self):
                 self.assertEqual(
                     tls_kwargs,
                     {
-                        "tls": True,
+                        "tls": False,
                         "tlsAllowInvalidCertificates": allow_invalid,
-                        "tlsAllowInvalidHostnames": False,
                     },
                 )
 

Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ def test_get_tls_kwargs(self):`
`331`	`331`	`},`
`332`	`332`	`)`
`333`	`333`
`334`		`- # 7. tls_allow_invalid_certificates provided`
	`334`	`+ # 7. tls_allow_invalid_certificates provided (does not implicitly enable tls)`
`335`	`335`	`for allow_invalid in (True, False):`
`336`	`336`	`tls_kwargs = _get_tls_kwargs(tls_allow_invalid_certificates=allow_invalid)`
`337`	`337`	`self.assertEqual(`
`@@ -351,9 +351,8 @@ def test_get_tls_kwargs(self):`
`351`	`351`	`self.assertEqual(`
`352`	`352`	`tls_kwargs,`
`353`	`353`	`{`
`354`		`- "tls": True,`
	`354`	`+ "tls": False,`
`355`	`355`	`"tlsAllowInvalidCertificates": allow_invalid,`
`356`		`- "tlsAllowInvalidHostnames": False,`
`357`	`356`	`},`
`358`	`357`	`)`
`359`	`358`