Merge pull request #196 from StackStorm/remove-python3-skips

Remove code to skip Python 3 tests on ST2 < 3.0.1

Author: blag

cli/test_pack_python3.bats

@@ -1,22 +1,6 @@
 load '../test_helpers/bats-support/load'
 load '../test_helpers/bats-assert/load'
 
-skip_tests_if_st2_le_v3() {
-    # Utility function which skips tests if st2 is v3.0.0 or below. The py3 tests
-    # here require the fix https://github.com/StackStorm/st2/pull/4674 that will
-    # not be released until v3.0.1.
-
-    ST2_VER=$(st2 --version 2>&1)
-    ST2_VER=$(echo ${ST2_VER} | cut -d',' -f1)
-    ST2_VER=$(echo ${ST2_VER} | cut -d' ' -f2)
-    ST2_VER=$(echo ${ST2_VER} | sed -e "s/dev/.0/g")
-    ST2_VER=$(echo ${ST2_VER//.})
-
-    if [[ "${ST2_VER}" -le "300" ]]; then
-        skip "Python 3 imports are broken on StackStorm < 3.0.1, skipping tests"
-    fi
-}
-
 skip_tests_if_python3_is_not_available_or_if_already_running_under_python3() {
 	# Utility function which skips tests if python3 binary is not available on the system or if
 	# StackStorm components are already running under Python 3 (e.g. Ubuntu Xenial)
@@ -32,7 +16,6 @@ skip_tests_if_python3_is_not_available_or_if_already_running_under_python3() {
 }
 
 @test "SETUP: Install and register examples pack" {
-	skip_tests_if_st2_le_v3
 	skip_tests_if_python3_is_not_available_or_if_already_running_under_python3
 
 	if [[ ! -d /opt/stackstorm/packs/examples ]]; then
@@ -49,7 +32,6 @@ skip_tests_if_python3_is_not_available_or_if_already_running_under_python3() {
 }
 
 @test "packs.setup_virtualenv without python3 flags works and defaults to Python 2" {
-	skip_tests_if_st2_le_v3
 	skip_tests_if_python3_is_not_available_or_if_already_running_under_python3
 
 	SETUP_VENV_RESULTS=$(st2 run packs.setup_virtualenv packs=examples -j)
@@ -67,7 +49,6 @@ skip_tests_if_python3_is_not_available_or_if_already_running_under_python3() {
 }
 
 @test "packs.setup_virtualenv with python3 flag works" {
-	skip_tests_if_st2_le_v3
 	skip_tests_if_python3_is_not_available_or_if_already_running_under_python3
 
 	SETUP_VENV_RESULTS=$(st2 run packs.setup_virtualenv packs=examples python3=true -j)
@@ -107,7 +88,6 @@ skip_tests_if_python3_is_not_available_or_if_already_running_under_python3() {
 }
 
 @test "python3 imports work correctly" {
-	skip_tests_if_st2_le_v3
 	skip_tests_if_python3_is_not_available_or_if_already_running_under_python3
 
 	run st2 pack install python3_test --python3 -j
@@ -120,7 +100,6 @@ skip_tests_if_python3_is_not_available_or_if_already_running_under_python3() {
 }
 
 @test "TEARDOWN: Uninstall examples and python3_test pack" {
-	skip_tests_if_st2_le_v3
 	skip_tests_if_python3_is_not_available_or_if_already_running_under_python3
 
 	if [[ -d /opt/stackstorm/packs/examples ]]; then