fix script in job-st2canary-for-writable-packs-volume (#411)

Fixes #388

Author: cognifloyd

CHANGELOG.md

@@ -1,7 +1,7 @@
 # Changelog
 
 ## Development
-* Fix syntax with ensure-packs-volumes-are-writable job (#403) (by @skiedude)
+* Fix syntax with ensure-packs-volumes-are-writable job (#403, #411) (by @skiedude)
 * Add securityContext support to custom st2packs images, extra_hooks jobs; Also fallback to st2actionrunner securityContext for misc init container jobs and pods. (#410) (by @cognifloyd)
 * Stop generating the DataStore Secret (#385) and checksum labels (#391) when existing secret provided or disabled (by @bmarick)
 * Stop generating the checksum labels for Auth Secret (#392) when existing secret provided or disabled (by @bmarick)

templates/jobs.yaml

@@ -532,7 +532,7 @@ spec:
         #     readOnly: false
         #   ephemeral volumes could also work, ... but that config is even deeper.
         command:
-          - 'sh'
+          - 'bash'
           # -e => exit on failure
           # -E => trap ERR is inherited in subfunctions
           - '-eEc'
@@ -545,7 +545,7 @@ spec:
             INTRO
 
             function __handle_error__ {
-              cat <<- 'FAIL'
+              cat <<- '  FAIL'
               ERROR: One or more volumes in st2.packs.volumes (from helm values) does not meet
               StackStorm's shared volumes requirements!
               see: https://github.com/StackStorm/stackstorm-k8s#method-2-shared-volumes
@@ -565,6 +565,7 @@ spec:
               echo
             done
             echo DONE
+
         volumeMounts:
         {{- include "stackstorm-ha.packs-volume-mounts" $ | nindent 8 }}
         {{/* do not include the pack-configs-volume-mount helper here */}}