add an initial fix for the redis password not being set in the connection string

Author: rebrowning

templates/_helpers.tpl

@@ -114,6 +114,13 @@ Generate list of nodes for Redis with Sentinel connection string, based on numbe
 {{- end -}}
 {{- end -}}
 
+{{- define "stackstorm-ha.redis-password" -}}
+{{- if not .Values.redis.sentinel.enabled }}
+{{- fail "value for redis.sentinel.enabled MUST be true" }}
+{{- end }}
+{{- if not (empty .Values.redis.password)}}:{{ .Values.redis.password }}@{{- end }}
+{{- end -}}
+
 {{/*
 Reduce duplication of the st2.*.conf volume details
 */}}

templates/configmaps_st2-conf.yaml

@@ -18,7 +18,7 @@ data:
     ssh_key_file = {{ tpl .Values.st2.system_user.ssh_key_file . }}
     {{- if index .Values "redis" "enabled" }}
     [coordination]
-    url = redis://{{ template "stackstorm-ha.redis-nodes" $ }}
+    url = redis://{{ template "stackstorm-ha.redis-password" $ }}{{ template "stackstorm-ha.redis-nodes" $ }}
     {{- end }}
     {{- if index .Values "rabbitmq" "enabled" }}
     [messaging]

values.yaml

@@ -67,7 +67,7 @@ st2:
   config: |
     [api]
     allow_origin = '*'
-  
+
   #Override Definitions can be added here.
   #https://docs.stackstorm.com/latest/packs.html#overriding-pack-defaults
   overrides: {}
@@ -1052,10 +1052,15 @@ redis:
   # https://github.com/bitnami/charts/tree/master/bitnami/redis#master-slave-with-sentinel
   sentinel:
     enabled: true
+    # DO NOT SET sentinel.usePassword, the tooz driver under the hood cannot connect to a password protected sentinel
+    # however it can connect to a password protected redis that is being managed by sentinel
+    # usePassword: false
     # Enable or disable static sentinel IDs for each replicas
     # If disabled each sentinel will generate a random id at startup
     # If enabled, each replicas will have a constant ID on each start-up
     staticID: true
+  # if redis.usePassword is true, you can set the password here
+  # password: mysupersecretpassword
   networkPolicy:
     enabled: false
   usePassword: false