Skip to content

Commit fed0e58

Browse files
committed
Use envFrom for ST2_AUTH_USERNAME/PASSWORD
1 parent 48a8e88 commit fed0e58

File tree

3 files changed

+15
-58
lines changed

3 files changed

+15
-58
lines changed

templates/deployments.yaml

Lines changed: 8 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,9 @@ spec:
5858
- name: generate-htpasswd
5959
image: '{{ template "imageRepository" . }}/st2auth:{{ tpl (.Values.st2auth.image.tag | default .Values.image.tag) . }}'
6060
imagePullPolicy: {{ .Values.image.pullPolicy }}
61-
env:
62-
- name: ST2_AUTH_USERNAME
63-
valueFrom:
64-
secretKeyRef:
65-
name: {{ .Release.Name }}-st2-auth
66-
key: username
67-
- name: ST2_AUTH_PASSWORD
68-
valueFrom:
69-
secretKeyRef:
70-
name: {{ .Release.Name }}-st2-auth
71-
key: password
61+
envFrom:
62+
- secretRef:
63+
name: {{ .Release.Name }}-st2-auth
7264
volumeMounts:
7365
- name: htpasswd-vol
7466
mountPath: /tmp/st2
@@ -1488,17 +1480,8 @@ spec:
14881480
envFrom:
14891481
- configMapRef:
14901482
name: {{ .Release.Name }}-st2-urls
1491-
env:
1492-
- name: ST2_AUTH_USERNAME
1493-
valueFrom:
1494-
secretKeyRef:
1495-
name: {{ .Release.Name }}-st2-auth
1496-
key: username
1497-
- name: ST2_AUTH_PASSWORD
1498-
valueFrom:
1499-
secretKeyRef:
1500-
name: {{ .Release.Name }}-st2-auth
1501-
key: password
1483+
- secretRef:
1484+
name: {{ .Release.Name }}-st2-auth
15021485
volumeMounts:
15031486
- name: st2client-config-vol
15041487
mountPath: /root/.st2/
@@ -1652,17 +1635,9 @@ spec:
16521635
image: '{{ .Values.st2chatops.image.repository | default "stackstorm" }}/{{ .Values.st2chatops.image.name | default "st2chatops" }}:{{ tpl (.Values.st2chatops.image.tag | default .Values.image.tag) . }}'
16531636
imagePullPolicy: {{ .Values.st2chatops.image.pullPolicy | default .Values.image.pullPolicy }}
16541637
{{- if not (hasKey .Values.st2chatops.env "ST2_API_KEY") }}
1655-
env:
1656-
- name: ST2_AUTH_USERNAME
1657-
valueFrom:
1658-
secretKeyRef:
1659-
name: {{ .Release.Name }}-st2-auth
1660-
key: username
1661-
- name: ST2_AUTH_PASSWORD
1662-
valueFrom:
1663-
secretKeyRef:
1664-
name: {{ .Release.Name }}-st2-auth
1665-
key: password
1638+
envFrom:
1639+
- secretRef:
1640+
name: {{ .Release.Name }}-st2-auth
16661641
{{- end }}
16671642
envFrom:
16681643
- configMapRef:

templates/jobs.yaml

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -148,17 +148,8 @@ spec:
148148
envFrom:
149149
- configMapRef:
150150
name: {{ .Release.Name }}-st2-urls
151-
env:
152-
- name: ST2_AUTH_USERNAME
153-
valueFrom:
154-
secretKeyRef:
155-
name: {{ .Release.Name }}-st2-auth
156-
key: username
157-
- name: ST2_AUTH_PASSWORD
158-
valueFrom:
159-
secretKeyRef:
160-
name: {{ .Release.Name }}-st2-auth
161-
key: password
151+
- secretRef:
152+
name: {{ .Release.Name }}-st2-auth
162153
volumeMounts:
163154
- name: st2client-config-vol
164155
mountPath: /root/.st2/
@@ -269,17 +260,8 @@ spec:
269260
envFrom:
270261
- configMapRef:
271262
name: {{ .Release.Name }}-st2-urls
272-
env:
273-
- name: ST2_AUTH_USERNAME
274-
valueFrom:
275-
secretKeyRef:
276-
name: {{ .Release.Name }}-st2-auth
277-
key: username
278-
- name: ST2_AUTH_PASSWORD
279-
valueFrom:
280-
secretKeyRef:
281-
name: {{ .Release.Name }}-st2-auth
282-
key: password
263+
- secretRef:
264+
name: {{ .Release.Name }}-st2-auth
283265
volumeMounts:
284266
- name: st2client-config-vol
285267
mountPath: /root/.st2/

templates/secrets_st2auth.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ metadata:
2222
type: Opaque
2323
data:
2424
# Username, used to login to StackStorm system (default: st2admin)
25-
username: {{ required "A valid secret 'st2.username' is required for StackStorm auth!" .Values.st2.username | b64enc | quote }}
25+
ST2_AUTH_USERNAME: {{ required "A valid secret 'st2.username' is required for StackStorm auth!" .Values.st2.username | b64enc | quote }}
2626
# Password, used to login to StackStorm system (default: auto-generated)
2727
{{- $previous := lookup "v1" "Secret" .Release.Namespace $name }}
2828
{{- if and $previous (not .Values.st2.password) }}
29-
password: {{ $previous.data.password }}
29+
ST2_AUTH_PASSWORD: {{ $previous.data.password }}
3030
{{ else }}
31-
password: {{ default (randAlphaNum 12) .Values.st2.password | b64enc | quote }}
31+
ST2_AUTH_PASSWORD: {{ default (randAlphaNum 12) .Values.st2.password | b64enc | quote }}
3232
{{ end }}

0 commit comments

Comments
 (0)