Skip to content

Commit ef8f40e

Browse files
committed
_Fields.__contains__ fails on invalid field
This method now only masks `MissingDataError` instead of any `StagpyError`. In particular, checking whether an invalid field name is present results in a `UnkownFieldVarError`.
1 parent fd73462 commit ef8f40e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

stagpy/_step.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ def __iter__(self):
280280
def __contains__(self, item):
281281
try:
282282
return self[item] is not None
283-
except error.StagpyError:
283+
except error.MissingDataError:
284284
return False
285285

286286
def __len__(self):

tests/test_field.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
import stagpy.phyvars
55

66

7-
def test_field_unknow(step):
7+
def test_field_unknown(step):
88
with pytest.raises(stagpy.error.UnknownFieldVarError):
99
step.fields['InvalidField']
10-
assert 'InvalidField' not in step.fields
10+
assert 'InvalidField' in step.fields
1111

1212

1313
def test_field_missing(step):

0 commit comments

Comments
 (0)