Improve tests

Author: Alex

phpunit.xml.dist

@@ -1,11 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" bootstrap="./tests/bootstrap.php" backupGlobals="false" colors="true">
-  <coverage>
-    <include>
-      <directory suffix=".php">./src</directory>
-    </include>
-    <exclude/>
-  </coverage>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.0/phpunit.xsd" bootstrap="./tests/bootstrap.php" backupGlobals="false" colors="true">
   <php>
     <ini name="error_reporting" value="-1"/>
     <const name="PHPUNIT_TESTSUITE" value="true"/>
@@ -15,4 +9,10 @@
       <directory>./tests/</directory>
     </testsuite>
   </testsuites>
+  <source>
+    <include>
+      <directory suffix=".php">./src</directory>
+    </include>
+    <exclude/>
+  </source>
 </phpunit>

tests/CommentsClientAnalyzeTest.php

@@ -6,9 +6,11 @@
 use PHPUnit\Framework\TestCase;
 
 class CommentsClientAnalyzeTest extends TestCase {
-    /** @var CommentsResponse */
-    protected static $response;
+    protected static CommentsResponse $response;
 
+    /**
+     * @throws CommentsException
+     */
     public static function setUpBeforeClass(): void {
         $commentsClient = new CommentsClient($_ENV['PERSPECTIVE_API_TOKEN']);
         $commentsClient->comment(['text' => 'What kind of idiot name is foo? Sorry, I like your name.']);
@@ -32,7 +34,7 @@ public function testAttributeScores(): void {
 
         $this->assertIsArray($attributeScores);
         $this->arrayHasKey('TOXICITY');
-        $this->assertGreaterThan(0.8, $attributeScores['TOXICITY']['summaryScore']['value']);
+        $this->assertGreaterThan(0.7, $attributeScores['TOXICITY']['summaryScore']['value']);
     }
 
     public function testLanguages() {
@@ -50,9 +52,10 @@ public function testClientToken() {
 
     public function testCommentsException() {
         $this->expectException(CommentsException::class);
-        $this->expectExceptionMessage('The request is missing a valid API key.');
+        $this->expectExceptionMessage('API key not valid. Please pass a valid API key.');
 
-        $commentsClient = new CommentsClient('');
+        $commentsClient = new CommentsClient('invalid key');
+        $commentsClient->comment(['text' => 'What kind of idiot name is foo? Sorry, I like your name.']);
         $commentsClient->analyze();
     }
 }

tests/CommentsClientSuggestScoreTest.php

@@ -6,8 +6,7 @@
 use PHPUnit\Framework\TestCase;
 
 class CommentsClientSuggestScoreTest extends TestCase {
-    /** @var CommentsResponse */
-    protected static $response;
+    protected static CommentsResponse $response;
 
     public static function setUpBeforeClass(): void {
         $commentsClient = new CommentsClient($_ENV['PERSPECTIVE_API_TOKEN']);
@@ -39,9 +38,10 @@ public function testClientToken() {
 
     public function testCommentsException() {
         $this->expectException(CommentsException::class);
-        $this->expectExceptionMessage('The request is missing a valid API key.');
+        $this->expectExceptionMessage('API key not valid. Please pass a valid API key.');
 
-        $commentsClient = new CommentsClient('');
+        $commentsClient = new CommentsClient('invalid key');
+        $commentsClient->comment(['text' => 'What kind of idiot name is foo? Sorry, I like your name.']);
         $commentsClient->suggestScore();
     }
 }